Skip to content

incremental: Hide lang_items behind a query in the TyCtxt #44190

New issue
New issue
Closed
Closed
incremental: Hide lang_items behind a query in the TyCtxt#44190
Assignees
alexcrichton
Labels
A-incr-compArea: Incremental compilationC-enhancementCategory: An issue proposing an enhancement or a PR with one.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Description

@alexcrichton
alexcrichton
opened on Aug 30, 2017

Right now this is calculated and passed into the TyCtxt, let's convert this to a query and then calculate it on-demand!

This'll also allow us to remove CrateStore::{lang_items, missing_lang_items} and convert them to queries as well.

Activity

  1. Imagealexcrichton
    added
    A-incr-compArea: Incremental compilation
    on Aug 30, 2017

  2. nikomatsakis commented on Aug 30, 2017

    @nikomatsakis
    nikomatsakis
    on Aug 30, 2017
    Contributor

    cc me

  3. Imagenikomatsakis
    added
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    on Aug 30, 2017
  4. Imagealexcrichton
    self-assigned this
    on Aug 31, 2017

  5. alexcrichton commented on Aug 31, 2017

    @alexcrichton
    alexcrichton
    on Aug 31, 2017
    MemberAuthor

    I've implemented this on a local branch, will post it soon

  6. Imageshepmaster
    added
    C-enhancementCategory: An issue proposing an enhancement or a PR with one.
    on Sep 1, 2017
  7. Imagealexcrichton
    closed this as completedin #44142on Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-incr-compArea: Incremental compilationC-enhancementCategory: An issue proposing an enhancement or a PR with one.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions