Skip to content

Entry::and_modify should use FnOnce #49581

Closed

Description

@Zoxc

This should change to use FnOnce instead of FnMut before it lands on stable.
https://doc.rust-lang.org/std/collections/hash_map/enum.Entry.html#method.and_modify

cc @rust-lang/libs

Activity

  1. added
    beta-nominatedNominated for backporting to the compiler in the beta channel.
    on Apr 2, 2018
  2. added
    T-libs-api[DEPRECATED; DO NOT USE]
    and removed
    beta-nominatedNominated for backporting to the compiler in the beta channel.
    on Apr 2, 2018
  3. alexcrichton commented on Apr 2, 2018

    @alexcrichton
    Member

    Labelling as a regression to ensure we keep track of this, although it's not technically a regression

  4. added this to the 1.26 milestone on Apr 2, 2018
  5. added a commit that references this issue on Apr 20, 2018
    a10bb6b
  6. sugar700 commented on May 3, 2018

    @sugar700
    Contributor

    Now that this is fixed, should it be marked as regression-from-stable-to-beta. It's technically not a regression, it's was marked as such for tracking purposes.

  7. alexcrichton commented on May 3, 2018

    @alexcrichton
    Member

    Ah that tag is primarily used for open issue, once closed the tags on an issue are anyone's guess :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-libs-api[DEPRECATED; DO NOT USE]regression-from-stable-to-betaPerformance or correctness regression from stable to beta.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions