Skip to content

Tracking issue for hint::spin_loop (renamed sync::atomic::spin_loop_hint) #55002

Closed

Description

@clarfonthey

Now that we have at least one thing in std::hint it makes sense to move this to std::hint::spin_loop.


EDIT (@KodrAus)

Before stabilisation:

  • Decide on new function name (hint::spin_loop or spin_loop_hint)

Stabilisation/deprecation:

Activity

  1. changed the title [-]std::sync::atomic::spin_loop_hint should be in std::hint[/-] [+]Tracking issue for hint::spin_loop (renamed sync::atomic::spin_loop_hint)[/+] on Jan 15, 2019
  2. added
    C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFC
    on Jan 16, 2019
  3. added 3 commits that reference this issue on Jan 17, 2019
  4. added a commit that references this issue on Jan 18, 2019
  5. gnzlbg commented on Mar 16, 2019

    @gnzlbg
    Contributor

    spin_loop currently invokes undefined behavior on x86 and x86_64 targets without SSE2. One of those targets is tier-1: i686-apple-darwin.

  6. hanna-kruppe commented on Mar 16, 2019

    @hanna-kruppe
    Contributor

    Are you sure? The target spec for that sets the cpu to Yonah, which has SSE2.

  7. gnzlbg commented on Mar 16, 2019

    @gnzlbg
    Contributor

    @rkruppe if that was fixed we should close: #53423

  8. gnzlbg commented on Mar 16, 2019

    @gnzlbg
    Contributor

    @rkruppe indeed, that's fixed, I've closed that issue.

  9. clarfonthey commented on Mar 20, 2019

    @clarfonthey
    ContributorAuthor

    Note that this isn't a tracking issue for the function itself; it's already stable and any bugs/qualms are reported separately. This is just for the renaming of it.

  10. zopsicle commented on Oct 21, 2019

    @zopsicle
    Contributor

    If this routine is moved to std::hint then the documentation of std::hint should be updated as well. It currently reads:

    Hints to compiler that affects how code should be emitted or optimized.

    Pause instruction is a hint to the CPU, not to the compiler.

  11. clarfonthey commented on Oct 22, 2019

    @clarfonthey
    ContributorAuthor

    I agree; it should be changed to "compiler and/or CPU".

  12. 47 remaining items

  13. added a commit that references this issue on Jan 14, 2021
  14. KodrAus commented on Jan 15, 2021

    @KodrAus
    Contributor

    Now that atomic::spin_loop_hint is deprecated I'll go ahead and close this tracking issue.

  15. added a commit that references this issue on Jul 7, 2021
  16. added
    I-libs-radarLibs issues that are tracked on the team's radar.
    and removed
    I-libs-radarLibs issues that are tracked on the team's radar.
    on Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    B-unstableBlocker: Implemented in the nightly compiler and unstable.C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCI-libs-radarLibs issues that are tracked on the team's radar.T-libs-api[DEPRECATED; DO NOT USE]disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.finished-final-comment-periodThe final comment period is finished for this PR / Issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions