You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
nightly panicked at 'assertion failed: directive.imported_module.get().is_none()' #56182
In my rust-toolchain file I have nightly-2018-11-23. When I change it to nightly-2018-11-20 it also panics but not with e.g. nightly-2018-10-31, there it doesn't panic but shows this error:
error: `actix` import is ambiguous
--> src\db.rs:2:5
|
2 | use actix::prelude::*;
| ^^^^^------------
| |
| can refer to external crate `::actix`
| may refer to `self::actix` in the future
|
= help: write `::actix` or `self::actix` explicitly instead
= note: in the future, `#![feature(uniform_paths)]` may become the default
Btw, this project is also doing use actix::prelude::*; in 2 places, and using edition 2018. So maybe it is related to the other issue?
@Boscop
I know where exactly this assert is in rustc, when it was introduced and how it's related to the other issues, but I cannot fix this without a code snippet reproducing the ICE.
@petrochenkov After I changed the import to use ::actix::prelude::*; it builds fine with nightly-2018-11-23, too. So I think the issue is the same as #56125 and the minimal example crate would also be the same: https://github.com/tmpolaczyk/actix_ice
https://github.com/tmpolaczyk/actix_ice is indeed fixed and the fix has reached nightly, so this is a separate issue (as I suspected from the line number in the ICE), in this case reproduction is still needed.
Activity
petrochenkov commentedon Nov 23, 2018
Hmm, this should be different from #56125 according to the line number.
@Boscop
Could you give some minimized reproduction?
Before adding this assert I tried to construct a case where it would be hit, but couldn't.
Boscop commentedon Nov 23, 2018
@petrochenkov
In my rust-toolchain file I have
nightly-2018-11-23. When I change it tonightly-2018-11-20it also panics but not with e.g.nightly-2018-10-31, there it doesn't panic but shows this error:Btw, this project is also doing
use actix::prelude::*;in 2 places, and using edition 2018. So maybe it is related to the other issue?petrochenkov commentedon Nov 23, 2018
@Boscop
I know where exactly this assert is in rustc, when it was introduced and how it's related to the other issues, but I cannot fix this without a code snippet reproducing the ICE.
Boscop commentedon Nov 23, 2018
@petrochenkov After I changed the import to
use ::actix::prelude::*;it builds fine withnightly-2018-11-23, too. So I think the issue is the same as #56125 and the minimal example crate would also be the same: https://github.com/tmpolaczyk/actix_icepetrochenkov commentedon Nov 23, 2018
If this is https://github.com/tmpolaczyk/actix_ice, then it should be already fixed in #56147.
I'll check again.
petrochenkov commentedon Nov 23, 2018
https://github.com/tmpolaczyk/actix_ice is indeed fixed and the fix has reached nightly, so this is a separate issue (as I suspected from the line number in the ICE), in this case reproduction is still needed.
petrochenkov commentedon Nov 25, 2018
I still cannot reproduce this and from code I don't understand how that assert (
rust/src/librustc_resolve/resolve_imports.rs
Line 867 in edaac35
Denominating from Rust 2018 Release, but keeping it open for now in case @Boscop comes up with a working reproduction.
petrochenkov commentedon Nov 25, 2018
Reproduced and fixed in #56206
Auto merge of #56206 - petrochenkov:betaregr, r=alexcrichton
alexcrichton commentedon Nov 25, 2018
Fixed in #56206