Repository navigation
Rename mir::Mir to mir::Body, by analogy with hir::Body. #60229
Description
I think it would make more sense than the current setup, as a Mir coresponds to the body of a constant or function, in MIR.
Also, MIR encompasses more than just bodies - e.g. the miri value representation, but arguably the whole type/trait-system (including chalk) could be considered an integral part of "the Mid-level rustc IR".
- rename the types (done in Changes the type
mir::Mirintomir::Body#60928) - rename variable, argument and field names to
mir_bodywhere it used to bemir
cc @rust-lang/compiler
Reacted by Mazdak Farrokhzad, Hanna Kruppe, Wesley Wiser and Esteban Kuber
Reacted by oli, David Wood, Mazdak Farrokhzad and Wesley Wiser
Activity
marimeireles commentedon Apr 24, 2019
Hi @eddyb can I take this one this one to get my feet wet on rust?
nikomatsakis commentedon Apr 24, 2019
I feel pretty good about this naming. As far as process, I feel like we could probably make this specific decision rather quickly. We could also try to have a dedicated nomenclature discussion, where we look over a lot of names and try to "harmonize" them, rather than doing things piecemeal. But this particular choice feels like a clear win.
eddyb commentedon Apr 24, 2019
@marimeireles Sure, go ahead!
Rollup merge of rust-lang#60928 - TheSirC:fix/60229, r=eddyb
Rollup merge of rust-lang#60928 - TheSirC:fix/60229, r=eddyb
Rollup merge of rust-lang#60928 - TheSirC:fix/60229, r=eddyb
Rollup merge of rust-lang#60928 - TheSirC:fix/60229, r=eddyb
imbrem commentedon Jun 3, 2019
Could I try part 2 of this, or is it already taken?
varkor commentedon Jun 3, 2019
@imbrem: it looks like no-one else is working on this, so go ahead!
eddyb commentedon Jun 3, 2019
Not sure it should be
mir_body- in MIR-specific code, such as all ofrustc::mirandrustc_mir, it could just bebody, as it would be unambiguous.imbrem commentedon Jun 3, 2019
@eddyb I agree. I'll get to it in a few hours or so!
imbrem commentedon Jun 3, 2019
Oh also, what do I do about the lifetime
'mir. Just leave it as is?Auto merge of #61506 - imbrem:mir_body_renaming, r=eddyb
JohnTitor commentedon Jul 25, 2019
Does #61506 make the second checkbox checked? @eddyb
imbrem commentedon Jul 25, 2019
@JohnTitor that was certainly my intention haha
oli-obk commentedon Jul 27, 2019
Yea this looks resolved to me