Skip to content

extern crate ... as std overrides the injected crate on 2018 edition #61019

New issue
New issue
Closed
#75145
Closed
extern crate ... as std overrides the injected crate on 2018 edition#61019
#75145
Assignees
davidtwco
Labels
A-HIRArea: The high-level intermediate representation (HIR)A-resolveArea: Name/path resolution done by `rustc_resolve` specificallyC-bugCategory: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-langRelevant to the language team

Description

@matthewjasper
matthewjasper
opened on May 21, 2019

On the 2018 edition the following code:

extern crate some_crate as std; // or as core with #![no_std]

will:

  • Try to resolve prelude::v1::* in some_crate, failing if it doesn't exist. This probably limits the plausible cases where this could happen to extern crate core as std, and extern crate core as std with #![no_std].
  • Use some_crate in any built-in derives and for HIR lowering.

I would expect that the prelude and derives/HIR lowering to always use the injected std/core. Paths starting with std should still resolve to the in the crate the user provided.

In the 2015 edition it creates a name conflict with the implicit extern crate std.

cc @petrochenkov @eddyb

Activity

  1. Imagejonas-schievink
    added
    A-HIRArea: The high-level intermediate representation (HIR)
    A-resolveArea: Name/path resolution done by `rustc_resolve` specifically
    on May 21, 2019
  2. ImageCentril
    added
    T-langRelevant to the language team
    on May 21, 2019
  3. ImageCentril
    added a commit that references this issue on Sep 7, 2019

    Rollup merge of rust-lang#63919 - matthewjasper:remove-gensymmed, r=p…

    db493ef

  4. Centril commented on Dec 1, 2019

    @Centril
    Centril
    on Dec 1, 2019
    Contributor

    This would be fixed by #60607.

  5. ImageCentril
    added
    C-bugCategory: This is a bug.
    on Dec 1, 2019
  6. Imagejonas-schievink
    added
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    on Dec 1, 2019
  7. Imagedavidtwco
    self-assigned this
    on Aug 4, 2020

  8. davidtwco commented on Aug 4, 2020

    @davidtwco
    davidtwco
    on Aug 4, 2020
    Member

    Opened #75145 which fixes this.

  9. Imagedavidtwco
    added 2 commits that reference this issue on Aug 16, 2020

    tests: add test for rust-lang#61019's current behaviour

    734441c

    hir: introduce `QPath::LangItem`

    762137e
  10. ImageDylan-DPC-zz
    added a commit that references this issue on Aug 16, 2020

    Rollup merge of rust-lang#75145 - davidtwco:issue-60607-preallocate-d…

    3e5ce7b
  11. Imagebors
    closed this as completedin 792c645on Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-HIRArea: The high-level intermediate representation (HIR)A-resolveArea: Name/path resolution done by `rustc_resolve` specificallyC-bugCategory: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-langRelevant to the language team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions