rls no longer builds after rust-lang/rust#61274 #61287

Activity

1. rust-highfive

   assigned

   Xanewok

   and

   Centril

   on May 28, 2019
2. rust-highfive

   added

   I-nominated

   T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.

   on May 28, 2019
3. Centril commented on May 28, 2019

   

   Centril

   on May 28, 2019

   Contributor

   More actions

   I'm going to guess that #61164 is to blame; cc @RalfJung
4. Centril

   assigned

   RalfJung

   and unassigned

   Centril

   on May 28, 2019
5. RalfJung commented on May 28, 2019

   

   RalfJung

   on May 28, 2019

   Member

   More actions

   The fix is mostly to replace Scalar::Bits { bits, size } by Scalar::Raw { data, size }.

   But really RLS shouldn't be using such implementation details...
6. RalfJung commented on May 28, 2019

   

   RalfJung

   on May 28, 2019

   Member

   More actions

   The logs look like the failure is in clippy, not RLS? I am confused.

   [01:20:23] �[0m�[0m�[1m�[32m   Compiling�[0m clippy_lints v0.0.212 (/checkout/src/tools/clippy/clippy_lints)
   [01:20:28] �[0m�[1m�[38;5;9merror�[0m�[0m�[1m: no variant `Bits` in enum `rustc_mir::interpret::Scalar<_, _>`�[0m
   [01:20:28] �[0m   �[0m�[0m�[1m�[38;5;12m--> �[0m�[0msrc/tools/clippy/clippy_lints/src/consts.rs:475:36�[0m
   [01:20:28] �[0m    �[0m�[0m�[1m�[38;5;12m|�[0m
   [01:20:28] �[0m�[1m�[38;5;12m475�[0m�[0m �[0m�[0m�[1m�[38;5;12m| �[0m�[0m        ConstValue::Scalar(Scalar::Bits { bits: b, .. }) => match result.ty.sty {�[0m
   [01:20:28] �[0m    �[0m�[0m�[1m�[38;5;12m| �[0m�[0m                           �[0m�[0m�[1m�[38;5;12m--------�[0m�[0m�[1m�[38;5;9m^^^^�[0m
   [01:20:28] �[0m    �[0m�[0m�[1m�[38;5;12m| �[0m�[0m                           �[0m�[0m�[1m�[38;5;12m|�[0m
   [01:20:28] �[0m    �[0m�[0m�[1m�[38;5;12m| �[0m�[0m                           �[0m�[0m�[1m�[38;5;12mvariant not found in `rustc_mir::interpret::Scalar<_, _>`�[0m
   [01:20:28] 
   [01:20:28] �[0m�[1m�[38;5;9merror�[0m�[0m�[1m: no variant `Bits` in enum `rustc_mir::interpret::Scalar<_, _>`�[0m
   [01:20:28] �[0m   �[0m�[0m�[1m�[38;5;12m--> �[0m�[0msrc/tools/clippy/clippy_lints/src/consts.rs:475:36�[0m
   [01:20:28] �[0m    �[0m�[0m�[1m�[38;5;12m|�[0m
   [01:20:28] �[0m�[1m�[38;5;12m475�[0m�[0m �[0m�[0m�[1m�[38;5;12m| �[0m�[0m        ConstValue::Scalar(Scalar::Bits { bits: b, .. }) => match result.ty.sty {�[0m
   [01:20:28] �[0m    �[0m�[0m�[1m�[38;5;12m| �[0m�[0m                           �[0m�[0m�[1m�[38;5;12m--------�[0m�[0m�[1m�[38;5;9m^^^^�[0m
   [01:20:28] �[0m    �[0m�[0m�[1m�[38;5;12m| �[0m�[0m                           �[0m�[0m�[1m�[38;5;12m|�[0m
   [01:20:28] �[0m    �[0m�[0m�[1m�[38;5;12m| �[0m�[0m                           �[0m�[0m�[1m�[38;5;12mvariant not found in `rustc_mir::interpret::Scalar<_, _>`�[0m
   [01:20:28] 
   [01:20:31] �[0m�[1m�[38;5;9merror�[0m�[0m�[1m: aborting due to previous error�[0m
   

   (Great logs as usual, thanks Travis.)

   😄React with 😄1Reacted by Mazdak Farrokhzad
7. eddyb commented on May 28, 2019

   

   eddyb

   on May 28, 2019

   Contributor

   More actions

   @RalfJung breaking clippy breaks RLS, AFAIK.

   👍React with 👍1Reacted by Mazdak Farrokhzad
8. matthiaskrgr commented on May 28, 2019

   

   matthiaskrgr

   on May 28, 2019

   Member

   More actions

   rust-lang/rust-clippy#4152 will fix it, only needs ci to pass.
9. bors

   closed this as completedin #61298on May 31, 2019