Improve recovery diagnostic for for ( $pat in $expr ) $block #63113

Activity

1. Centril

   added

   C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.

   A-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lints

   T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.

   A-suggestion-diagnosticsArea: Suggestions generated by the compiler applied by `cargo fix`Area: Suggestions generated by the compiler applied by `cargo fix`

   on Jul 29, 2019
2. Centril commented on Jul 29, 2019

   

   Centril

   on Jul 29, 2019

   ContributorAuthor

   More actions

   Some notes:

   We have two errors pointing at the problem here (the prior "in not expected" error, but it's ok emitting both for now)

   I think this is not worth fixing as it would require hacks deep in the general sequence parser.

   Suggestions that have very subtle changes sometimes make people not pay attention to the text, in this case people might not realize the lack of parenthesis in the suggested code.

   We should try to still have MachineApplicable suggestions; @estebank notes that there are special purpose methods for doing that.

   error: unnecessary parenthesis surroundinig for loop head

   "Unnecessary" is semantically misleading here as this is a hard error, not a lint.

   👍React with 👍1Reacted by Esteban Kuber
3. estebank

   added

   D-papercutDiagnostics: An error or lint that needs small tweaks.Diagnostics: An error or lint that needs small tweaks.

   on Oct 5, 2019
4. GuillaumeGomez

   added a commit that references this issue on Sep 17, 2021

   Rollup merge of rust-lang#86422 - JohnTitor:clearer-parens-err-for-lo…

   ...

   This issue will close once commit b6d0cca is merged into the 'main' branch.

   b6d0cca
5. bors

   closed this as completedin b6d0ccaon Sep 17, 2021