You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
rust-intrinsic ABI functions should be unsafe #6370
This seems like it should be a pretty easy change to make, so giving this E-easy. The relevant function to change is check_intrinsic_type in middle/typeck/check/mod.rs.
Activity
alexcrichton commentedon May 9, 2013
It seems like some of them like
sinf32/logf32/etc probably shouldn't be unsafe. Other ones likeforget/init/atomic_*probably should be unsafe.The safe ones could be re-exported via a non-unsafe function though, because default
unsafeis probably more reasonable.thestinger commentedon May 9, 2013
I would prefer if they were unsafe by default and you could explicitly tag them with
#[safe].bblum commentedon Jul 3, 2013
nominating backwards-compatible
bblum commentedon Jul 3, 2013
This seems like it should be a pretty easy change to make, so giving this E-easy. The relevant function to change is
check_intrinsic_typeinmiddle/typeck/check/mod.rs.bblum commentedon Aug 12, 2013
what, i just had this bug for triage a month ago
catamorphism commentedon Aug 29, 2013
@brson says this is an implementation detail. De-milestoning
alexcrichton commentedon Aug 30, 2013
This appears to have been done now, all intrinsics are unsafe.
We can explicitly expose safe versions if we need to.
Auto merge of rust-lang#6370 - giraffate:fix_fp_in_unnecessary_lazy_e…