Skip to content

3rd party objects missing from nightly-2019-10-12 #65335

New issue
New issue
Closed
Closed
3rd party objects missing from nightly-2019-10-12#65335
Labels
C-bugCategory: This is a bug.O-muslTarget: The musl libcO-windows-gnuToolchain: GNU, Operating system: WindowsP-highHigh priorityT-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.regression-from-stable-to-nightlyPerformance or correctness regression from stable to nightly.

Description

@jethrogb
jethrogb
opened on Oct 12, 2019
$ rustup toolchain add nightly-2019-10-11
$ rustup toolchain add nightly-2019-10-12
$ rustup target add --toolchain nightly-2019-10-11 x86_64-fortanix-unknown-sgx
$ rustup target add --toolchain nightly-2019-10-12 x86_64-fortanix-unknown-sgx
$ ls .rustup/toolchains/nightly-2019-10-11-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-fortanix-unknown-sgx/lib/libunwind.a
.rustup/toolchains/nightly-2019-10-11-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-fortanix-unknown-sgx/lib/libunwind.a
$ ls .rustup/toolchains/nightly-2019-10-12-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-fortanix-unknown-sgx/lib/libunwind.a
ls: cannot access '.rustup/toolchains/nightly-2019-10-12-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-fortanix-unknown-sgx/lib/libunwind.a': No such file or directory

Activity

  1. Imagejethrogb
    changed the title [-]3rd party libraries missing from nightly-2019-10-12 for target x86_64-fortanix-unknown-sgx[/-] [+]3rd party libraries missing from nightly-2019-10-12[/+] on Oct 12, 2019

  2. jethrogb commented on Oct 12, 2019

    @jethrogb
    jethrogb
    on Oct 12, 2019
    ContributorAuthor

    x86_64-unknown-linux-musl is also affected

    Checkout the size difference:

    $ rustup target add --toolchain nightly-2019-10-12 x86_64-unknown-linux-musl
info: downloading component 'rust-std' for 'x86_64-unknown-linux-musl'
 16.2 MiB /  16.2 MiB (100 %)   3.6 MiB/s ETA:   0 s                
info: installing component 'rust-std' for 'x86_64-unknown-linux-musl'
$ rustup target add --toolchain nightly-2019-10-11 x86_64-unknown-linux-musl
info: downloading component 'rust-std' for 'x86_64-unknown-linux-musl'
172.9 MiB / 172.9 MiB (100 %)   3.8 MiB/s ETA:   0 s                
info: installing component 'rust-std' for 'x86_64-unknown-linux-musl'

    Link error when trying to build a musl binary:

      = note: cc: error: crt1.o: No such file or directory
          cc: error: crti.o: No such file or directory
          cc: error: crtn.o: No such file or directory
  3. Imagejethrogb
    changed the title [-]3rd party libraries missing from nightly-2019-10-12[/-] [+]3rd party objects missing from nightly-2019-10-12[/+] on Oct 12, 2019

  4. mati865 commented on Oct 12, 2019

    @mati865
    mati865
    on Oct 12, 2019
    Member

    I checked rust-std, rustc and rustc-dev components and libs mentioned above are totally gone.

    @rustbot modify labels: +T-release +C-bug

  5. Imagerustbot
    added
    C-bugCategory: This is a bug.
    T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.
    on Oct 12, 2019
  6. Imagejonas-schievink
    added
    I-nominated
    T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
    on Oct 12, 2019

  7. mati865 commented on Oct 12, 2019

    @mati865
    mati865
    on Oct 12, 2019
    Member

    Tier-1 windows-gnu toolchain is also broken:

      = note: gcc.exe: error: crt2.o: No such file or directory
          gcc.exe: error: rsbegin.o: No such file or directory
          gcc.exe: error: rsend.o: No such file or directory
  8. Imagejonas-schievink
    added
    O-muslTarget: The musl libc
    O-windows-gnuToolchain: GNU, Operating system: Windows
    on Oct 12, 2019
  9. Imageemilyalbini
    added
    regression-from-stable-to-nightlyPerformance or correctness regression from stable to nightly.
    P-highHigh priority
    on Oct 12, 2019

  10. emilyalbini commented on Oct 12, 2019

    @emilyalbini
    emilyalbini
    on Oct 12, 2019
    Member

    cc @rust-lang/release

  11. emilyalbini commented on Oct 12, 2019

    @emilyalbini
    emilyalbini
    on Oct 12, 2019
    Member

    So @rust-lang/release, as the rustc-dev PR broke tons of tier 2 targets and even a tier 1 target, I'd say for now we should revert the change and then land it again once it's properly fixed and tested on most of the platforms we support.

    I think the priority should be keeping nightly as usable as possible (thus reverting the PR), reducing the stdlib size is less important and can be done later.

  12. 8 remaining items

  13. gnzlbg commented on Oct 14, 2019

    @gnzlbg
    gnzlbg
    on Oct 14, 2019
    Contributor

    All libc musl build jobs are also failing, probably due to this.

  14. Imageemilyalbini
    unpinned this issue on Oct 14, 2019
  15. Imageemilyalbini
    pinned this issue on Oct 14, 2019

  16. cuviper commented on Oct 14, 2019

    @cuviper
    cuviper
    on Oct 14, 2019
    Member

    Revert #65342 landed 15 hours ago, so the next nightly should have the original full rust-std again. We'll retry the limited set later, with any 3rd party objects needed, but first I want to figure out how to sanity-check the dist package in CI for all targets so this doesn't regress.

    There is a distcheck job, but only for x86_64-unknown-linux-gnu, which wasn't affected. On Discord we were talking about adding a simple "hello world" test as something quick for all targets.

  17. Imageemilyalbini
    unpinned this issue on Oct 15, 2019

  18. emilyalbini commented on Oct 15, 2019

    @emilyalbini
    emilyalbini
    on Oct 15, 2019
    Member

    This should be fixed in the latest nightly.

  19. Imageemilyalbini
    closed this as completedon Oct 15, 2019

  20. jethrogb commented on Oct 15, 2019

    @jethrogb
    jethrogb
    on Oct 15, 2019
    ContributorAuthor

    Yup it is!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-bugCategory: This is a bug.O-muslTarget: The musl libcO-windows-gnuToolchain: GNU, Operating system: WindowsP-highHigh priorityT-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.regression-from-stable-to-nightlyPerformance or correctness regression from stable to nightly.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions