rustdoc: Notable traits shows traits for &[u8] even though the return type is &[Attribute] #83123

Activity

1. camelid

   added

   T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.

   regression-from-stable-to-betaPerformance or correctness regression from stable to beta.Performance or correctness regression from stable to beta.

   C-bugCategory: This is a bug.Category: This is a bug.

   E-needs-bisectionCall for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustcCall for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc

   E-needs-mcveCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable ExampleCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example

   on Mar 14, 2021
2. rustbot

   added

   I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}Issue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}

   on Mar 14, 2021
3. apiraino commented on Mar 17, 2021

   

   apiraino

   on Mar 17, 2021

   Contributor

   More actions

   Assigning P-medium as discussed as part of the Prioritization Working Group procedure and removing I-prioritize.

   @rustbot label -I-prioritize +P-medium
4. rustbot

   added

   P-mediumMedium priorityMedium priority

   and removed

   I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}Issue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}

   on Mar 17, 2021
5. Manishearth

   added

   A-rustdoc

   and removed

   A-rustdoc

   on Apr 23, 2021
6. emilyalbini

   added this to the 1.51.0 milestone on Apr 30, 2021
7. emilyalbini

   added

   regression-from-stable-to-stablePerformance or correctness regression from one stable version to another.Performance or correctness regression from one stable version to another.

   and removed

   regression-from-stable-to-betaPerformance or correctness regression from stable to beta.Performance or correctness regression from stable to beta.

   on Apr 30, 2021
8. emilyalbini commented on Apr 30, 2021

   

   emilyalbini

   on Apr 30, 2021

   Member

   More actions

   This affected 1.51.0, the regressed behavior is also present on stable. Changing the labels.

   👍React with 👍1Reacted by Noah Lev
9. steffahn commented on May 4, 2021

   

   steffahn

   on May 4, 2021

   Last edited by steffahn

   Member

   More actions

   Reduced:

   pub struct Attribute;
   
   pub struct Map<'hir> {}
   impl<'hir> Map<'hir> {
       pub fn attrs(&self) -> &'hir [Attribute] { &[] }
   }
   
   pub struct List<T>(T);
   
   impl<T> std::ops::Deref for List<T> {
       type Target = [T];
       fn deref(&self) -> &[T] {
           &[]
       }
   }

   reduced example regresses at nightly-2021-01-09, 937f629 / #80653

   The original rustc_middle docs regresses at the same nightly.

   @rustbot label -E-needs-bisection -E-needs-mcve

   ❤️React with ❤️1Reacted by Noah Lev
10. rustbot

    removed

    E-needs-bisectionCall for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustcCall for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc

    E-needs-mcveCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable ExampleCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example

    on May 4, 2021
11. camelid commented on May 5, 2021

    

    camelid

    on May 5, 2021

    MemberAuthor

    More actions

    Hmm, I wonder if the revert of that PR will fix this bug then. CC #84867. Would be nice to check once that PR is merged.
12. camelid commented on Oct 22, 2021

    

    camelid

    on Oct 22, 2021

    MemberAuthor

    More actions

    This issue seems to be fixed now, presumably because of the revert I mentioned above.
13. camelid

    closed this as completedon Oct 22, 2021