Special case suggestion for missing tail expression when dealing with Ok(()) and Some(())

The suggestion in the following code isn't great:

error[E0308]: mismatched types
  --> src/main.rs:72:5
   |
72 | /     while let Some(i) = x.try_next().await? {
73 | |         println!("{:?}", i);
74 | |     }
   | |_____^ expected enum `Option`, found `()`
   |
   = note:   expected enum `Option<()>`
           found unit type `()`
help: try using a variant of the expected enum
   |
72 ~     Some(while let Some(i) = x.try_next().await? {
73 +         println!("{:?}", i);
74 +     })
   |

It makes sense why it happens: the while let expression resolves to type (), it's the tail expression of an async fn that returns Option<()>, so wrapping the expression in Some(()) would make the type checker happy, but suggesting that seems almost always wrong? I think I would prefer it if we special cased this and didn't gave a suggestion for Result<(), _> or Option<()>.

How about something like this?

(Just need to figure out a way to detect whether the expression was the final one in a block.)

That looks good!

Rollup merge of rust-lang#90575 - m-ou-se:compatible-variant-improvem…

Re-opening this, because it doesn't work yet for for loops:

help: try wrapping the expression in `Ok`
  |
4 ~     Ok(for _ in x {
5 |         ...
6 ~     })
  |

Rollup merge of rust-lang#93072 - m-ou-se:compatible-variants-suggest…

Navigation Menu

Repository navigation

Special case suggestion for missing tail expression when dealing with `Ok(())` and `Some(())` #90553

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Special case suggestion for missing tail expression when dealing with Ok(()) and Some(()) #90553

Description

Activity

m-ou-se commented on Nov 4, 2021

m-ou-se commented on Nov 4, 2021

estebank commented on Nov 4, 2021

m-ou-se commented on Jan 19, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Special case suggestion for missing tail expression when dealing with `Ok(())` and `Some(())` #90553