Skip to content

Rollup of 2 pull requests - #105820

Merged
bors merged 5 commits into
rust-lang:masterfrom
matthiaskrgr:rollup-uzm1l8f
Dec 17, 2022
Merged

bors merged 5 commits into
rust-lang:masterfrom
matthiaskrgr:rollup-uzm1l8f

Conversation

@matthiaskrgr

Copy link
Copy Markdown
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

JohnTitor and others added 5 commits December 15, 2022 15:04
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
…mpiler-errors

Rename ConstS to ConstData

just a style nit to get it in sync with all the other interned datastructures
…r-errors

Add regression test for rust-lang#55976

Closes rust-lang#55976
r? `@compiler-errors`

Signed-off-by: Yuki Okushi <jtitor@2k36.org>
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Dec 17, 2022
@matthiaskrgr

Copy link
Copy Markdown
Member Author

@bors r+ rollup=never p=2

@bors

bors commented Dec 17, 2022

Copy link
Copy Markdown
Collaborator

πŸ“Œ Commit 905caed has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2022
@bors

bors commented Dec 17, 2022

Copy link
Copy Markdown
Collaborator

βŒ› Testing commit 905caed with merge 49c2279...

@bors

bors commented Dec 17, 2022

Copy link
Copy Markdown
Collaborator

β˜€οΈ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 49c2279 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 17, 2022
@bors
bors merged commit 49c2279 into rust-lang:master Dec 17, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 17, 2022
@rust-timer

Copy link
Copy Markdown
Collaborator

πŸ“Œ Perf builds for each rolled up PR:

PR# Perf Build Sha
#105785 16cc9670e71d16fc57b3e2a2f436c7231beff9d2
#105770 4e32df8609cd0adc77a412ffde82122a5501b20c

previous master: fde3000299

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (49c2279): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.5% [0.5%, 0.5%] 1
Improvements βœ…
(primary)
- - 0
Improvements βœ…
(secondary)
- - 0
All βŒβœ… (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.9% [4.9%, 4.9%] 1
Improvements βœ…
(primary)
- - 0
Improvements βœ…
(secondary)
- - 0
All βŒβœ… (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants