Skip to content

Migrate item_primitive to Askama - #112032

Merged
bors merged 1 commit into
rust-lang:masterfrom
sladyn98:migrate-item-primitive
Jun 3, 2023
Merged

bors merged 1 commit into
rust-lang:masterfrom
sladyn98:migrate-item-primitive

Conversation

@sladyn98

Copy link
Copy Markdown
Contributor

This PR migrates item_primitive to Askama

Refers #108868

@rustbot

rustbot commented May 28, 2023

Copy link
Copy Markdown
Collaborator

r? @notriddle

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels May 28, 2023
@sladyn98

Copy link
Copy Markdown
Contributor Author

r? @GuillaumeGomez

@rustbot rustbot assigned GuillaumeGomez and unassigned notriddle May 28, 2023
@sladyn98

sladyn98 commented Jun 3, 2023

Copy link
Copy Markdown
Contributor Author

I do not think this needs any more updating.

@notriddle
notriddle requested a review from GuillaumeGomez June 3, 2023 06:30
@GuillaumeGomez

Copy link
Copy Markdown
Member

Thanks!

@bors r+ rollup

@bors

bors commented Jun 3, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit c5e5d69 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2023
@bors

bors commented Jun 3, 2023

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c5e5d69 with merge 2f5e6bb...

@bors

bors commented Jun 3, 2023

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 2f5e6bb to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 3, 2023
@bors
bors merged commit 2f5e6bb into rust-lang:master Jun 3, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 3, 2023
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (2f5e6bb): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.4% [-1.4%, -1.4%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 647.076s -> 647.253s (0.03%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants