Skip to content

miri libstd tests: test windows-msvc instead of windows-gnu - #124270

Merged
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:miri-libstd-win
Apr 23, 2024
Merged

bors merged 1 commit into
rust-lang:masterfrom
RalfJung:miri-libstd-win

Conversation

@RalfJung

Copy link
Copy Markdown
Member

This avoids #123583. MSVC is the more widely used target anyway AFAIK, so probably makes more sense to cover that.

@rustbot

rustbot commented Apr 22, 2024

Copy link
Copy Markdown
Collaborator

r? @onur-ozkan

rustbot has assigned @onur-ozkan.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 22, 2024
@onur-ozkan

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Apr 22, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 8d5c47f has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2024
@RalfJung

RalfJung commented Apr 22, 2024 •

Copy link
Copy Markdown
Member Author

@bors p=1
fixes CI failures in unrelated PRs

@RalfJung

This comment was marked as duplicate.

@bors

bors commented Apr 22, 2024

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 8d5c47f with merge 25087e0...

@bors

bors commented Apr 23, 2024

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: onur-ozkan
Pushing 25087e0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 23, 2024
@bors
bors merged commit 25087e0 into rust-lang:master Apr 23, 2024
@rustbot rustbot added this to the 1.79.0 milestone Apr 23, 2024
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (25087e0): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.7% [0.7%, 0.7%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.9% [-3.9%, -3.9%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -3.9% [-3.9%, -3.9%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 670.936s -> 672.766s (0.27%)
Artifact size: 315.45 MiB -> 315.42 MiB (-0.01%)

@RalfJung
RalfJung deleted the miri-libstd-win branch April 23, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants