Skip to content

Move std::pipe::* into std::io - #135583

Merged
bors merged 3 commits into
rust-lang:masterfrom
NobodyXu:move-pipe-to-io
Jan 18, 2025
Merged

Move std::pipe::* into std::io#135583
bors merged 3 commits into
rust-lang:masterfrom
NobodyXu:move-pipe-to-io

Conversation

@NobodyXu

@NobodyXu NobodyXu commented Jan 16, 2025

Copy link
Copy Markdown
Contributor

Resolve concern from final comment period #127154 (comment)

@NobodyXu
Move std::pipe::* into std::io
efe8888 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@rustbot

rustbot commented Jan 16, 2025

Copy link
Copy Markdown
Collaborator

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. O-unix Operating system: Unix-like labels Jan 16, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@joshtriplett

joshtriplett commented Jan 16, 2025

Copy link
Copy Markdown
Member

r=me once it passes CI.

@NobodyXu
Fix import of pipe in kernel_copy.rs
81d70f9 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@NobodyXu
Fix use of pipe in tests/run-make/broken-pipe-no-ice/rmake.rs
2af4197 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@rustbot rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Jan 17, 2025
@rustbot

rustbot commented Jan 17, 2025

Copy link
Copy Markdown
Collaborator

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

@NobodyXu

NobodyXu commented Jan 17, 2025

Copy link
Copy Markdown
Contributor Author

r=me

@joboet joboet mentioned this pull request Jan 17, 2025
Merged
@joshtriplett

joshtriplett commented Jan 17, 2025

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Jan 17, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 2af4197 has been approved by joshtriplett

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 17, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 18, 2025
Merged
@bors
bors merged commit 508c72b into rust-lang:master Jan 18, 2025
@rustbot rustbot added this to the 1.86.0 milestone Jan 18, 2025
riking
riking reviewed Jan 25, 2025
View reviewed changes
Comment thread library/std/src/io/tests.rs
}

#[test]
#[cfg(all(windows, unix, not(miri)))]

ghost Jan 25, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cfg is never true because it expects a platform that is both windows and unix

ghost Jan 25, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh damn thanks for spotting this

ghost Jan 26, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raised in #135635

@NobodyXu
NobodyXu deleted the move-pipe-to-io branch January 26, 2025 01:10
@NobodyXu NobodyXu mentioned this pull request Jan 26, 2025
Closed
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@riking riking riking left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@cuviper cuviper

Labels

A-run-make Area: port run-make Makefiles to rmake.rs O-unix Operating system: Unix-like S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.86.0

Development

Successfully merging this pull request may close these issues.

7 participants

@NobodyXu @rustbot @rust-log-analyzer @joshtriplett @bors @riking @cuviper