Repository navigation
add next-solver regression test for recursive opaque ICE under validate-mir - #164678
Open
Albab-Hasan wants to merge 1 commit into
Open
Albab-Hasan wants to merge 1 commit into
Albab-Hasan wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-review
Contributor
Author
|
@lcnr hello, any updates? |
adwinwhite
reviewed
Nov 4, 2026
Comment on lines
+1
to
+3
| // Regression test for https://github.com/rust-lang/rust/issues/151297. | ||
| //~^ ERROR overflow evaluating the requirement `generator_sig::{opaque#0} == _` | ||
| //@ compile-flags: -Znext-solver -Zvalidate-mir |
Contributor
There was a problem hiding this comment.
Could you put the compile-flags at the top?
And comment that this used to ICE :>
Contributor
There was a problem hiding this comment.
Oh, please also do the same for tests in your other PRs. Thanks!
Contributor
Author
There was a problem hiding this comment.
sure and thanks for the review, i really appreciate it!
adwinwhite
changed the title
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
|
@bors r- |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved. |
Contributor
This comment has been minimized.
This comment has been minimized.
…te-mir * add next-solver regression test for recursive opaque ices under validate-mir * move compile-flags to the top of the test and note that it used to ice
Contributor
|
🔨 2 commits were squashed into b66ec59. |
Contributor
rust-bors
Bot
force-pushed
the
recursive-opaque-validate-mir-test
branch
from
November 5, 2026 01:26
fa14767 to
b66ec59
Compare
rust-bors
Bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Nov 5, 2026
…ate-mir-test, r=adwinwhite add next-solver regression test for recursive opaque ICE under validate-mir fixes rust-lang#151297 r? @lcnr
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 5, 2026
Rollup of 13 pull requests Successful merges: - #163477 (Fancy paramenv accessors that communicate the access pattern better.) - #160593 (turn ABI-controlling target features into a target modifier) - #164896 (offload: pass the linked device image to the host pass) - #165468 (Remove return type from `BuilderMethods::store`) - #159374 (Lower #[no_mangle] to #[symbol_name]/#[link_name]) - #164564 (Re-enable outline-atomics by default on more AArch64 platforms) - #164623 (add next-solver regression tests for two fixed ices) - #164678 (add next-solver regression test for recursive opaque ICE under validate-mir) - #165429 (Add tests for `-Zcrate-attr` edition and position) - #165430 ([tiny] Show context for found assoc item in E0107) - #165456 (std: Fix build for the L4Re targets) - #165463 (Add BTreeMap::allocator and BTreeSet::allocator) - #165466 (Don't "exit" using `panic` on teeos)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #151297
r? @lcnr