Repository navigation
Improve diagnostics for notable-trait color arguments - #165298
Merged
Merged
Conversation
Invalid color names and duplicate arguments previously shared a generic syntax diagnostic, making the underlying mistake difficult to identify.
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project has assigned @khyperia (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Please see the contribution instructions and our LLM policy for more information. Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
r? me |
JonathanBrouwer
approved these changes
Nov 2, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Nov 2, 2026
…, r=JonathanBrouwer Improve diagnostics for notable-trait color arguments Invalid color names and duplicate arguments previously shared a generic syntax diagnostic, making the underlying mistake difficult to identify. Addresses rust-lang#164728 cc @notriddle
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Nov 2, 2026
…, r=JonathanBrouwer Improve diagnostics for notable-trait color arguments Invalid color names and duplicate arguments previously shared a generic syntax diagnostic, making the underlying mistake difficult to identify. Addresses rust-lang#164728 cc @notriddle
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 2, 2026
Rollup of 15 pull requests Successful merges: - #165271 (Re-enable most of `test-aarch64-apple-macos-26-2`) - #165331 (miri subtree update) - #165211 (Streamline function_item_references lint) - #165273 (Add some docs for our allocator `unstable_feature_bound`s) - #165279 (explicitly test the win32 symbol byte count suffix) - #162688 (Fix invalid suggestions and misleading notes for imports) - #165198 (expand the docs of `Complex<T>`) - #165231 (Remove redundant parameter from `AttributeParser::parse_attribute_list()` & `AttributeParser::parse_single_args()`) - #165248 (add {Receiver,Sender,SyncSender}::{is_empty,len}) - #165284 (Ensure the display impl of uXX is small with optimize_for_size) - #165287 (Add example of implementing Allocator to its docs) - #165297 (Cleanup `rustdoc-html` tests) - #165298 (Improve diagnostics for notable-trait color arguments) - #165336 (Refactor `analyze_attr` to use a match) - #165338 (`rust-analyzer` subtree update)
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 2, 2026
Rollup of 15 pull requests Successful merges: - #165271 (Re-enable most of `test-aarch64-apple-macos-26-2`) - #165331 (miri subtree update) - #165211 (Streamline function_item_references lint) - #165273 (Add some docs for our allocator `unstable_feature_bound`s) - #165279 (explicitly test the win32 symbol byte count suffix) - #162688 (Fix invalid suggestions and misleading notes for imports) - #165198 (expand the docs of `Complex<T>`) - #165231 (Remove redundant parameter from `AttributeParser::parse_attribute_list()` & `AttributeParser::parse_single_args()`) - #165248 (add {Receiver,Sender,SyncSender}::{is_empty,len}) - #165284 (Ensure the display impl of uXX is small with optimize_for_size) - #165287 (Add example of implementing Allocator to its docs) - #165297 (Cleanup `rustdoc-html` tests) - #165298 (Improve diagnostics for notable-trait color arguments) - #165336 (Refactor `analyze_attr` to use a match) - #165338 (`rust-analyzer` subtree update)
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 2, 2026
…uwer Rollup of 14 pull requests Successful merges: - #165271 (Re-enable most of `test-aarch64-apple-macos-26-2`) - #165211 (Streamline function_item_references lint) - #165273 (Add some docs for our allocator `unstable_feature_bound`s) - #165279 (explicitly test the win32 symbol byte count suffix) - #162688 (Fix invalid suggestions and misleading notes for imports) - #165198 (expand the docs of `Complex<T>`) - #165231 (Remove redundant parameter from `AttributeParser::parse_attribute_list()` & `AttributeParser::parse_single_args()`) - #165248 (add {Receiver,Sender,SyncSender}::{is_empty,len}) - #165284 (Ensure the display impl of uXX is small with optimize_for_size) - #165287 (Add example of implementing Allocator to its docs) - #165297 (Cleanup `rustdoc-html` tests) - #165298 (Improve diagnostics for notable-trait color arguments) - #165336 (Refactor `analyze_attr` to use a match) - #165338 (`rust-analyzer` subtree update)
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 2, 2026
Rollup merge of #165298 - pkondzior:notable-trait-color-main, r=JonathanBrouwer Improve diagnostics for notable-trait color arguments Invalid color names and duplicate arguments previously shared a generic syntax diagnostic, making the underlying mistake difficult to identify. Addresses #164728 cc @notriddle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invalid color names and duplicate arguments previously shared a generic syntax diagnostic, making the underlying mistake difficult to identify.
Addresses #164728
cc @notriddle