Skip to content

delegation: insert probing adjustments before args check adjustments - #165351

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
aerooneqq:delegation-broken-mir
Nov 4, 2026
Merged

delegation: insert probing adjustments before args check adjustments#165351
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
aerooneqq:delegation-broken-mir

Conversation

@aerooneqq

@aerooneqq aerooneqq commented Nov 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Up until now we were completely overwriting adjustments, but we need to insert probing adjustments before adjustments that are obtained from arguments check. Details are in the comment.

Fixes #165171.
Part of #118212.

r? @petrochenkov
@rustbot label +F-fn_delegation

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 2, 2026
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. F-fn_delegation `#![feature(fn_delegation)]` labels Nov 2, 2026
@aerooneqq
aerooneqq force-pushed the delegation-broken-mir branch from fbf19f0 to 760fc7b Compare November 3, 2026 09:17
@petrochenkov

petrochenkov commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

@bors r+

@rust-bors

rust-bors Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 760fc7b has been approved by petrochenkov

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 3, 2026
@JonathanBrouwer
Rollup merge of rust-lang#165351 - aerooneqq:delegation-broken-mir, r…
6a3378c 
…=petrochenkov

delegation: insert probing adjustments before args check adjustments

Up until now we were completely overwriting adjustments, but we need to insert probing adjustments before adjustments that are obtained from arguments check. Details are in the comment.

Fixes rust-lang#165171.
Part of rust-lang#118212.

r? @petrochenkov
@rustbot label +F-fn_delegation
@JonathanBrouwer JonathanBrouwer mentioned this pull request Nov 3, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Nov 3, 2026
@bors
Auto merge of #165411 - JonathanBrouwer:rollup-bwFCAjc, r=JonathanBro…
719f95b 
…uwer

Rollup of 20 pull requests

Successful merges:

 - #149245 (Make inline attributes apply to the generated `poll` in async fn)
 - #163495 (Parallelize AST -> HIR lowering)
 - #164304 ([perf] Reuse CanonicalVarKinds if no new variables were added)
 - #165109 (Avoid building a region map when erasing bound regions)
 - #163393 (std: Use getexecpath() for current_exe() on OpenBSD)
 - #163625 (Add a lint helper attribute namespace )
 - #164414 (Add `let_underscore_drop_guard` lint.)
 - #165342 (Avoid unnecessary MIR traversals in CheckPackedRef lint)
 - #165351 (delegation: insert probing adjustments before args check adjustments)
 - #165358 (Reenable some cg_gcc tests that were disabled)
 - #165377 (Make `no_implicit_prelude` not suppress tool attributes)
 - #165397 (Add codegen test for unused match arms removed after inlining)
 - #165398 (Rework parallel reproducibility tests)
 - #162608 (Avoid oscillating line wrapping due to symbol indices)
 - #164241 (make the safety documentation consistent in Ptr module)
 - #165029 (Use `MalformedLintAttributeInput` in more places)
 - #165203 (AIX: Implement TLS destructor guard in std and update dynamic-loading-cdylib test)
 - #165230 (Fix rigidity assertion ICE)
 - #165293 (unstable-book: update default-visibility.md to link to tracking issue)
 - #165374 (Refactorings in preparation for the move trait)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 3, 2026
@JonathanBrouwer
Rollup merge of rust-lang#165351 - aerooneqq:delegation-broken-mir, r…
b91cd32 
…=petrochenkov

delegation: insert probing adjustments before args check adjustments

Up until now we were completely overwriting adjustments, but we need to insert probing adjustments before adjustments that are obtained from arguments check. Details are in the comment.

Fixes rust-lang#165171.
Part of rust-lang#118212.

r? @petrochenkov
@rustbot label +F-fn_delegation
@JonathanBrouwer JonathanBrouwer mentioned this pull request Nov 3, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Nov 3, 2026
@bors
Auto merge of #165418 - JonathanBrouwer:rollup-MWzkJMq, r=JonathanBro…
089c597 
…uwer

Rollup of 21 pull requests

Successful merges:

 - #165416 (fix unsoundness when compiling `[diverging_const; 0]`)
 - #149245 (Make inline attributes apply to the generated `poll` in async fn)
 - #163495 (Parallelize AST -> HIR lowering)
 - #164304 ([perf] Reuse CanonicalVarKinds if no new variables were added)
 - #165109 (Avoid building a region map when erasing bound regions)
 - #163393 (std: Use getexecpath() for current_exe() on OpenBSD)
 - #163625 (Add a lint helper attribute namespace )
 - #164414 (Add `let_underscore_drop_guard` lint.)
 - #165342 (Avoid unnecessary MIR traversals in CheckPackedRef lint)
 - #165351 (delegation: insert probing adjustments before args check adjustments)
 - #165358 (Reenable some cg_gcc tests that were disabled)
 - #165377 (Make `no_implicit_prelude` not suppress tool attributes)
 - #165397 (Add codegen test for unused match arms removed after inlining)
 - #165398 (Rework parallel reproducibility tests)
 - #162608 (Avoid oscillating line wrapping due to symbol indices)
 - #164241 (make the safety documentation consistent in Ptr module)
 - #165029 (Use `MalformedLintAttributeInput` in more places)
 - #165203 (AIX: Implement TLS destructor guard in std and update dynamic-loading-cdylib test)
 - #165230 (Fix rigidity assertion ICE)
 - #165293 (unstable-book: update default-visibility.md to link to tracking issue)
 - #165374 (Refactorings in preparation for the move trait)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 3, 2026
@JonathanBrouwer
Rollup merge of rust-lang#165351 - aerooneqq:delegation-broken-mir, r…
cf7047b 
…=petrochenkov

delegation: insert probing adjustments before args check adjustments

Up until now we were completely overwriting adjustments, but we need to insert probing adjustments before adjustments that are obtained from arguments check. Details are in the comment.

Fixes rust-lang#165171.
Part of rust-lang#118212.

r? @petrochenkov
@rustbot label +F-fn_delegation
@JonathanBrouwer JonathanBrouwer mentioned this pull request Nov 3, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Nov 3, 2026
@bors
Auto merge of #165426 - JonathanBrouwer:rollup-Xc1GCW7, r=JonathanBro…
f3efee6 
…uwer

Rollup of 20 pull requests

Successful merges:

 - #149245 (Make inline attributes apply to the generated `poll` in async fn)
 - #163495 (Parallelize AST -> HIR lowering)
 - #164304 ([perf] Reuse CanonicalVarKinds if no new variables were added)
 - #165109 (Avoid building a region map when erasing bound regions)
 - #163393 (std: Use getexecpath() for current_exe() on OpenBSD)
 - #163625 (Add a lint helper attribute namespace )
 - #164414 (Add `let_underscore_drop_guard` lint.)
 - #165342 (Avoid unnecessary MIR traversals in CheckPackedRef lint)
 - #165351 (delegation: insert probing adjustments before args check adjustments)
 - #165358 (Reenable some cg_gcc tests that were disabled)
 - #165377 (Make `no_implicit_prelude` not suppress tool attributes)
 - #165397 (Add codegen test for unused match arms removed after inlining)
 - #165398 (Rework parallel reproducibility tests)
 - #162608 (Avoid oscillating line wrapping due to symbol indices)
 - #164241 (make the safety documentation consistent in Ptr module)
 - #165029 (Use `MalformedLintAttributeInput` in more places)
 - #165203 (AIX: Implement TLS destructor guard in std and update dynamic-loading-cdylib test)
 - #165230 (Fix rigidity assertion ICE)
 - #165293 (unstable-book: update default-visibility.md to link to tracking issue)
 - #165374 (Refactorings in preparation for the move trait)
@JonathanBrouwer JonathanBrouwer mentioned this pull request Nov 3, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Nov 3, 2026
@bors
Auto merge of #165436 - JonathanBrouwer:rollup-sNiqmOA, r=JonathanBro…
249cb16 
…uwer

Rollup of 22 pull requests

Successful merges:

 - #149245 (Make inline attributes apply to the generated `poll` in async fn)
 - #164304 ([perf] Reuse CanonicalVarKinds if no new variables were added)
 - #165109 (Avoid building a region map when erasing bound regions)
 - #163393 (std: Use getexecpath() for current_exe() on OpenBSD)
 - #163625 (Add a lint helper attribute namespace )
 - #164414 (Add `let_underscore_drop_guard` lint.)
 - #165342 (Avoid unnecessary MIR traversals in CheckPackedRef lint)
 - #165351 (delegation: insert probing adjustments before args check adjustments)
 - #165358 (Reenable some cg_gcc tests that were disabled)
 - #165377 (Make `no_implicit_prelude` not suppress tool attributes)
 - #165397 (Add codegen test for unused match arms removed after inlining)
 - #165398 (Rework parallel reproducibility tests)
 - #162232 (Replace `builtin #` with `k#`)
 - #162608 (Avoid oscillating line wrapping due to symbol indices)
 - #164241 (make the safety documentation consistent in Ptr module)
 - #164258 (clarify when `Vec::into_boxed_slice()` is in-place)
 - #165029 (Use `MalformedLintAttributeInput` in more places)
 - #165203 (AIX: Implement TLS destructor guard in std and update dynamic-loading-cdylib test)
 - #165230 (Fix rigidity assertion ICE)
 - #165293 (unstable-book: update default-visibility.md to link to tracking issue)
 - #165374 (Refactorings in preparation for the move trait)
 - #165421 (another Enzyme submodule update for nested autodiff)
@rust-bors
rust-bors Bot merged commit 98893b6 into rust-lang:main Nov 4, 2026
14 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Nov 4, 2026
rust-bors Bot pushed a commit that referenced this pull request Nov 4, 2026
@bors
Unrolled build for #165351 in rollup 165436
a9bb8aa 
Rollup merge of #165351 - aerooneqq:delegation-broken-mir, r=petrochenkov

delegation: insert probing adjustments before args check adjustments

Up until now we were completely overwriting adjustments, but we need to insert probing adjustments before adjustments that are obtained from arguments check. Details are in the comment.

Fixes #165171.
Part of #118212.

r? @petrochenkov
@rustbot label +F-fn_delegation
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Nov 4, 2026
@bors
Auto merge of #165436 - JonathanBrouwer:rollup-sNiqmOA, r=JonathanBro…
06e3752 
…uwer

Rollup of 22 pull requests

Successful merges:

 - rust-lang/rust#149245 (Make inline attributes apply to the generated `poll` in async fn)
 - rust-lang/rust#164304 ([perf] Reuse CanonicalVarKinds if no new variables were added)
 - rust-lang/rust#165109 (Avoid building a region map when erasing bound regions)
 - rust-lang/rust#163393 (std: Use getexecpath() for current_exe() on OpenBSD)
 - rust-lang/rust#163625 (Add a lint helper attribute namespace )
 - rust-lang/rust#164414 (Add `let_underscore_drop_guard` lint.)
 - rust-lang/rust#165342 (Avoid unnecessary MIR traversals in CheckPackedRef lint)
 - rust-lang/rust#165351 (delegation: insert probing adjustments before args check adjustments)
 - rust-lang/rust#165358 (Reenable some cg_gcc tests that were disabled)
 - rust-lang/rust#165377 (Make `no_implicit_prelude` not suppress tool attributes)
 - rust-lang/rust#165397 (Add codegen test for unused match arms removed after inlining)
 - rust-lang/rust#165398 (Rework parallel reproducibility tests)
 - rust-lang/rust#162232 (Replace `builtin #` with `k#`)
 - rust-lang/rust#162608 (Avoid oscillating line wrapping due to symbol indices)
 - rust-lang/rust#164241 (make the safety documentation consistent in Ptr module)
 - rust-lang/rust#164258 (clarify when `Vec::into_boxed_slice()` is in-place)
 - rust-lang/rust#165029 (Use `MalformedLintAttributeInput` in more places)
 - rust-lang/rust#165203 (AIX: Implement TLS destructor guard in std and update dynamic-loading-cdylib test)
 - rust-lang/rust#165230 (Fix rigidity assertion ICE)
 - rust-lang/rust#165293 (unstable-book: update default-visibility.md to link to tracking issue)
 - rust-lang/rust#165374 (Refactorings in preparation for the move trait)
 - rust-lang/rust#165421 (another Enzyme submodule update for nested autodiff)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkov petrochenkov

Labels

F-fn_delegation `#![feature(fn_delegation)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.101.0

Development

Successfully merging this pull request may close these issues.

[ICE]: broken MIR in ...: bad arg ...: NoSolution with fn_delegation and trait object

3 participants

@aerooneqq @petrochenkov @rustbot