Repository navigation
Rollup of 8 pull requests - #165510
Merged
Merged
Rollup of 8 pull requests#165510
Conversation
With LLVM 24 or later, `x86_64-unknown-uefi` and `aarch64-unknown-uefi` use LLVM's `*-unknown-uefi` targets instead of the Windows ones. Older LLVMs keep the Windows triple as before for these targets.
This can't unwrap, e.g. `no_core` you're not guaranteed to have that lang item.
The previous fix would still let `[...; _]` be unsound :c
…-bootstrap, r=folkertdev c-variadic: remove stale `cfg(bootstrap)` comment This can't unwrap, e.g. under `no_core` you're not guaranteed to have that lang item. Noticed when grepping for `cfg(bootstrap)` when reviewing an unrelated PR. r? @folkertdev (or compiler)
Lower UEFI targets through LLVM's *uefi triple LLM Disclosure: LLM was used to generate tests and version specific gating logic. LLM was used to run tests, perform formatting as well as test the change with downstream project code base. With LLVM 24 or later, `x86_64-unknown-uefi` and `aarch64-unknown-uefi` use LLVM's `*-unknown-uefi` targets instead of the Windows ones. Older LLVMs keep the Windows triple as before for these targets.
fix unsoundness when compiling `[diverging_const; _]` Follow up to rust-lang#165416, because I [missed a case](rust-lang#165416 (comment)). r? @BoxyUwU
…seZ4 Build TPDE with local Clang when available As noted in rust-lang#164108 (review), TPDE requires a clang with a major version <= the LLVM major version, and performance tends to be better when built with clang. This PR makes TPDE compilation and encodegen use the locally built clang if it's available. I haven't added any sort of warning if `llvm.clang` is _not_ set as TPDE will throw its own error if the major version is too high. Maybe it's worth doing so, though? This also includes the TPDE compilation fix commit from rust-lang#164108. We will see which ones makes it in first. r? @ZuseZ4
Use `emit_ptr_va_arg` for `va_arg` on MSP430 This avoids needing to use the LLVM `va_arg` instruction. The implementation matches LLVM and GCC (checked by comparing the assembly), with the exception that GCC doesn't seem to align the `va_list` pointer before a `va_arg(va, void*)` - AFAICT this is a GCC bug as GCC does align pointers when passing them to C-variadic functions. This PR always correctly aligns the pointer, matching LLVM and the spec. cc @cr1901 r? @folkertdev
…ition, r=jieyouxu compiletest: Fix the edition of minicore to the latest stable one ...instead of using whatever edition the dependent / the reverse dependency is using (!). Context: rust-lang#165479 (comment). Unblocks PR rust-lang#165487. r? @jieyouxu (no rush) <sub>(No LLM was or will be used by me during the entire creation process of this PR)</sub>
LoongArch: Fix direct-access-external-data test Fixes rust-lang#165371 r? @folkertdev
rustdoc: Don't add a border on an empty `:target` element Fixes rust-lang#163345. If the `:target` is empty, no border is added. So in rust-lang#163345 case, it will simply scroll without a visual effect.
rustbot
added
A-compiletest
rustbot
added
the
T-rustdoc-frontend
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 5, 2026
Rollup of 8 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu try-job: test-x86_64-gnu-llvm-22-3 try-job: test-aarch64-msvc-2
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
merged-by-bors
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 712e1d3 (parent) -> 249c1e4 (this PR) Test differencesShow 41 test diffsStage 1
Stage 2
Additionally, 8 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 249c1e4e31111b54ad2483cfd4cea06c7020c653 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Contributor
Collaborator
|
Finished benchmarking commit (249c1e4): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary -0.4%, secondary 0.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 499.109s -> 481.055s (-3.62%) |
Contributor
|
📌 Perf builds for each rolled up PR:
parent commit: 712e1d350f In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
cfg(bootstrap)comment #165496 (c-variadic: remove stalecfg(bootstrap)comment)[diverging_const; _]#165497 (fix unsoundness when compiling[diverging_const; _])emit_ptr_va_argforva_argon MSP430 #165467 (Useemit_ptr_va_argforva_argon MSP430):targetelement #165501 (rustdoc: Don't add a border on an empty:targetelement)r? @ghost
Create a similar rollup