Repository navigation
Conversation
Contributor
|
This is fine (I don't have time to fully review and pull just now), but at some point it'll have to be smarter than just duplicate patterns, and also detect stuff like this: Also, I'll make a note to fix the trans_alt FIXME this week. It shoiuldn't even be hard, I just forgot about it when I pushed that change. |
Contributor
|
jdm: I think marijnh has fixed that issue with translating unreachable branches. Can you add a test case? |
Contributor
|
I just pushed beab6ba , which does this in a more robust way (as described in my previous comment on this pull req). |
keeperofdakeys
pushed a commit
to keeperofdakeys/rust
that referenced
this pull request
Dec 12, 2017
Add IPV6_JOIN_GROUP and IPV6_LEAVE_GROUP to uclibc Hello! Just some minor fixes so that net2 compiles correctly on uclibc
pdietl
pushed a commit
to pdietl/rust
that referenced
this pull request
Apr 23, 2020
github action doesn't use the nursery
celinval
added a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
The goal is to eventually consume rustc as is (issue rust-lang#42). In this change, we moved the json file generations out of the linker to the codegen method. The RMC behavior is still the same.
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Jun 3, 2025
Allow implicit function decl on A64
GuillaumeGomez
pushed a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jun 18, 2025
Use `tempfile::TempDir::keep()` instead of deprecated `into_path()`
U007D
pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
718: split HirDatabase r=matklad a=csmoe Closes rust-lang#706 Co-authored-by: csmoe <csmoe@msn.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Being able to write something like
alt (value) {
_ { log "wheee!" }
_ { fail }
}
is silly. This branch doesn't have any tests included at the moment, however, because any non-trivial case butts up against the FIXME in trans_alt.rs that causes an error if any alt statement contains unreachable branches.