Repository navigation
cgen: complete Windows CRT stream declarations - #27948
Merged
medvednikov merged 1 commit intoJul 27, 2026
Merged
Conversation
Contributor
Author
|
Ready Alex Thanks! PS: The Windows TCC job now gets much further. It still fails on missing strict declarations for |
GGRei
force-pushed
the
fix/windows-tcc-wfreopen-preamble
branch
from
July 27, 2026 07:38
0127024 to
e0b816e
Compare
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Complete the manual Windows CRT prelude with the missing declarations for
_wfreopen,_fseeki64,fgetpos,_wpopen, and_pclose.Add Windows TinyCC runtime regressions covering:
os.File.reopen_wpopen/_pclosecommand-pipe lifecycleembed_issue_12035full generated-C pathAdditional note
Strict Windows TCC validation also exposed a missing
freopen_sdeclaration in the generated C prelude. This PR now includes the correct declaration and a regression test covering Windows GUI builds with-subsystem windows.The existing declarations and behavior remain unchanged. The complete targeted Windows TCC smoke passed.
Cause
V's generated C uses a manual CRT prelude. Some Windows CRT functions used by the compiled modules were not visible to TinyCC through that prelude, causing implicit-function-declaration failures with
-no-retry-compilation.The symbols already exist in the Windows CRT and tccbin exports. This was a generated-C declaration visibility issue, not a pkg-config or linker-library issue.
Validation
Native Windows TinyCC smoke passed with no fallback:
File.reopencompile, link, and runtime_wpopen/_pcloseruntimeembed_issue_12035 -prod -no-skip-unusedcoutput_test.v