Dependency cleanup/syntax modernisation

[43081j]

Fairly low priority I imagine, but there are various dependency clean ups and code modernisations we can do in this repo.

I already opened a couple of PRs but want a tracking issue to add some context/discussion.

Here are my suggestions:

Dependencies

Dependency	Used by	Replace with	Notes
chalk	wrangler, create-cloudflare, cli	styleText (native) or picocolors	miniflare uses kleur, so could make sense to settle on that or move miniflare to also use styleText/picocolors
execa	wrangler, create-cloudflare	tinyexec	#12369
strip-ansi	wrangler, vite-plugin-cloudflare	stripVTControlCharacters (native)	#11853
find-up	tools, workers-utils, wrangler	empathic	#12601
glob	tools, pages-shared, create-cloudflare	tinyglobby	vite-plugin-cloudflare already uses tinyglobby
rimraf	workflows-shared, miniflare, wrangler, pages-shared, workers-shared	premove	#11913
@typescript-eslint/eslint-plugin	various	Remove	#11906

These replacements are what the e18e community recommend (see here). The modules being replaced are generally much larger, slower, and/or outdated.

I can explain each one if needed, just let me know 👍

Syntax (modernisation/perf)

FYI I used the e18e ESLint plugin to find a bunch of these (in case you want a way to reproduce the findings etc).

Old syntax	New syntax	Notes
arr[arr.length - 1]	arr.at(-1)
[...arr].map(mapper)	Array.from(arr, mapper)	Avoids an intermediate array being allocated
str.match(regex)	regex.test(str)	In conditional logic, to avoid an unused match array

For these, we could run eslint --fix with the e18e plugin enabled to auto-fix them. There's various occurrences but not a huge amount so it'd be easily reviewable.

---

Let me know if there's any interest in any of these. I and others would be happy to contribute the changes if you give the go-ahead.

[dario-piotrowicz]

Hi @43081j thanks a lot for the issue 🙂🙏

I think that the syntax suggestions are all quite sensible and non at all controversial (although I would suspect that arr.at(-1) would get probably transpiled away during build 🤔), for those I would say that you are more then welcome to go ahead and summit a PR with the changes. Possibly the simplest thing to do would just be to add the e18e plugin to the monorepo's base config and apply all of those automatically. I can't imagine much pushback on having the e18e plugin set up in the monorepo 🙂

Regarding the dependencies, the proposed changes all seem quite valid to me and I don't expect there to be much pushback if the package is well maintained and the performance benefit is either clearly documented or benchmarked/apparent in the results. I would suggest going with the less potentially controversial one, see how it goes and progress following potential controvesionality 🙂 (that's not a word is it? 😅), but it seems to me like you already started with such approach anyways! 😄

[dario-piotrowicz]

I'll also surface this to the whole team so that everyone is aware and can add any comment here if they have any 🙂

[43081j]

awesome thanks for the quick response 🙏

i can try explain some of the dependency replacements:

• chalk
  • ~44KB vs picocolors 6KB
  • picocolors is widely adopted already
  • if you need RGB colours, ansis is a good alternative instead of picocolors
  • one day we should just use node's built-in styleText but iirc it only became stable in 21.x
• execa
  • ~640KB, 22 dependencies vs tinyexec 26KB, 0 dependencies
  • tinyexec is adopted by most modern tools already
• strip-ansi
  • it is built into node since 16.x, this one seems the easiest to do first
• find-up
  • ~62KB, 5 dependencies vs empathic 21KB, 0 dependencies
  • empathic is faster, but "find upwards" functionality isn't often hot-path code so users are unlikely to notice either way
  • empathic replaces many "find upwards" packages in wider dependency trees, so should de-dupe better in the bigger picture (e.g. it replaces find-up, find-package, find-package-json, etc.)
• glob
  • 2.6MB vs tinyglobby 179KB
  • tinyglobby is faster, too
  • most modern tools have adopted tinyglobby already
• rimraf
  • ~2.9MB vs premove 9.7KB
  • dev only dependency, so this is another easy one to do
  • premove doesn't have glob support, but afaik this repo doesn't pass globs to rimraf anyway

The sizes are all install size (including all their dependencies).