Skip to content

CC-7056: Add credentials subcommand to containers registries#12693

Merged
martinezjandrew merged 16 commits intomainfrom
CC-7056
Mar 3, 2026
Merged

CC-7056: Add credentials subcommand to containers registries#12693
martinezjandrew merged 16 commits intomainfrom
CC-7056

Conversation

@martinezjandrew
Copy link
Contributor

@martinezjandrew martinezjandrew commented Feb 26, 2026

Fixes #CC-7056.

Add containers registries credentials command, from cloudchamber registries credentials, for generating temporary push/pull credentials. Only works with the Cloudflare managed registry (registry.cloudflare.com).

image
Open with Devin

@martinezjandrew martinezjandrew requested review from a team as code owners February 26, 2026 22:53
@changeset-bot
Copy link

changeset-bot bot commented Feb 26, 2026

🦋 Changeset detected

Latest commit: 83f1b8a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Feb 26, 2026
@martinezjandrew martinezjandrew changed the title Cc 7056 CC-7056: Add credentials subcommand to containers registries Feb 26, 2026
@claude
Copy link
Contributor

claude bot commented Feb 26, 2026

Claude finished @martinezjandrew's task —— View job


Changeset Review

Reviewing the changeset file...

Tasks:

  • Read changeset guidelines
  • Review the changeset file
  • Validate against criteria
  • Check attached image
  • Provide feedback

⚠️ Issues found

The changeset .changeset/tricky-frogs-fry.md has room for improvement:

Current changeset:

---
"wrangler": minor
---

Add containers registries credentials command for generating temporary push/pull credentials. Only works with the Cloudflare managed registry (registry.cloudflare.com).

Issue: The changeset description is minimal and lacks a usage example or additional context that would help users understand how to use this new command.

Recommendation: While the version type (minor) is correct for a new command, the description should ideally include:

  • A brief example of how to use the new command
  • More context about what the command does (e.g., what format the credentials are in, how long they last, etc.)

Suggested improvement:

---
"wrangler": minor
---

Add `wrangler containers registries credentials` command for generating temporary push/pull credentials

You can now generate temporary credentials for pushing and pulling container images to the Cloudflare managed registry:

```bash
wrangler containers registries credentials

This command only works with the Cloudflare managed registry (registry.cloudflare.com).


Note: This is a suggestion for improvement. The current changeset meets the minimum requirements, but following the guidelines in `.changeset/README.md`, feature changesets benefit from usage examples.

---

**Bonus Cuteness Report:**

This is Featherbee. He's magnificently fluffy with antennae that look like they're ready to receive satellite signals. Absolutely glowing with golden fuzziness and has no concept of how extra those feathers are. 14/10 would admire from a respectful distance.

---

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 26, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12693

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12693

miniflare

npm i https://pkg.pr.new/miniflare@12693

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12693

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12693

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12693

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12693

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12693

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12693

wrangler

npm i https://pkg.pr.new/wrangler@12693

commit: f77b6de

gpanders
gpanders previously approved these changes Feb 27, 2026
@emily-shen
Copy link
Contributor

loving the bug pics

nikitassharma
nikitassharma previously approved these changes Feb 27, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2026

✅ All changesets look good

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 7 additional findings in Devin Review.

Open in Devin Review

Copy link
Contributor

@emily-shen emily-shen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved pending the validation fix

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 2, 2026
@workers-devprod workers-devprod dismissed stale reviews from nikitassharma and gpanders March 2, 2026 18:01

Changes in owned files since last approval

@workers-devprod
Copy link
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/cloudchamber
  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@martinezjandrew martinezjandrew merged commit 150ef7b into main Mar 3, 2026
40 of 42 checks passed
@martinezjandrew martinezjandrew deleted the CC-7056 branch March 3, 2026 00:06
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants