Skip to content

Add type generation support for experimental secrets property#12695

Merged
jamesopstad merged 5 commits intomainfrom
james/secrets-property-types
Mar 2, 2026
Merged

Add type generation support for experimental secrets property#12695
jamesopstad merged 5 commits intomainfrom
james/secrets-property-types

Conversation

@jamesopstad
Copy link
Contributor

@jamesopstad jamesopstad commented Feb 27, 2026

Add type generation support for experimental secrets property


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: experimental feature

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@changeset-bot
Copy link

changeset-bot bot commented Feb 27, 2026

🦋 Changeset detected

Latest commit: 376ad55

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@claude
Copy link
Contributor

claude bot commented Feb 27, 2026

Claude encountered an error —— View job


Changeset Review Image

Tasks

  • Read changeset guidelines (.changeset/README.md)
  • Read the changeset file (.changeset/sharp-sheep-buy.md)
  • Validate changeset against criteria
  • Check for cute animal images
  • Post review results

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 27, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12695

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12695

miniflare

npm i https://pkg.pr.new/miniflare@12695

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12695

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12695

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12695

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12695

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12695

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12695

wrangler

npm i https://pkg.pr.new/wrangler@12695

commit: f47195e

@jamesopstad jamesopstad force-pushed the james/secrets-property-types branch from ec7b7d4 to 7db3b68 Compare February 27, 2026 10:10
@jamesopstad jamesopstad marked this pull request as ready for review February 27, 2026 10:18
@jamesopstad jamesopstad requested a review from a team as a code owner February 27, 2026 10:18
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Feb 27, 2026
@jamesopstad jamesopstad force-pushed the james/secrets-property-types branch from c83e0a1 to fd2e46f Compare February 27, 2026 11:14
@jamesopstad jamesopstad force-pushed the james/secrets-property-types branch 2 times, most recently from 7727a4e to 0087209 Compare March 2, 2026 08:10
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

⚠️ Issues found

File: .changeset/sharp-sheep-buy.md

Issue: Missing opt-in instructions for experimental feature

The changeset describes support for an experimental secrets property, but per the guidelines in .changeset/README.md:

When adding or changing experimental features, call this out explicitly in the changeset description.

The description does not explain how users can opt in to (or enable) the experimental secrets property. The changeset should include information on how to use this experimental feature — e.g., what to add to wrangler.json, what flag to pass, or any other mechanism required to enable it.

Suggested fix: Expand the body to include an opt-in example, such as the relevant wrangler.json configuration snippet that enables the experimental secrets property and triggers type generation for it.

@jamesopstad jamesopstad force-pushed the james/secrets-property-types branch from 0087209 to 376ad55 Compare March 2, 2026 11:31
@jamesopstad jamesopstad merged commit 0769056 into main Mar 2, 2026
38 of 39 checks passed
@jamesopstad jamesopstad deleted the james/secrets-property-types branch March 2, 2026 12:42
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants