Skip to content

add ptlslog as an alternative to USDT probes#406

Merged
kazuho merged 68 commits intomasterfrom
gfx/ptlslog
Oct 18, 2022
Merged

add ptlslog as an alternative to USDT probes#406
kazuho merged 68 commits intomasterfrom
gfx/ptlslog

Conversation

@gfx
Copy link
Member

@gfx gfx commented Jul 21, 2022 •
edited
Loading

This is a new logging system that covers most of the USDT probes, intended to be used in h2olog v2 (h2o/h2o#3081).

ref. h2o/h2o#3059

@gfx gfx marked this pull request as draft July 21, 2022 05:44
kazuho
kazuho reviewed Jul 21, 2022
View reviewed changes
gfx added a commit that referenced this pull request Jul 21, 2022
@gfx
revert the switch to writev(2)
186f162 
discussion: #406 (comment)
gfx added a commit that referenced this pull request Jul 21, 2022
@gfx
revert the switch to writev(2)
246c89d 
discussion: #406 (comment)
@gfx gfx mentioned this pull request Jul 26, 2022
Merged
3 tasks
@gfx gfx mentioned this pull request Aug 4, 2022
Merged
kazuho and others added 23 commits August 17, 2022 08:21
@kazuho @gfx
concept
fa5bb26
@gfx
add ptlslog_set_fd(int) to set the fd
304153b 
the cli support -j=file and PTLSLOG=file to use ptlslog_set_fd()
@gfx
revert the switch to writev(2)
4014fcd 
discussion: #406 (comment)
@gfx
let PTLSLOG_CONN respect ptls_skip_tracing()
6ca4fd4
@gfx
ptlslog: add "module" field to provide who emits the event
8160318
@gfx
do not emit secret in PTLSLOG
f356e11
@gfx
add PTLS_HEXDUMP macro as an easy-to-use handle for ptls_hexdump()
6d7476d
@gfx
introduce PTLSLOG_ELEMENT_UNSAFESTR()
5826aa9
@gfx
ptlslog: put JSON's null if a string value is NULL
bf7a716
@gfx
Revert "ptlslog: put JSON's null if a string value is NULL"
e781702 
This reverts commit a163989.
@gfx
inline function must be declared as static
a051434
@gfx
do not use PTLS_HEXDUMP; it is not available for VC++
e810f3c
@gfx
avoid errors in VC++
18650cd
@gfx
disable wrarnings in VC++ for write(2)
10693bd
@gfx
VC++ does not support VLAs
b3416c7
@gfx
invalidate ptlslog_fd when write(2) fails
782adc4
@gfx
fix unsafe string handling in ptlslog
be33912
@gfx
remove debugging code
dea2af7
@gfx
add PTLSLOG_ELEMENT_HEXDUMP instead of PTLS_ELEMENT that depends on a…
8b01b9d 
… GCC extesions
@gfx
allow ptlslog to set multiple fds (up to 8)
ee1c221
@gfx
remove a redundant ptlslog interface fromn cli.c
6495459
@gfx
reorder options
7aa293a
@gfx
close fd before invalidating it
e9ade6f
@gfx gfx marked this pull request as ready for review October 5, 2022 07:17
kazuho and others added 26 commits October 6, 2022 15:52
@kazuho
merge ptlslog.h into picotls.h (like those in pembase64.c), determine…
e6a0128 
… availability rather than let it be configurable (like `PTLS_OPENSSL_HAVE_*`)
@kazuho
[xcode] add log.c
75c2504
@kazuho
do not expose the internals
8bff1e9
@kazuho
symbols use ptls_ as prefix
5cd619d
@kazuho
picotls checks allocation failure; returns PTLS_ERROR_*
0a2842c
@kazuho
partial write is loss
7468f6a
@kazuho
rename before refactor
aacb77b
@kazuho
realloc(0) may return non-NULL, fd_index should not be incremented wh…
c36dfc9 
…en removing fd
@kazuho
let's use constant expressions
542a4c9
@kazuho
rather than exposing an internal API used for building strings, promo…
51cb0d6 
…te JSON escape function to a public API
@kazuho
revert changes to wincompat.h as they should be unnecessary now that …
3a50ffe 
…logging is disabled on windows
@kazuho
this is also unnecessary
d504252
@kazuho
eaisest way to maintain compatibility is to not have new files; log.c…
620f977 
… is small anyways
@kazuho
no need to define as a block (the macro cannot be used as an ordinary…
31fff30 
… statement anyways)
@kazuho
concede to using snprintf to support compilers that complain withou…
2320382 
…t having the wisdom to check the correctness
@kazuho
[github actions] increase timeout
d56da72
@kazuho
Merge branch 'master' into gfx/ptlslog
396fa27
@kazuho
Merge branch 'gfx/ptlslog' into kazuho/ptlslog2
b52e4f2
@kazuho
use the result returned rather than recalculate
29bfc4e
@kazuho
better use PTLS_LOG assuming that we'd have QUICLY_LOG and `H2O_L…
624053f 
…OG` rather than `QUICLYLOG`, `H2OLOG`
@kazuho
oops
aa08aa5
@kazuho
provide separate knob for including / excluding sensitive data
8c633b7
@gfx
Merge pull request #425 from h2o/kazuho/ptlslog2
835d119 
tweaks to ptlslog (#406)
@gfx
revert unecessary change around alloca()
56497bc
@gfx
s/ptlslog_/ptls_log_/ for (semi-)public functions
d059ccb
@kazuho @gfx
check ptls_log.is_active first, but only once
cea1531
@kazuho kazuho merged commit 08590c8 into master Oct 18, 2022
@kazuho kazuho mentioned this pull request Dec 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kazuho kazuho kazuho left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gfx @kazuho