Skip to content

Fix incorrect message shuffling salt in PHP 5.6#176

Merged
danielbachhuber merged 2 commits intowp-cli:mainfrom
ernilambar:175-warning-duplicate
Mar 1, 2024
Merged

Fix incorrect message shuffling salt in PHP 5.6#176
danielbachhuber merged 2 commits intowp-cli:mainfrom
ernilambar:175-warning-duplicate

Conversation

@ernilambar
Copy link
Member

@ernilambar ernilambar commented Feb 20, 2024

Fixes #175

Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you include a new test or adjust an existing test for this scenario?

@ernilambar ernilambar marked this pull request as ready for review February 21, 2024 07:49
@ernilambar ernilambar requested a review from a team as a code owner February 21, 2024 07:49
@ernilambar
Copy link
Member Author

@danielbachhuber PR has been updated.

@danielbachhuber danielbachhuber changed the title Fix duplicate warning Fix incorrect message shuffling salt in PHP 5.6 Mar 1, 2024
@danielbachhuber danielbachhuber added bug command:config Related to 'config' command command:config-shuffle-salts Related to 'config shuffle-salts' command labels Mar 1, 2024
@danielbachhuber danielbachhuber added this to the 2.3.4 milestone Mar 1, 2024
@danielbachhuber danielbachhuber merged commit 445dfd0 into wp-cli:main Mar 1, 2024
@ernilambar ernilambar deleted the 175-warning-duplicate branch March 17, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug command:config Related to 'config' command command:config-shuffle-salts Related to 'config shuffle-salts' command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect message shuffling salt in PHP 5.6

2 participants