Skip to content

Improve warning message for unavailable language pack#139

Merged
swissspidy merged 2 commits intowp-cli:mainfrom
ernilambar:138-plugin-language
Feb 19, 2024
Merged

Improve warning message for unavailable language pack#139
swissspidy merged 2 commits intowp-cli:mainfrom
ernilambar:138-plugin-language

Conversation

@ernilambar
Copy link
Member

Fixes #138

  • For core, message is kept same.
  • For plugin and theme, warning message is changed as below:

Before:

Warning: Language 'invalid_lang' not available.

After:

Warning: Language 'invalid_lang' for 'hello-dolly' not available.

@ernilambar ernilambar requested a review from a team as a code owner February 19, 2024 07:43
@ernilambar ernilambar changed the title 138 plugin language Improve warning message for unavailable language pack Feb 19, 2024
@swissspidy swissspidy added this to the 2.0.20 milestone Feb 19, 2024
@swissspidy swissspidy added the command:language-plugin-install Related to 'language plugin install' command label Feb 19, 2024
@swissspidy
Copy link
Member

What about themes?

@ernilambar
Copy link
Member Author

What about themes?

This is updated in CommandWithTranslation. So it applies for theme also.

Warning: Language 'invalid_lang' for 'twentyten' not available.

@swissspidy
Copy link
Member

Ah right, it's in there, I even looked at the updated test 🤦

@swissspidy swissspidy added the command:language-theme-install Related to 'language theme install' command label Feb 19, 2024
@swissspidy swissspidy merged commit 5bd3067 into wp-cli:main Feb 19, 2024
@ernilambar ernilambar deleted the 138-plugin-language branch February 19, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:language-plugin-install Related to 'language plugin install' command command:language-theme-install Related to 'language theme install' command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Could not install language pack for plugin

2 participants