Remove extraneous error check#191
Merged
danielbachhuber merged 1 commit intowp-cli:mainfrom Feb 22, 2024
ernilambar:190-fix-error-check
Merged
Remove extraneous error check#191danielbachhuber merged 1 commit intowp-cli:mainfrom ernilambar:190-fix-error-check
danielbachhuber merged 1 commit intowp-cli:mainfrom
ernilambar:190-fix-error-check
Conversation
danielbachhuber
approved these changes
Feb 22, 2024
Member
danielbachhuber
left a comment
danielbachhuber
left a comment
There was a problem hiding this comment.
Sounds good, thanks @ernilambar !
danielbachhuber
added
the
command:media-regenerate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #190
I think we don't need to add another test for this PR. After adding separate test for this change I realized there is already similar test for the case when media could not be regenerated. So I reverted the tests addition. See: https://github.com/wp-cli/media-command/blob/main/features/media-regenerate.feature#L309