Improve Warning Message in wp rewrite flush#69
Merged
swissspidy merged 1 commit intowp-cli:mainfrom Mar 22, 2025
Merged
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
swissspidy
approved these changes
Mar 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #70
Summary
This PR updates the warning message displayed when running
wp rewrite flushto provide clearer context on why rewrite rules may be missing. The revised messages explicitly mention WP-CLI's role in loading themes and reference the --skip-themes flag when applicable.Changes Made
Updated the warning message from:
"Warning: Some rewrite rules may be missing because themes weren't loaded."
to:
"Warning: Some rewrite rules may be missing because themes weren't loaded by WP-CLI."