Skip to content

test_gdb's test_pycfunction should test all calling conventions #81271

Closed

Description

@encukou
BPO 37090
Nosy @encukou
PRs
  • bpo-37090: Expand test_gdb.test_pycfunction #13668
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/encukou'
    closed_at = <Date 2019-09-12.14:38:12.021>
    created_at = <Date 2019-05-29.21:38:35.584>
    labels = ['3.8']
    title = "test_gdb's test_pycfunction should test all calling conventions"
    updated_at = <Date 2019-09-12.14:38:12.020>
    user = 'https://github.com/encukou'

    bugs.python.org fields:

    activity = <Date 2019-09-12.14:38:12.020>
    actor = 'petr.viktorin'
    assignee = 'petr.viktorin'
    closed = True
    closed_date = <Date 2019-09-12.14:38:12.021>
    closer = 'petr.viktorin'
    components = []
    creation = <Date 2019-05-29.21:38:35.584>
    creator = 'petr.viktorin'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 37090
    keywords = ['patch']
    message_count = 2.0
    messages = ['343927', '352181']
    nosy_count = 1.0
    nosy_names = ['petr.viktorin']
    pr_nums = ['13668']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue37090'
    versions = ['Python 3.8']

    Activity

    1. encukou commented on May 29, 2019

      @encukou
      MemberAuthor

      test_gdb.StackNavigationTests.test_pycfunction checks that the GDB integration can pick up calls to C-API functions. Currently it includes the comment:

      Tested function must not be defined with METH_NOARGS or METH_O,
      otherwise call_function() doesn't call PyCFunction_Call()

      This is (now?) false; furthermore it looks like all builtin_function_or_method are discoverable.

      As the code paths for various METH_* conventions are diverging due to optimizations, we should check they continue to be covered.

    2. self-assigned this
      on May 29, 2019
    3. encukou commented on Sep 12, 2019

      @encukou
      MemberAuthor
    4. transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions