Escape all paths in DownloadLibDatadog#7583
Merged
Conversation
github-actions
bot
added
the
area:builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
This wraps all paths in
DownloadLibDatadogso that we don't run into issues of spaces in the paths.Reason for change
Fails to build if you are running the build script from a directory that has a space in it.
Implementation details
Extracted some of the paths and then quoted them all.
Test coverage
Ran locally in a directory ->
C:/Delete Me/dd-trace-dotnet/and it failed.With this it passed.
Other details