Skip to content

[Dynamic Instrumentation] Ensure DI metric probe does not send automatic telemetry#7621

Merged
dudikeleti merged 1 commit intomasterfrom
dudik/disable-telemtry-metric-probe
Oct 9, 2025
Merged

[Dynamic Instrumentation] Ensure DI metric probe does not send automatic telemetry#7621
dudikeleti merged 1 commit intomasterfrom
dudik/disable-telemtry-metric-probe

Conversation

@dudikeleti
Copy link
Contributor

@dudikeleti dudikeleti commented Oct 6, 2025 •
edited
Loading

Summary of changes

Ensure that we do not send automatic telemetry with the DogStatsd metric probe.

Reason for change

Since version 2.38.0, DogStatsd is created without telemetry, which is also beneficial for DI. (PR)
This PR ensures that the behavior from versions prior to 2.38.0 will not return in the future if the DogStatsd creation logic changes.

@dudikeleti dudikeleti requested review from a team as code owners October 6, 2025 13:30
@github-actions github-actions bot added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) area:debugger labels Oct 6, 2025
@datadog-datadog-prod-us1

This comment has been minimized.

Sign in to view
@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Oct 6, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7621) - mean (72ms)  : 71, 73
     .   : milestone, 72,
    master - mean (72ms)  : 71, 73
     .   : milestone, 72,

    section Baseline
    This PR (7621) - mean (68ms)  : 66, 71
     .   : milestone, 68,
    master - mean (68ms)  : 65, 71
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7621) - mean (1,050ms)  : 996, 1104
     .   : milestone, 1050,
    master - mean (1,051ms)  : 994, 1107
     .   : milestone, 1051,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7621) - mean (106ms)  : 105, 107
     .   : milestone, 106,
    master - mean (106ms)  : 105, 107
     .   : milestone, 106,

    section Baseline
    This PR (7621) - mean (105ms)  : 102, 109
     .   : milestone, 105,
    master - mean (105ms)  : 103, 107
     .   : milestone, 105,

    section CallTarget+Inlining+NGEN
    This PR (7621) - mean (744ms)  : 725, 763
     .   : milestone, 744,
    master - mean (743ms)  : 719, 767
     .   : milestone, 743,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7621) - mean (101ms)  : 100, 101
     .   : milestone, 101,
    master - mean (100ms)  : 99, 102
     .   : milestone, 100,

    section Baseline
    This PR (7621) - mean (100ms)  : 97, 103
     .   : milestone, 100,
    master - mean (100ms)  : 97, 103
     .   : milestone, 100,

    section CallTarget+Inlining+NGEN
    This PR (7621) - mean (775ms)  : 732, 818
     .   : milestone, 775,
    master - mean (778ms)  : 738, 818
     .   : milestone, 778,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7621) - mean (92ms)  : 91, 94
     .   : milestone, 92,
    master - mean (93ms)  : 91, 94
     .   : milestone, 93,

    section Baseline
    This PR (7621) - mean (92ms)  : 89, 94
     .   : milestone, 92,
    master - mean (92ms)  : 90, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (7621) - mean (660ms)  : 642, 678
     .   : milestone, 660,
    master - mean (666ms)  : 649, 682
     .   : milestone, 666,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7621) - mean (197ms)  : 195, 199
     .   : milestone, 197,
    master - mean (197ms)  : 194, 200
     .   : milestone, 197,

    section Baseline
    This PR (7621) - mean (194ms)  : 189, 199
     .   : milestone, 194,
    master - mean (194ms)  : 191, 197
     .   : milestone, 194,

    section CallTarget+Inlining+NGEN
    This PR (7621) - mean (1,171ms)  : 1102, 1239
     .   : milestone, 1171,
    master - mean (1,176ms)  : 1099, 1253
     .   : milestone, 1176,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7621) - mean (278ms)  : 272, 285
     .   : milestone, 278,
    master - mean (279ms)  : 275, 283
     .   : milestone, 279,

    section Baseline
    This PR (7621) - mean (278ms)  : 272, 284
     .   : milestone, 278,
    master - mean (279ms)  : 273, 285
     .   : milestone, 279,

    section CallTarget+Inlining+NGEN
    This PR (7621) - mean (936ms)  : 889, 982
     .   : milestone, 936,
    master - mean (936ms)  : 888, 984
     .   : milestone, 936,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7621) - mean (281ms)  : 277, 286
     .   : milestone, 281,
    master - mean (282ms)  : 278, 287
     .   : milestone, 282,

    section Baseline
    This PR (7621) - mean (281ms)  : 276, 286
     .   : milestone, 281,
    master - mean (282ms)  : 274, 289
     .   : milestone, 282,

    section CallTarget+Inlining+NGEN
    This PR (7621) - mean (1,000ms)  : 962, 1039
     .   : milestone, 1000,
    master - mean (1,000ms)  : 968, 1033
     .   : milestone, 1000,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7621) - mean (273ms)  : 265, 280
     .   : milestone, 273,
    master - mean (270ms)  : 266, 274
     .   : milestone, 270,

    section Baseline
    This PR (7621) - mean (270ms)  : 265, 274
     .   : milestone, 270,
    master - mean (270ms)  : 266, 273
     .   : milestone, 270,

    section CallTarget+Inlining+NGEN
    This PR (7621) - mean (852ms)  : 836, 869
     .   : milestone, 852,
    master - mean (855ms)  : 837, 872
     .   : milestone, 855,
Loading

@dudikeleti dudikeleti force-pushed the dudik/disable-telemtry-metric-probe branch from 7c321d4 to d9e22c7 Compare October 8, 2025 19:30
@pr-commenter
Copy link

pr-commenter bot commented Oct 8, 2025 •
edited
Loading

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7621 compared to master:

  • 2 benchmarks are faster, with geometric mean 2.243
  • 7 benchmarks have fewer allocations
  • 4 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7621

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 5.65 KB 5.71 KB 65 B 1.15%

Fewer allocations 🎉 in #7621

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net6.0 5.52 KB 5.5 KB -28 B -0.51%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.11 KB 6.01 KB -99 B -1.62%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.5μs 57.1ns 318ns 0 0 0 5.52 KB
master StartStopWithChild netcoreapp3.1 14.2μs 73ns 327ns 0 0 0 5.65 KB
master StartStopWithChild net472 21.8μs 123ns 842ns 0.868 0.326 0 6.11 KB
#7621 StartStopWithChild net6.0 10.7μs 56.4ns 288ns 0 0 0 5.5 KB
#7621 StartStopWithChild netcoreapp3.1 13.1μs 69.1ns 345ns 0 0 0 5.71 KB
#7621 StartStopWithChild net472 22.5μs 128ns 923ns 1.04 0.345 0.115 6.01 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 929μs 229ns 858ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.03ms 291ns 1.13μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.19ms 70.6ns 264ns 0 0 0 3.31 KB
#7621 WriteAndFlushEnrichedTraces net6.0 917μs 251ns 971ns 0 0 0 2.7 KB
#7621 WriteAndFlushEnrichedTraces netcoreapp3.1 1.03ms 470ns 1.82μs 0 0 0 2.7 KB
#7621 WriteAndFlushEnrichedTraces net472 1.22ms 1.22μs 4.73μs 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 345μs 921ns 3.19μs 0 0 0 178.25 KB
master AllCycleSimpleBody netcoreapp3.1 521μs 787ns 3.05μs 0 0 0 184.01 KB
master AllCycleSimpleBody net472 459μs 83.5ns 312ns 31.2 0 0 203.96 KB
master AllCycleMoreComplexBody net6.0 359μs 1.26μs 4.89μs 0 0 0 181.77 KB
master AllCycleMoreComplexBody netcoreapp3.1 528μs 995ns 3.86μs 0 0 0 187.44 KB
master AllCycleMoreComplexBody net472 469μs 89.1ns 334ns 32.4 0 0 207.5 KB
master ObjectExtractorSimpleBody net6.0 323ns 1.01ns 3.92ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 388ns 2.19ns 14.2ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 293ns 0.0126ns 0.0471ns 0.0443 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.21μs 25.7ns 99.4ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.76μs 26.5ns 102ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.9μs 7.04ns 26.3ns 0.59 0 0 3.8 KB
#7621 AllCycleSimpleBody net6.0 344μs 1.18μs 4.59μs 0 0 0 178.25 KB
#7621 AllCycleSimpleBody netcoreapp3.1 518μs 1.02μs 3.97μs 0 0 0 184.01 KB
#7621 AllCycleSimpleBody net472 458μs 243ns 941ns 31.2 0 0 203.96 KB
#7621 AllCycleMoreComplexBody net6.0 352μs 1.49μs 5.77μs 0 0 0 181.77 KB
#7621 AllCycleMoreComplexBody netcoreapp3.1 511μs 2μs 7.48μs 0 0 0 187.44 KB
#7621 AllCycleMoreComplexBody net472 468μs 182ns 680ns 32.4 0 0 207.5 KB
#7621 ObjectExtractorSimpleBody net6.0 335ns 1.63ns 6.74ns 0 0 0 280 B
#7621 ObjectExtractorSimpleBody netcoreapp3.1 397ns 2.22ns 13.9ns 0 0 0 272 B
#7621 ObjectExtractorSimpleBody net472 300ns 0.0249ns 0.0965ns 0.0437 0 0 281 B
#7621 ObjectExtractorMoreComplexBody net6.0 6.33μs 5.99ns 23.2ns 0 0 0 3.78 KB
#7621 ObjectExtractorMoreComplexBody netcoreapp3.1 7.86μs 39.1ns 156ns 0 0 0 3.69 KB
#7621 ObjectExtractorMoreComplexBody net472 6.72μs 6.78ns 26.3ns 0.572 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 77.2μs 33.9ns 131ns 0 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 97.5μs 167ns 647ns 0 0 0 32.4 KB
master EncodeArgs net472 109μs 13.8ns 53.5ns 4.91 0 0 32.51 KB
master EncodeLegacyArgs net6.0 142μs 52ns 202ns 0 0 0 2.15 KB
master EncodeLegacyArgs netcoreapp3.1 208μs 159ns 615ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 262μs 44ns 170ns 0 0 0 2.16 KB
#7621 EncodeArgs net6.0 76.3μs 252ns 872ns 0 0 0 32.4 KB
#7621 EncodeArgs netcoreapp3.1 97.7μs 148ns 574ns 0 0 0 32.4 KB
#7621 EncodeArgs net472 109μs 11.9ns 44.6ns 4.9 0 0 32.51 KB
#7621 EncodeLegacyArgs net6.0 146μs 115ns 430ns 0 0 0 2.14 KB
#7621 EncodeLegacyArgs netcoreapp3.1 200μs 709ns 2.75μs 0 0 0 2.15 KB
#7621 EncodeLegacyArgs net472 265μs 39ns 151ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #7621

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑netcoreapp3.1 2.417 720,815.40 298,166.07
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑netcoreapp3.1 2.082 865,367.50 415,738.33

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 391μs 119ns 460ns 0 0 0 4.56 KB
master RunWafRealisticBenchmark netcoreapp3.1 815μs 14.6μs 140μs 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 430μs 65.6ns 254ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 287μs 28ns 105ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 687μs 11μs 110μs 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 309μs 29.9ns 116ns 0 0 0 2.29 KB
#7621 RunWafRealisticBenchmark net6.0 391μs 88.1ns 330ns 0 0 0 4.55 KB
#7621 RunWafRealisticBenchmark netcoreapp3.1 416μs 79.6ns 287ns 0 0 0 4.48 KB
#7621 RunWafRealisticBenchmark net472 427μs 45.9ns 178ns 0 0 0 4.66 KB
#7621 RunWafRealisticBenchmarkWithAttack net6.0 285μs 35.8ns 139ns 0 0 0 2.24 KB
#7621 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 298μs 57ns 206ns 0 0 0 2.22 KB
#7621 RunWafRealisticBenchmarkWithAttack net472 310μs 28.9ns 108ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.2μs 106ns 395ns 0 0 0 14.52 KB
master SendRequest netcoreapp3.1 70.8μs 94.4ns 340ns 0 0 0 17.42 KB
master SendRequest net472 0.0124ns 0.00269ns 0.0104ns 0 0 0 0 b
#7621 SendRequest net6.0 60.8μs 60.6ns 218ns 0 0 0 14.52 KB
#7621 SendRequest netcoreapp3.1 71μs 94.5ns 341ns 0 0 0 17.42 KB
#7621 SendRequest net472 0.00378ns 0.00152ns 0.00588ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7621

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 5 B 3 B -2 B -40.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0 7 B 4 B -3 B -42.86%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net472 73 B 0 b -73 B -100.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net472 47 B 0 b -47 B -100.00%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master OriginalCharSlice net6.0 1.93ms 377ns 1.41μs 0 0 0 640.01 KB
master OriginalCharSlice netcoreapp3.1 2.13ms 5.07μs 18.3μs 0 0 0 640 KB
master OriginalCharSlice net472 2.6ms 966ns 3.74μs 100 0 0 641.95 KB
master OptimizedCharSlice net6.0 1.38ms 286ns 1.11μs 0 0 0 7 B
master OptimizedCharSlice netcoreapp3.1 1.68ms 695ns 2.69μs 0 0 0 1 B
master OptimizedCharSlice net472 1.97ms 445ns 1.72μs 0 0 0 73 B
master OptimizedCharSliceWithPool net6.0 892μs 88ns 341ns 0 0 0 5 B
master OptimizedCharSliceWithPool netcoreapp3.1 882μs 107ns 416ns 0 0 0 0 b
master OptimizedCharSliceWithPool net472 1.19ms 97.2ns 376ns 0 0 0 47 B
#7621 OriginalCharSlice net6.0 1.91ms 369ns 1.43μs 0 0 0 640.01 KB
#7621 OriginalCharSlice netcoreapp3.1 2.15ms 3.78μs 14.6μs 0 0 0 640 KB
#7621 OriginalCharSlice net472 2.68ms 2.86μs 11.1μs 100 0 0 641.95 KB
#7621 OptimizedCharSlice net6.0 1.44ms 334ns 1.29μs 0 0 0 4 B
#7621 OptimizedCharSlice netcoreapp3.1 1.69ms 251ns 973ns 0 0 0 1 B
#7621 OptimizedCharSlice net472 1.98ms 302ns 1.17μs 0 0 0 0 b
#7621 OptimizedCharSliceWithPool net6.0 813μs 27ns 97.5ns 0 0 0 3 B
#7621 OptimizedCharSliceWithPool netcoreapp3.1 797μs 93ns 360ns 0 0 0 0 b
#7621 OptimizedCharSliceWithPool net472 1.17ms 142ns 549ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7621

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 42.73 KB 41.74 KB -991 B -2.32%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 696μs 2.07μs 7.74μs 0 0 0 42.73 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 795μs 4.59μs 35.5μs 0 0 0 42 KB
master WriteAndFlushEnrichedTraces net472 937μs 4.43μs 18.3μs 8.93 4.46 0 56.39 KB
#7621 WriteAndFlushEnrichedTraces net6.0 669μs 3.9μs 36.6μs 0 0 0 41.74 KB
#7621 WriteAndFlushEnrichedTraces netcoreapp3.1 731μs 3.82μs 19.1μs 0 0 0 42.06 KB
#7621 WriteAndFlushEnrichedTraces net472 887μs 4.2μs 16.3μs 8.33 0 0 56.25 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.92μs 10.2ns 48.7ns 0 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 2.67μs 12.6ns 50.4ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.74μs 4.49ns 17.4ns 0.15 0.0136 0 987 B
#7621 ExecuteNonQuery net6.0 1.93μs 0.96ns 3.72ns 0 0 0 1.02 KB
#7621 ExecuteNonQuery netcoreapp3.1 2.64μs 2.3ns 8.62ns 0 0 0 1.02 KB
#7621 ExecuteNonQuery net472 2.76μs 6.19ns 24ns 0.149 0.0136 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.77μs 4.24ns 16.4ns 0 0 0 1.03 KB
master CallElasticsearch netcoreapp3.1 2.29μs 5.85ns 21.9ns 0 0 0 1.03 KB
master CallElasticsearch net472 3.59μs 3.12ns 12.1ns 0.161 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.82μs 8.67ns 36.8ns 0 0 0 1.01 KB
master CallElasticsearchAsync netcoreapp3.1 2.46μs 12.1ns 51.4ns 0 0 0 1.08 KB
master CallElasticsearchAsync net472 3.9μs 3.56ns 13.3ns 0.173 0 0 1.1 KB
#7621 CallElasticsearch net6.0 1.87μs 8.69ns 32.5ns 0 0 0 1.03 KB
#7621 CallElasticsearch netcoreapp3.1 2.22μs 9.59ns 33.2ns 0 0 0 1.03 KB
#7621 CallElasticsearch net472 3.61μs 1.7ns 6.6ns 0.162 0 0 1.04 KB
#7621 CallElasticsearchAsync net6.0 1.9μs 8.12ns 30.4ns 0 0 0 1.01 KB
#7621 CallElasticsearchAsync netcoreapp3.1 2.43μs 9.04ns 35ns 0 0 0 1.08 KB
#7621 CallElasticsearchAsync net472 3.9μs 1.66ns 6.41ns 0.157 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.84μs 8.62ns 35.5ns 0 0 0 952 B
master ExecuteAsync netcoreapp3.1 2.36μs 6.01ns 23.3ns 0 0 0 952 B
master ExecuteAsync net472 2.5μs 1.69ns 6.54ns 0.137 0 0 915 B
#7621 ExecuteAsync net6.0 1.89μs 9.79ns 49.9ns 0 0 0 952 B
#7621 ExecuteAsync netcoreapp3.1 2.36μs 3.29ns 12.7ns 0 0 0 952 B
#7621 ExecuteAsync net472 2.48μs 2.7ns 10.5ns 0.136 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.79μs 8.44ns 31.6ns 0 0 0 2.36 KB
master SendAsync netcoreapp3.1 8.5μs 16.4ns 61.4ns 0 0 0 2.9 KB
master SendAsync net472 12.3μs 9.45ns 36.6ns 0.491 0 0 3.18 KB
#7621 SendAsync net6.0 6.9μs 5.83ns 21.8ns 0 0 0 2.36 KB
#7621 SendAsync netcoreapp3.1 8.49μs 23.5ns 90.9ns 0 0 0 2.9 KB
#7621 SendAsync net472 12.1μs 9.35ns 33.7ns 0.484 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7621

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 258.36 KB 274.74 KB 16.38 KB 6.34%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 263.59 KB 274.94 KB 11.35 KB 4.31%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 43.15 KB 44.85 KB 1.7 KB 3.93%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 45.3μs 232ns 1.01μs 0 0 0 43.15 KB
master StringConcatBenchmark netcoreapp3.1 50.3μs 297ns 2.8μs 0 0 0 42.89 KB
master StringConcatBenchmark net472 55.7μs 284ns 1.24μs 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 490μs 2.31μs 9.51μs 0 0 0 263.59 KB
master StringConcatAspectBenchmark netcoreapp3.1 517μs 2.14μs 8.02μs 0 0 0 258.36 KB
master StringConcatAspectBenchmark net472 409μs 2.34μs 17μs 0 0 0 277.31 KB
#7621 StringConcatBenchmark net6.0 42.9μs 220ns 1.01μs 0 0 0 44.85 KB
#7621 StringConcatBenchmark netcoreapp3.1 48.7μs 349ns 3.31μs 0 0 0 42.78 KB
#7621 StringConcatBenchmark net472 56.8μs 229ns 858ns 0 0 0 57.34 KB
#7621 StringConcatAspectBenchmark net6.0 483μs 2.35μs 11.3μs 0 0 0 274.94 KB
#7621 StringConcatAspectBenchmark netcoreapp3.1 515μs 2.14μs 8.01μs 0 0 0 274.74 KB
#7621 StringConcatAspectBenchmark net472 404μs 2.31μs 17μs 0 0 0 278.53 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.44μs 12.4ns 60.9ns 0 0 0 1.7 KB
master EnrichedLog netcoreapp3.1 3.48μs 13.4ns 50.2ns 0 0 0 1.7 KB
master EnrichedLog net472 3.8μs 5.52ns 21.4ns 0.249 0 0 1.64 KB
#7621 EnrichedLog net6.0 2.47μs 10.1ns 36.3ns 0 0 0 1.7 KB
#7621 EnrichedLog netcoreapp3.1 3.7μs 17.7ns 75.2ns 0 0 0 1.7 KB
#7621 EnrichedLog net472 3.71μs 1.44ns 5.59ns 0.26 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 122μs 117ns 440ns 0 0 0 4.31 KB
master EnrichedLog netcoreapp3.1 129μs 501ns 1.87μs 0 0 0 4.31 KB
master EnrichedLog net472 165μs 160ns 619ns 0 0 0 4.51 KB
#7621 EnrichedLog net6.0 122μs 139ns 539ns 0 0 0 4.31 KB
#7621 EnrichedLog netcoreapp3.1 129μs 269ns 1.04μs 0 0 0 4.31 KB
#7621 EnrichedLog net472 167μs 44.5ns 160ns 0 0 0 4.52 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.84μs 3.9ns 14.6ns 0 0 0 2.26 KB
master EnrichedLog netcoreapp3.1 6.6μs 14.1ns 54.8ns 0 0 0 2.26 KB
master EnrichedLog net472 7.69μs 6.38ns 24.7ns 0.306 0 0 2.08 KB
#7621 EnrichedLog net6.0 4.78μs 15.3ns 59.1ns 0 0 0 2.26 KB
#7621 EnrichedLog netcoreapp3.1 6.83μs 17.6ns 68.3ns 0 0 0 2.26 KB
#7621 EnrichedLog net472 7.62μs 4.78ns 17.9ns 0.304 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.04μs 1.2ns 4.16ns 0 0 0 1.2 KB
master SendReceive netcoreapp3.1 2.56μs 2.16ns 8.1ns 0 0 0 1.2 KB
master SendReceive net472 3.11μs 1.24ns 4.63ns 0.186 0 0 1.2 KB
#7621 SendReceive net6.0 2μs 10.6ns 53ns 0 0 0 1.2 KB
#7621 SendReceive netcoreapp3.1 2.59μs 13ns 55ns 0 0 0 1.2 KB
#7621 SendReceive net472 3.14μs 2.61ns 10.1ns 0.187 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.14μs 10.3ns 40.1ns 0 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 5.44μs 14.5ns 54.3ns 0 0 0 1.63 KB
master EnrichedLog net472 6.45μs 4.55ns 17.6ns 0.291 0 0 2.03 KB
#7621 EnrichedLog net6.0 4.24μs 10.2ns 39.6ns 0 0 0 1.58 KB
#7621 EnrichedLog netcoreapp3.1 5.47μs 20.7ns 80.2ns 0 0 0 1.63 KB
#7621 EnrichedLog net472 6.39μs 8.23ns 31.9ns 0.318 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 736ns 3.62ns 15.4ns 0 0 0 576 B
master StartFinishSpan netcoreapp3.1 920ns 0.388ns 1.5ns 0 0 0 576 B
master StartFinishSpan net472 875ns 0.242ns 0.906ns 0.0876 0 0 578 B
master StartFinishScope net6.0 869ns 4.22ns 17.9ns 0 0 0 696 B
master StartFinishScope netcoreapp3.1 1.19μs 6.56ns 38.8ns 0 0 0 696 B
master StartFinishScope net472 1.09μs 0.469ns 1.75ns 0.103 0 0 658 B
#7621 StartFinishSpan net6.0 724ns 3.89ns 22ns 0 0 0 576 B
#7621 StartFinishSpan netcoreapp3.1 914ns 4.88ns 24.4ns 0 0 0 576 B
#7621 StartFinishSpan net472 873ns 0.222ns 0.858ns 0.0899 0 0 578 B
#7621 StartFinishScope net6.0 875ns 4.08ns 16.8ns 0 0 0 696 B
#7621 StartFinishScope netcoreapp3.1 1.15μs 4.22ns 16.3ns 0 0 0 696 B
#7621 StartFinishScope net472 1.06μs 0.277ns 1.07ns 0.1 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.04μs 5.09ns 21ns 0 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1.41μs 7.3ns 35.8ns 0 0 0 697 B
master RunOnMethodBegin net472 1.43μs 3.21ns 12.4ns 0.102 0 0 658 B
#7621 RunOnMethodBegin net6.0 1.03μs 4.87ns 19.5ns 0 0 0 696 B
#7621 RunOnMethodBegin netcoreapp3.1 1.42μs 5.41ns 21ns 0 0 0 696 B
#7621 RunOnMethodBegin net472 1.43μs 2.96ns 11.5ns 0.0998 0 0 658 B

@dudikeleti dudikeleti force-pushed the dudik/disable-telemtry-metric-probe branch from d9e22c7 to 50fe9d5 Compare October 9, 2025 07:42
@dudikeleti dudikeleti enabled auto-merge (squash) October 9, 2025 08:21
@dudikeleti dudikeleti merged commit 28cbaa0 into master Oct 9, 2025
155 of 156 checks passed
@dudikeleti dudikeleti deleted the dudik/disable-telemtry-metric-probe branch October 9, 2025 08:55
@github-actions github-actions bot added this to the vNext-v3 milestone Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucaspimentel lucaspimentel lucaspimentel approved these changes

@tylfin tylfin tylfin approved these changes

@bouwkast bouwkast bouwkast approved these changes

Assignees

No one assigned

Labels

area:debugger area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations)

Projects

None yet

Milestone

3.29.0

Development

Successfully merging this pull request may close these issues.

4 participants

@dudikeleti @lucaspimentel @tylfin @bouwkast