Skip to content

Add VBCSCompiler to exclude list#7694

Merged
andrewlock merged 1 commit intomasterfrom
andrew/add-exclusion
Oct 22, 2025
Merged

Add VBCSCompiler to exclude list#7694
andrewlock merged 1 commit intomasterfrom
andrew/add-exclusion

Conversation

@andrewlock
Copy link
Member

@andrewlock andrewlock commented Oct 22, 2025

Summary of changes

Add VBCSCompiler to "don't instrument" list

Reason for change

We saw it being instrumented in CI in the RC2 update #7659

Implementation details

Add VBCSCompiler to the list

Test coverage

Will be covered indirectly by #7659

@andrewlock andrewlock requested review from a team as code owners October 22, 2025 08:17
@andrewlock andrewlock added the area:native-library Automatic instrumentation native C++ code (Datadog.Trace.ClrProfiler.Native) label Oct 22, 2025
@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Oct 22, 2025

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7694) - mean (74ms)  : 72, 76
     .   : milestone, 74,
    master - mean (75ms)  : 73, 76
     .   : milestone, 75,

    section Baseline
    This PR (7694) - mean (70ms)  : 68, 73
     .   : milestone, 70,
    master - mean (70ms)  : 68, 73
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (7694) - mean (1,061ms)  : 1006, 1116
     .   : milestone, 1061,
    master - mean (1,072ms)  : 991, 1152
     .   : milestone, 1072,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7694) - mean (110ms)  : 108, 113
     .   : milestone, 110,
    master - mean (110ms)  : 107, 113
     .   : milestone, 110,

    section Baseline
    This PR (7694) - mean (110ms)  : 106, 113
     .   : milestone, 110,
    master - mean (109ms)  : 105, 113
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (7694) - mean (751ms)  : 727, 776
     .   : milestone, 751,
    master - mean (753ms)  : 725, 780
     .   : milestone, 753,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7694) - mean (98ms)  : 96, 100
     .   : milestone, 98,
    master - mean (97ms)  : 95, 100
     .   : milestone, 97,

    section Baseline
    This PR (7694) - mean (97ms)  : 95, 100
     .   : milestone, 97,
    master - mean (97ms)  : 93, 101
     .   : milestone, 97,

    section CallTarget+Inlining+NGEN
    This PR (7694) - mean (716ms)  : 680, 752
     .   : milestone, 716,
    master - mean (712ms)  : 687, 737
     .   : milestone, 712,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7694) - mean (98ms)  : 95, 100
     .   : milestone, 98,
    master - mean (97ms)  : 95, 99
     .   : milestone, 97,

    section Baseline
    This PR (7694) - mean (96ms)  : 94, 99
     .   : milestone, 96,
    master - mean (96ms)  : 93, 98
     .   : milestone, 96,

    section CallTarget+Inlining+NGEN
    This PR (7694) - mean (669ms)  : 654, 683
     .   : milestone, 669,
    master - mean (677ms)  : 664, 690
     .   : milestone, 677,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7694) - mean (197ms)  : 194, 200
     .   : milestone, 197,
    master - mean (196ms)  : 193, 198
     .   : milestone, 196,

    section Baseline
    This PR (7694) - mean (193ms)  : 189, 197
     .   : milestone, 193,
    master - mean (192ms)  : 188, 197
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (7694) - mean (1,173ms)  : 1098, 1247
     .   : milestone, 1173,
    master - mean (1,168ms)  : 1109, 1226
     .   : milestone, 1168,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7694) - mean (276ms)  : 271, 281
     .   : milestone, 276,
    master - mean (276ms)  : 274, 279
     .   : milestone, 276,

    section Baseline
    This PR (7694) - mean (276ms)  : 272, 280
     .   : milestone, 276,
    master - mean (276ms)  : 270, 283
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (7694) - mean (944ms)  : 902, 987
     .   : milestone, 944,
    master - mean (946ms)  : 905, 986
     .   : milestone, 946,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7694) - mean (271ms)  : 266, 276
     .   : milestone, 271,
    master - mean (270ms)  : 265, 276
     .   : milestone, 270,

    section Baseline
    This PR (7694) - mean (269ms)  : 264, 274
     .   : milestone, 269,
    master - mean (269ms)  : 265, 274
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (7694) - mean (933ms)  : 878, 988
     .   : milestone, 933,
    master - mean (928ms)  : 884, 973
     .   : milestone, 928,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7694) - mean (268ms)  : 265, 272
     .   : milestone, 268,
    master - mean (269ms)  : 264, 274
     .   : milestone, 269,

    section Baseline
    This PR (7694) - mean (269ms)  : 264, 273
     .   : milestone, 269,
    master - mean (270ms)  : 266, 273
     .   : milestone, 270,

    section CallTarget+Inlining+NGEN
    This PR (7694) - mean (850ms)  : 832, 867
     .   : milestone, 850,
    master - mean (861ms)  : 844, 878
     .   : milestone, 861,
Loading

@pr-commenter
Copy link

pr-commenter bot commented Oct 22, 2025

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7694 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.146
  • 3 benchmarks are slower, with geometric mean 1.736
  • 6 benchmarks have fewer allocations
  • 6 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Unknown 🤷 More allocations ⚠️

More allocations ⚠️ in #7694

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 0 b 6.06 KB 6.06 KB ∞

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.4μs 57.1ns 328ns 0 0 0 5.51 KB
master StartStopWithChild netcoreapp3.1 14.7μs 76.1ns 357ns 0 0 0 5.7 KB
master StartStopWithChild net472 N/A N/A N/A NaN NaN NaN 0 b
#7694 StartStopWithChild net6.0 10.6μs 58.5ns 379ns 0 0 0 5.52 KB
#7694 StartStopWithChild netcoreapp3.1 13.7μs 70ns 343ns 0 0 0 5.7 KB
#7694 StartStopWithChild net472 21.4μs 122ns 843ns 0.874 0.219 0 6.06 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 935μs 83.5ns 313ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.03ms 500ns 1.94μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.19ms 1.9μs 7.35μs 0 0 0 3.31 KB
#7694 WriteAndFlushEnrichedTraces net6.0 946μs 109ns 376ns 0 0 0 2.71 KB
#7694 WriteAndFlushEnrichedTraces netcoreapp3.1 1.01ms 152ns 548ns 0 0 0 2.7 KB
#7694 WriteAndFlushEnrichedTraces net472 1.19ms 303ns 1.05μs 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 360μs 107ns 414ns 0 0 0 186.08 KB
master AllCycleSimpleBody netcoreapp3.1 517μs 746ns 2.69μs 0 0 0 191.8 KB
master AllCycleSimpleBody net472 473μs 160ns 620ns 32.4 0 0 208.12 KB
master AllCycleMoreComplexBody net6.0 362μs 1.87μs 8.96μs 0 0 0 189.6 KB
master AllCycleMoreComplexBody netcoreapp3.1 509μs 1.85μs 7.16μs 0 0 0 195.23 KB
master AllCycleMoreComplexBody net472 481μs 121ns 467ns 31.2 0 0 211.66 KB
master ObjectExtractorSimpleBody net6.0 316ns 1.7ns 8.52ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 396ns 2.18ns 12.5ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 303ns 0.025ns 0.0902ns 0.0431 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.2μs 32.1ns 160ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.84μs 37.3ns 145ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.79μs 4.98ns 18.6ns 0.575 0 0 3.8 KB
#7694 AllCycleSimpleBody net6.0 361μs 1.28μs 4.96μs 0 0 0 186.08 KB
#7694 AllCycleSimpleBody netcoreapp3.1 519μs 1.32μs 5.13μs 0 0 0 191.8 KB
#7694 AllCycleSimpleBody net472 475μs 96ns 359ns 32.4 0 0 208.12 KB
#7694 AllCycleMoreComplexBody net6.0 368μs 1.81μs 7.45μs 0 0 0 189.6 KB
#7694 AllCycleMoreComplexBody netcoreapp3.1 504μs 2.39μs 9.57μs 0 0 0 195.23 KB
#7694 AllCycleMoreComplexBody net472 483μs 106ns 410ns 31.2 0 0 211.66 KB
#7694 ObjectExtractorSimpleBody net6.0 330ns 0.0728ns 0.252ns 0 0 0 280 B
#7694 ObjectExtractorSimpleBody netcoreapp3.1 405ns 2.21ns 11.7ns 0 0 0 272 B
#7694 ObjectExtractorSimpleBody net472 301ns 0.0269ns 0.093ns 0.0439 0 0 281 B
#7694 ObjectExtractorMoreComplexBody net6.0 6.24μs 31.5ns 151ns 0 0 0 3.78 KB
#7694 ObjectExtractorMoreComplexBody netcoreapp3.1 7.75μs 37.2ns 153ns 0 0 0 3.69 KB
#7694 ObjectExtractorMoreComplexBody net472 6.74μs 1.9ns 7.36ns 0.572 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 76.6μs 45.1ns 175ns 0 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 98.7μs 15.4ns 57.6ns 0 0 0 32.4 KB
master EncodeArgs net472 112μs 19ns 68.6ns 5.04 0 0 32.51 KB
master EncodeLegacyArgs net6.0 143μs 9.24ns 34.6ns 0 0 0 2.14 KB
master EncodeLegacyArgs netcoreapp3.1 198μs 108ns 403ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 263μs 63.3ns 245ns 0 0 0 2.16 KB
#7694 EncodeArgs net6.0 77.3μs 204ns 764ns 0 0 0 32.4 KB
#7694 EncodeArgs netcoreapp3.1 96.5μs 39.8ns 154ns 0 0 0 32.4 KB
#7694 EncodeArgs net472 110μs 8.97ns 33.6ns 4.94 0 0 32.51 KB
#7694 EncodeLegacyArgs net6.0 145μs 22.6ns 81.7ns 0 0 0 2.15 KB
#7694 EncodeLegacyArgs netcoreapp3.1 199μs 264ns 1.02μs 0 0 0 2.14 KB
#7694 EncodeLegacyArgs net472 263μs 39.6ns 148ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #7694

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑netcoreapp3.1 2.202 414,160.94 911,973.44
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑netcoreapp3.1 1.843 300,177.08 553,364.72 multimodal

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 397μs 94.3ns 365ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 415μs 1.14μs 4.25μs 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 426μs 27ns 101ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 285μs 56.5ns 219ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 300μs 231ns 895ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 309μs 47.1ns 170ns 0 0 0 2.29 KB
#7694 RunWafRealisticBenchmark net6.0 420μs 167ns 624ns 0 0 0 4.56 KB
#7694 RunWafRealisticBenchmark netcoreapp3.1 874μs 12.9μs 129μs 0 0 0 4.48 KB
#7694 RunWafRealisticBenchmark net472 426μs 55.5ns 215ns 0 0 0 4.66 KB
#7694 RunWafRealisticBenchmarkWithAttack net6.0 310μs 225ns 873ns 0 0 0 2.24 KB
#7694 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 626μs 16.1μs 161μs 0 0 0 2.22 KB
#7694 RunWafRealisticBenchmarkWithAttack net472 311μs 35.5ns 138ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 60.8μs 261ns 1.52μs 0 0 0 14.52 KB
master SendRequest netcoreapp3.1 71.5μs 89.3ns 322ns 0 0 0 17.42 KB
master SendRequest net472 0.0516ns 0.00729ns 0.0273ns 0 0 0 0 b
#7694 SendRequest net6.0 60.9μs 77.9ns 281ns 0 0 0 14.52 KB
#7694 SendRequest netcoreapp3.1 71.8μs 70.9ns 265ns 0 0 0 17.42 KB
#7694 SendRequest net472 0.00126ns 0.000785ns 0.00304ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7694

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑netcoreapp3.1 0 b 1 B 1 B ∞

Fewer allocations 🎉 in #7694

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑netcoreapp3.1 32 B 1 B -31 B -96.88%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net472 73 B 0 b -73 B -100.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net472 47 B 0 b -47 B -100.00%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master OriginalCharSlice net6.0 1.95ms 1.15μs 4.3μs 0 0 0 640 KB
master OriginalCharSlice netcoreapp3.1 2.07ms 5.36μs 18.6μs 0 0 0 640 KB
master OriginalCharSlice net472 2.65ms 321ns 1.16μs 100 0 0 641.95 KB
master OptimizedCharSlice net6.0 1.47ms 222ns 859ns 0 0 0 4 B
master OptimizedCharSlice netcoreapp3.1 1.68ms 417ns 1.61μs 0 0 0 32 B
master OptimizedCharSlice net472 1.94ms 357ns 1.38μs 0 0 0 73 B
master OptimizedCharSliceWithPool net6.0 840μs 23.6ns 88.1ns 0 0 0 3 B
master OptimizedCharSliceWithPool netcoreapp3.1 902μs 72.9ns 273ns 0 0 0 0 b
master OptimizedCharSliceWithPool net472 1.2ms 126ns 490ns 0 0 0 47 B
#7694 OriginalCharSlice net6.0 1.92ms 666ns 2.49μs 0 0 0 640.01 KB
#7694 OriginalCharSlice netcoreapp3.1 2.17ms 8.91μs 34.5μs 0 0 0 640 KB
#7694 OriginalCharSlice net472 2.59ms 328ns 1.23μs 100 0 0 641.95 KB
#7694 OptimizedCharSlice net6.0 1.37ms 963ns 3.73μs 0 0 0 4 B
#7694 OptimizedCharSlice netcoreapp3.1 1.67ms 292ns 1.13μs 0 0 0 1 B
#7694 OptimizedCharSlice net472 1.92ms 136ns 526ns 0 0 0 0 b
#7694 OptimizedCharSliceWithPool net6.0 827μs 13.2ns 51.1ns 0 0 0 3 B
#7694 OptimizedCharSliceWithPool netcoreapp3.1 811μs 76.8ns 298ns 0 0 0 1 B
#7694 OptimizedCharSliceWithPool net472 1.15ms 152ns 567ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7694

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 1.289 629,937.08 812,088.49

More allocations ⚠️ in #7694

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 42.16 KB 42.72 KB 562 B 1.33%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 639μs 3.29μs 14.7μs 0 0 0 41.63 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 631μs 1.23μs 6.84μs 0 0 0 42.16 KB
master WriteAndFlushEnrichedTraces net472 872μs 3.06μs 11.9μs 4.46 0 0 56.11 KB
#7694 WriteAndFlushEnrichedTraces net6.0 699μs 2.76μs 10.7μs 0 0 0 41.76 KB
#7694 WriteAndFlushEnrichedTraces netcoreapp3.1 792μs 4.59μs 41.3μs 0 0 0 42.72 KB
#7694 WriteAndFlushEnrichedTraces net472 932μs 1.92μs 7.42μs 8.33 0 0 55.95 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.94μs 6.9ns 25.8ns 0 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 2.62μs 6.76ns 26.2ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.72μs 4.13ns 16ns 0.15 0.0136 0 987 B
#7694 ExecuteNonQuery net6.0 1.88μs 7.36ns 28.5ns 0 0 0 1.02 KB
#7694 ExecuteNonQuery netcoreapp3.1 2.58μs 8.26ns 32ns 0 0 0 1.02 KB
#7694 ExecuteNonQuery net472 2.7μs 1.21ns 4.37ns 0.151 0.0137 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.81μs 5.63ns 21.1ns 0 0 0 1.03 KB
master CallElasticsearch netcoreapp3.1 2.27μs 9.99ns 38.7ns 0 0 0 1.03 KB
master CallElasticsearch net472 3.51μs 2.1ns 7.86ns 0.157 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.83μs 8.93ns 35.7ns 0 0 0 1.01 KB
master CallElasticsearchAsync netcoreapp3.1 2.42μs 10.2ns 39.4ns 0 0 0 1.08 KB
master CallElasticsearchAsync net472 3.77μs 3.38ns 13.1ns 0.171 0 0 1.1 KB
#7694 CallElasticsearch net6.0 1.71μs 8.03ns 31.1ns 0 0 0 1.03 KB
#7694 CallElasticsearch netcoreapp3.1 2.27μs 11ns 49.3ns 0 0 0 1.03 KB
#7694 CallElasticsearch net472 3.64μs 8.65ns 33.5ns 0.163 0 0 1.04 KB
#7694 CallElasticsearchAsync net6.0 1.8μs 8.03ns 28.9ns 0 0 0 1.01 KB
#7694 CallElasticsearchAsync netcoreapp3.1 2.38μs 9.39ns 36.4ns 0 0 0 1.08 KB
#7694 CallElasticsearchAsync net472 3.85μs 4.12ns 15.4ns 0.169 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.88μs 8.62ns 31.1ns 0 0 0 952 B
master ExecuteAsync netcoreapp3.1 2.39μs 8.51ns 32.9ns 0 0 0 952 B
master ExecuteAsync net472 2.63μs 2.91ns 11.3ns 0.132 0 0 915 B
#7694 ExecuteAsync net6.0 1.8μs 7.34ns 28.4ns 0 0 0 952 B
#7694 ExecuteAsync netcoreapp3.1 2.26μs 10.5ns 40.5ns 0 0 0 952 B
#7694 ExecuteAsync net472 2.64μs 3.31ns 12.8ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.74μs 17.3ns 64.6ns 0 0 0 2.36 KB
master SendAsync netcoreapp3.1 8.5μs 16.3ns 63.1ns 0 0 0 2.9 KB
master SendAsync net472 12.4μs 11.2ns 43.4ns 0.497 0 0 3.18 KB
#7694 SendAsync net6.0 6.72μs 14ns 54.4ns 0 0 0 2.36 KB
#7694 SendAsync netcoreapp3.1 8.42μs 29.4ns 114ns 0 0 0 2.9 KB
#7694 SendAsync net472 12.3μs 7.61ns 29.5ns 0.49 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Faster 🎉 More allocations ⚠️

Faster 🎉 in #7694

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 1.146 515,800.00 450,100.00

More allocations ⚠️ in #7694

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 0 b 65.54 KB 65.54 KB ∞
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 0 b 278.53 KB 278.53 KB ∞
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 43.48 KB 43.98 KB 496 B 1.14%

Fewer allocations 🎉 in #7694

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 42.86 KB 42.64 KB -224 B -0.52%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 276.77 KB 258.69 KB -18.08 KB -6.53%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 279.66 KB 259.24 KB -20.42 KB -7.30%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 42μs 167ns 820ns 0 0 0 43.48 KB
master StringConcatBenchmark netcoreapp3.1 49.3μs 279ns 2.62μs 0 0 0 42.86 KB
master StringConcatBenchmark net472 N/A N/A N/A NaN NaN NaN 0 b
master StringConcatAspectBenchmark net6.0 516μs 1.89μs 6.82μs 0 0 0 279.66 KB
master StringConcatAspectBenchmark netcoreapp3.1 522μs 1.73μs 6.24μs 0 0 0 276.77 KB
master StringConcatAspectBenchmark net472 N/A N/A N/A NaN NaN NaN 0 b
#7694 StringConcatBenchmark net6.0 47.6μs 398ns 3.77μs 0 0 0 43.98 KB
#7694 StringConcatBenchmark netcoreapp3.1 49.3μs 283ns 2.02μs 0 0 0 42.64 KB
#7694 StringConcatBenchmark net472 58.3μs 161ns 582ns 0 0 0 65.54 KB
#7694 StringConcatAspectBenchmark net6.0 451μs 1.09μs 3.93μs 0 0 0 259.24 KB
#7694 StringConcatAspectBenchmark netcoreapp3.1 504μs 832ns 2.88μs 0 0 0 258.69 KB
#7694 StringConcatAspectBenchmark net472 402μs 1.93μs 13.6μs 0 0 0 278.53 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.62μs 13.4ns 65.7ns 0 0 0 1.7 KB
master EnrichedLog netcoreapp3.1 3.46μs 17.1ns 70.4ns 0 0 0 1.7 KB
master EnrichedLog net472 3.87μs 2.89ns 10.8ns 0.251 0 0 1.64 KB
#7694 EnrichedLog net6.0 2.58μs 12.4ns 49.6ns 0 0 0 1.7 KB
#7694 EnrichedLog netcoreapp3.1 3.53μs 16.4ns 67.7ns 0 0 0 1.7 KB
#7694 EnrichedLog net472 3.88μs 2.51ns 9.71ns 0.252 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 123μs 70.3ns 243ns 0 0 0 4.31 KB
master EnrichedLog netcoreapp3.1 127μs 29ns 108ns 0 0 0 4.31 KB
master EnrichedLog net472 168μs 50ns 187ns 0 0 0 4.52 KB
#7694 EnrichedLog net6.0 123μs 50.6ns 189ns 0 0 0 4.31 KB
#7694 EnrichedLog netcoreapp3.1 129μs 332ns 1.29μs 0 0 0 4.31 KB
#7694 EnrichedLog net472 167μs 39.5ns 137ns 0 0 0 4.52 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 5.16μs 11.1ns 42.9ns 0 0 0 2.26 KB
master EnrichedLog netcoreapp3.1 6.55μs 19.6ns 75.8ns 0 0 0 2.26 KB
master EnrichedLog net472 7.69μs 7.46ns 28.9ns 0.306 0 0 2.08 KB
#7694 EnrichedLog net6.0 5.08μs 1.98ns 7.42ns 0 0 0 2.26 KB
#7694 EnrichedLog netcoreapp3.1 6.71μs 5.2ns 20.2ns 0 0 0 2.26 KB
#7694 EnrichedLog net472 7.47μs 6.88ns 26.7ns 0.298 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.05μs 10ns 42.5ns 0 0 0 1.2 KB
master SendReceive netcoreapp3.1 2.76μs 14.4ns 76.4ns 0 0 0 1.2 KB
master SendReceive net472 3.21μs 4.62ns 17.9ns 0.176 0 0 1.2 KB
#7694 SendReceive net6.0 1.98μs 9.29ns 34.8ns 0 0 0 1.2 KB
#7694 SendReceive netcoreapp3.1 2.68μs 5.73ns 22.2ns 0 0 0 1.2 KB
#7694 SendReceive net472 3.13μs 5.49ns 21.3ns 0.188 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.45μs 1.56ns 5.4ns 0 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 5.71μs 7.67ns 29.7ns 0 0 0 1.63 KB
master EnrichedLog net472 6.65μs 9.8ns 38ns 0.297 0 0 2.03 KB
#7694 EnrichedLog net6.0 4.31μs 5.07ns 19.6ns 0 0 0 1.58 KB
#7694 EnrichedLog netcoreapp3.1 5.46μs 2.53ns 9.45ns 0 0 0 1.63 KB
#7694 EnrichedLog net472 6.85μs 5.66ns 21.9ns 0.309 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 796ns 0.283ns 1.06ns 0 0 0 576 B
master StartFinishSpan netcoreapp3.1 994ns 4.84ns 19.9ns 0 0 0 576 B
master StartFinishSpan net472 950ns 0.412ns 1.59ns 0.0897 0 0 578 B
master StartFinishScope net6.0 939ns 4.36ns 17.4ns 0 0 0 696 B
master StartFinishScope netcoreapp3.1 1.15μs 5.63ns 24.5ns 0 0 0 696 B
master StartFinishScope net472 1.13μs 2.46ns 9.52ns 0.103 0 0 658 B
#7694 StartFinishSpan net6.0 756ns 3.08ns 11.9ns 0 0 0 576 B
#7694 StartFinishSpan netcoreapp3.1 943ns 4.91ns 23.6ns 0 0 0 576 B
#7694 StartFinishSpan net472 903ns 0.25ns 0.97ns 0.0875 0 0 578 B
#7694 StartFinishScope net6.0 899ns 4.75ns 24.2ns 0 0 0 696 B
#7694 StartFinishScope netcoreapp3.1 1.16μs 6.33ns 38.5ns 0 0 0 696 B
#7694 StartFinishScope net472 1.1μs 1.38ns 5.36ns 0.0995 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.05μs 5.46ns 26.7ns 0 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1.4μs 7.02ns 29.8ns 0 0 0 696 B
master RunOnMethodBegin net472 1.42μs 0.554ns 2.07ns 0.0981 0 0 658 B
#7694 RunOnMethodBegin net6.0 1.03μs 5.39ns 27.5ns 0 0 0 696 B
#7694 RunOnMethodBegin netcoreapp3.1 1.44μs 1.35ns 5.24ns 0 0 0 696 B
#7694 RunOnMethodBegin net472 1.44μs 0.511ns 1.91ns 0.099 0 0 658 B

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Oct 22, 2025 •
edited
Loading

⚠️ Tests

⚠️ Warnings

❄️ 1 New flaky test detected

SubmitsTraces from Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.MySqlConnectorTests (Datadog) 
Assert.Equal() Failure: Values differ
Expected: 147
Actual:   148

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2a3df3d | Docs | Was this helpful? Give us feedback!

@andrewlock andrewlock merged commit 3a19f0f into master Oct 22, 2025
160 checks passed
@andrewlock andrewlock deleted the andrew/add-exclusion branch October 22, 2025 11:04
@github-actions github-actions bot added this to the vNext-v3 milestone Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NachoEchevarria NachoEchevarria NachoEchevarria approved these changes

Assignees

No one assigned

Labels

area:native-library Automatic instrumentation native C++ code (Datadog.Trace.ClrProfiler.Native) area:shared-components

Projects

None yet

Milestone

3.30.0

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewlock @NachoEchevarria