Skip to content

Update documentation to account for MutableSettings#7867

Merged
andrewlock merged 1 commit intomasterfrom
andrew/fix-master
Nov 26, 2025
Merged

Update documentation to account for MutableSettings#7867
andrewlock merged 1 commit intomasterfrom
andrew/fix-master

Conversation

@andrewlock
Copy link
Member

Summary of changes

  • Fix broken master due to concurrent merges of conflicting

Reason for change

#7698 moved to defining references in yaml, and in #7723, some of those references moved, which broke the build

Implementation details

Update the YAML file and rebuild

Test coverage

If it builds, we're good!

@andrewlock andrewlock added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Nov 26, 2025
@andrewlock andrewlock requested review from a team as code owners November 26, 2025 11:59
Copy link
Contributor

@anna-git anna-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much!

@andrewlock andrewlock enabled auto-merge (squash) November 26, 2025 12:34
@dd-trace-dotnet-ci-bot
Copy link

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (7867) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration76.78 ± (76.41 - 77.15) ms75.56 ± (75.53 - 76.12) ms-1.6%
.NET Framework 4.8 - Bailout
duration79.01 ± (78.98 - 79.74) ms80.77 ± (80.74 - 81.59) ms+2.2%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1049.83 ± (1055.45 - 1066.15) ms1065.20 ± (1072.01 - 1085.39) ms+1.5%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms23.22 ± (23.13 - 23.30) ms23.16 ± (23.08 - 23.24) ms-0.2%
process.time_to_main_ms88.30 ± (87.93 - 88.66) ms88.48 ± (88.13 - 88.82) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.91 ± (10.91 - 10.91) MB10.92 ± (10.91 - 10.92) MB+0.1%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%
.NET Core 3.1 - Bailout
process.internal_duration_ms22.87 ± (22.81 - 22.92) ms22.70 ± (22.63 - 22.76) ms-0.7%
process.time_to_main_ms88.28 ± (87.95 - 88.61) ms89.20 ± (88.82 - 89.57) ms+1.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.95 ± (10.95 - 10.95) MB10.96 ± (10.95 - 10.96) MB+0.0%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms222.75 ± (220.67 - 224.82) ms221.67 ± (220.12 - 223.21) ms-0.5%
process.time_to_main_ms497.99 ± (496.96 - 499.02) ms499.87 ± (498.82 - 500.92) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed47.84 ± (47.82 - 47.86) MB47.76 ± (47.74 - 47.78) MB-0.2%
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.5%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms21.84 ± (21.78 - 21.90) ms22.02 ± (21.94 - 22.10) ms+0.8%✅⬆️
process.time_to_main_ms76.39 ± (76.09 - 76.69) ms77.16 ± (76.79 - 77.54) ms+1.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.60 ± (10.59 - 10.60) MB10.63 ± (10.63 - 10.63) MB+0.3%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%
.NET 6 - Bailout
process.internal_duration_ms21.68 ± (21.62 - 21.74) ms21.87 ± (21.78 - 21.95) ms+0.8%✅⬆️
process.time_to_main_ms77.45 ± (77.18 - 77.72) ms77.68 ± (77.25 - 78.11) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.68 ± (10.67 - 10.68) MB10.66 ± (10.66 - 10.67) MB-0.1%
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms209.24 ± (207.97 - 210.51) ms215.45 ± (213.57 - 217.34) ms+3.0%✅⬆️
process.time_to_main_ms468.88 ± (467.90 - 469.85) ms471.15 ± (470.06 - 472.24) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed48.12 ± (48.10 - 48.15) MB47.96 ± (47.93 - 47.98) MB-0.3%
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms19.94 ± (19.86 - 20.02) ms20.13 ± (20.06 - 20.20) ms+0.9%✅⬆️
process.time_to_main_ms74.90 ± (74.52 - 75.29) ms76.56 ± (76.22 - 76.89) ms+2.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed7.66 ± (7.65 - 7.67) MB7.67 ± (7.67 - 7.68) MB+0.2%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%
.NET 8 - Bailout
process.internal_duration_ms19.98 ± (19.93 - 20.04) ms20.23 ± (20.16 - 20.29) ms+1.2%✅⬆️
process.time_to_main_ms76.52 ± (76.23 - 76.81) ms78.63 ± (78.28 - 78.98) ms+2.8%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed7.71 ± (7.70 - 7.72) MB7.74 ± (7.73 - 7.74) MB+0.3%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms193.41 ± (192.48 - 194.34) ms194.99 ± (193.99 - 195.99) ms+0.8%✅⬆️
process.time_to_main_ms458.24 ± (457.32 - 459.16) ms461.03 ± (459.88 - 462.17) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed36.48 ± (36.44 - 36.53) MB36.49 ± (36.45 - 36.53) MB+0.0%✅⬆️
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)+0.1%✅⬆️

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration193.09 ± (192.96 - 193.76) ms194.50 ± (194.32 - 195.14) ms+0.7%✅⬆️
.NET Framework 4.8 - Bailout
duration196.53 ± (196.52 - 197.10) ms197.99 ± (197.81 - 198.50) ms+0.7%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1111.45 ± (1118.20 - 1128.70) ms1110.46 ± (1113.75 - 1122.29) ms-0.1%
.NET Core 3.1 - Baseline
process.internal_duration_ms188.47 ± (188.10 - 188.84) ms189.33 ± (188.92 - 189.74) ms+0.5%✅⬆️
process.time_to_main_ms81.01 ± (80.79 - 81.23) ms81.41 ± (81.17 - 81.64) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed16.02 ± (16.00 - 16.05) MB16.15 ± (16.13 - 16.18) MB+0.8%✅⬆️
runtime.dotnet.threads.count20 ± (19 - 20)20 ± (19 - 20)+0.2%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms187.74 ± (187.43 - 188.05) ms188.13 ± (187.86 - 188.39) ms+0.2%✅⬆️
process.time_to_main_ms81.98 ± (81.85 - 82.11) ms82.46 ± (82.34 - 82.58) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed16.15 ± (16.11 - 16.18) MB16.18 ± (16.15 - 16.22) MB+0.2%✅⬆️
runtime.dotnet.threads.count21 ± (20 - 21)20 ± (20 - 21)-0.4%
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms409.92 ± (406.45 - 413.39) ms411.10 ± (407.89 - 414.32) ms+0.3%✅⬆️
process.time_to_main_ms470.48 ± (469.85 - 471.10) ms474.81 ± (474.17 - 475.46) ms+0.9%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed58.69 ± (58.57 - 58.81) MB58.77 ± (58.66 - 58.88) MB+0.1%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+0.0%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms193.04 ± (192.61 - 193.47) ms192.67 ± (192.36 - 192.99) ms-0.2%
process.time_to_main_ms70.11 ± (69.94 - 70.29) ms70.57 ± (70.39 - 70.76) ms+0.7%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed16.21 ± (16.08 - 16.33) MB16.35 ± (16.26 - 16.43) MB+0.9%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 19)19 ± (19 - 19)+2.6%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms191.68 ± (191.39 - 191.98) ms191.81 ± (191.47 - 192.16) ms+0.1%✅⬆️
process.time_to_main_ms70.79 ± (70.70 - 70.88) ms71.41 ± (71.28 - 71.54) ms+0.9%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed16.25 ± (16.11 - 16.39) MB16.36 ± (16.26 - 16.47) MB+0.7%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 20)20 ± (19 - 20)+1.9%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms411.39 ± (408.59 - 414.19) ms412.87 ± (410.25 - 415.50) ms+0.4%✅⬆️
process.time_to_main_ms442.16 ± (441.51 - 442.82) ms443.88 ± (443.27 - 444.50) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed58.72 ± (58.57 - 58.87) MB58.95 ± (58.81 - 59.09) MB+0.4%✅⬆️
runtime.dotnet.threads.count30 ± (30 - 30)29 ± (29 - 30)-0.3%
.NET 8 - Baseline
process.internal_duration_ms190.45 ± (190.15 - 190.76) ms190.88 ± (190.52 - 191.24) ms+0.2%✅⬆️
process.time_to_main_ms69.66 ± (69.48 - 69.85) ms69.65 ± (69.49 - 69.81) ms-0.0%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed11.75 ± (11.73 - 11.78) MB11.74 ± (11.71 - 11.77) MB-0.1%
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)-0.4%
.NET 8 - Bailout
process.internal_duration_ms189.78 ± (189.50 - 190.06) ms190.86 ± (190.59 - 191.12) ms+0.6%✅⬆️
process.time_to_main_ms70.73 ± (70.61 - 70.84) ms71.08 ± (70.95 - 71.21) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed11.82 ± (11.79 - 11.86) MB11.80 ± (11.78 - 11.82) MB-0.2%
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.4%✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms367.06 ± (365.63 - 368.49) ms369.34 ± (367.68 - 371.01) ms+0.6%✅⬆️
process.time_to_main_ms432.28 ± (431.59 - 432.97) ms432.34 ± (431.85 - 432.82) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed47.92 ± (47.89 - 47.95) MB47.88 ± (47.84 - 47.91) MB-0.1%
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.1%
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8)
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7867) - mean (76ms)  : 72, 80
    master - mean (77ms)  : 71, 82

    section Bailout
    This PR (7867) - mean (81ms)  : 75, 87
    master - mean (79ms)  : 73, 85

    section CallTarget+Inlining+NGEN
    This PR (7867) - mean (1,079ms)  : 976, 1181
    master - mean (1,061ms)  : 983, 1138

Loading
FakeDbCommand (.NET Core 3.1)
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7867) - mean (119ms)  : 113, 126
    master - mean (119ms)  : 113, 125

    section Bailout
    This PR (7867) - mean (119ms)  : 112, 127
    master - mean (119ms)  : 111, 126

    section CallTarget+Inlining+NGEN
    This PR (7867) - mean (762ms)  : 722, 803
    master - mean (763ms)  : 707, 819

Loading
FakeDbCommand (.NET 6)
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7867) - mean (106ms)  : 99, 114
    master - mean (105ms)  : 100, 110

    section Bailout
    This PR (7867) - mean (106ms)  : 98, 115
    master - mean (106ms)  : 100, 111

    section CallTarget+Inlining+NGEN
    This PR (7867) - mean (720ms)  : 676, 764
    master - mean (708ms)  : 671, 745

Loading
FakeDbCommand (.NET 8)
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7867) - mean (106ms)  : 99, 112
    master - mean (103ms)  : 95, 111

    section Bailout
    This PR (7867) - mean (108ms)  : 101, 114
    master - mean (105ms)  : 99, 111

    section CallTarget+Inlining+NGEN
    This PR (7867) - mean (698ms)  : 665, 731
    master - mean (690ms)  : 658, 721

Loading
HttpMessageHandler (.NET Framework 4.8)
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7867) - mean (195ms)  : 191, 199
    master - mean (193ms)  : 189, 197

    section Bailout
    This PR (7867) - mean (198ms)  : 195, 202
    master - mean (197ms)  : 194, 200

    section CallTarget+Inlining+NGEN
    This PR (7867) - mean (1,118ms)  : 1058, 1178
    master - mean (1,123ms)  : 1049, 1198

Loading
HttpMessageHandler (.NET Core 3.1)
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7867) - mean (279ms)  : 273, 284
    master - mean (278ms)  : 273, 283

    section Bailout
    This PR (7867) - mean (279ms)  : 276, 282
    master - mean (278ms)  : 274, 282

    section CallTarget+Inlining+NGEN
    This PR (7867) - mean (922ms)  : 870, 974
    master - mean (913ms)  : 856, 971

Loading
HttpMessageHandler (.NET 6)
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7867) - mean (271ms)  : 266, 276
    master - mean (272ms)  : 265, 278

    section Bailout
    This PR (7867) - mean (271ms)  : 266, 276
    master - mean (271ms)  : 267, 274

    section CallTarget+Inlining+NGEN
    This PR (7867) - mean (892ms)  : 850, 935
    master - mean (888ms)  : 844, 931

Loading
HttpMessageHandler (.NET 8)
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7867) - mean (270ms)  : 265, 276
    master - mean (270ms)  : 264, 276

    section Bailout
    This PR (7867) - mean (271ms)  : 266, 277
    master - mean (270ms)  : 266, 274

    section CallTarget+Inlining+NGEN
    This PR (7867) - mean (833ms)  : 811, 856
    master - mean (830ms)  : 812, 849

Loading

@andrewlock andrewlock merged commit 9ac42fd into master Nov 26, 2025
152 checks passed
@andrewlock andrewlock deleted the andrew/fix-master branch November 26, 2025 13:10
@github-actions github-actions bot added this to the vNext-v3 milestone Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants