Skip to content

Only pull docker images if we need to#7910

Merged
andrewlock merged 1 commit intomasterfrom
andrew/fix-pipeline
Dec 5, 2025
Merged

Only pull docker images if we need to#7910
andrewlock merged 1 commit intomasterfrom
andrew/fix-pipeline

Conversation

@andrewlock
Copy link
Member

@andrewlock andrewlock commented Dec 5, 2025

Summary of changes

Only pulls docker images if we need to

Reason for change

Docker hub appears to be throwing 500 errors, and even though the images are pre-pulled, we're calling docker pull which then fails. Instead, we can only pull if we need to, as we only pre-pull unchanging images anyway.

Implementation details

Use docker manifest to check if it exists, then docker pull if not

Test coverage

This is the test

Other details

Through this to AI, so if it doesn't work, don't blame me

@andrewlock andrewlock requested a review from a team as a code owner December 5, 2025 10:25
@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Dec 5, 2025
@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Dec 5, 2025

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (7910) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration75.29 ± (75.02 - 75.68) ms75.19 ± (74.99 - 75.67) ms-0.1%✅
.NET Framework 4.8 - Bailout
duration80.23 ± (80.18 - 80.85) ms79.61 ± (79.53 - 80.18) ms-0.8%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1064.32 ± (1063.80 - 1071.11) ms1062.61 ± (1065.31 - 1076.27) ms-0.2%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms22.79 ± (22.72 - 22.86) ms22.89 ± (22.82 - 22.97) ms+0.5%✅⬆️
process.time_to_main_ms87.14 ± (86.81 - 87.47) ms87.31 ± (86.94 - 87.68) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.92 ± (10.92 - 10.92) MB10.92 ± (10.92 - 10.92) MB+0.0%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.98 ± (22.91 - 23.06) ms23.16 ± (23.04 - 23.27) ms+0.7%✅⬆️
process.time_to_main_ms90.12 ± (89.75 - 90.49) ms91.06 ± (90.63 - 91.49) ms+1.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.96 ± (10.96 - 10.97) MB10.96 ± (10.96 - 10.97) MB-0.0%✅
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms220.47 ± (219.05 - 221.88) ms222.03 ± (220.77 - 223.30) ms+0.7%✅⬆️
process.time_to_main_ms501.39 ± (500.09 - 502.69) ms502.82 ± (501.71 - 503.94) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed47.86 ± (47.84 - 47.88) MB47.91 ± (47.89 - 47.93) MB+0.1%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.1%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms21.60 ± (21.53 - 21.67) ms22.02 ± (21.94 - 22.09) ms+1.9%✅⬆️
process.time_to_main_ms76.50 ± (76.12 - 76.87) ms78.25 ± (77.92 - 78.57) ms+2.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.61 ± (10.61 - 10.61) MB10.63 ± (10.63 - 10.64) MB+0.2%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms21.62 ± (21.56 - 21.69) ms21.90 ± (21.83 - 21.98) ms+1.3%✅⬆️
process.time_to_main_ms77.17 ± (76.91 - 77.43) ms78.70 ± (78.31 - 79.09) ms+2.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.65 ± (10.65 - 10.66) MB10.68 ± (10.67 - 10.68) MB+0.2%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms210.68 ± (209.58 - 211.77) ms213.07 ± (212.00 - 214.13) ms+1.1%✅⬆️
process.time_to_main_ms466.04 ± (465.17 - 466.91) ms467.96 ± (466.94 - 468.98) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.15 ± (48.12 - 48.17) MB48.13 ± (48.10 - 48.15) MB-0.0%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.0%✅
.NET 8 - Baseline
process.internal_duration_ms20.01 ± (19.94 - 20.08) ms20.00 ± (19.93 - 20.07) ms-0.0%✅
process.time_to_main_ms76.41 ± (76.00 - 76.81) ms76.07 ± (75.74 - 76.41) ms-0.4%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.66 ± (7.66 - 7.67) MB7.66 ± (7.65 - 7.66) MB-0.1%✅
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.90 ± (19.85 - 19.96) ms19.79 ± (19.73 - 19.85) ms-0.6%✅
process.time_to_main_ms76.42 ± (76.13 - 76.72) ms76.75 ± (76.41 - 77.10) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.73 ± (7.72 - 7.73) MB7.71 ± (7.70 - 7.71) MB-0.2%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms194.14 ± (193.17 - 195.12) ms194.52 ± (193.43 - 195.62) ms+0.2%✅⬆️
process.time_to_main_ms455.66 ± (454.79 - 456.53) ms456.39 ± (455.44 - 457.34) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed36.45 ± (36.41 - 36.50) MB36.34 ± (36.30 - 36.38) MB-0.3%✅
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)-0.4%✅

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration192.71 ± (192.88 - 193.81) ms192.27 ± (192.31 - 193.09) ms-0.2%✅
.NET Framework 4.8 - Bailout
duration196.61 ± (196.64 - 197.39) ms196.71 ± (196.47 - 197.08) ms+0.1%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1109.95 ± (1113.01 - 1121.69) ms1110.85 ± (1116.02 - 1125.31) ms+0.1%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms187.92 ± (187.61 - 188.23) ms188.52 ± (188.20 - 188.84) ms+0.3%✅⬆️
process.time_to_main_ms80.68 ± (80.51 - 80.84) ms80.99 ± (80.74 - 81.25) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.07 ± (16.04 - 16.09) MB16.10 ± (16.07 - 16.13) MB+0.2%✅⬆️
runtime.dotnet.threads.count20 ± (19 - 20)20 ± (20 - 20)+0.0%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms187.80 ± (187.44 - 188.16) ms187.98 ± (187.68 - 188.27) ms+0.1%✅⬆️
process.time_to_main_ms82.40 ± (82.23 - 82.58) ms81.98 ± (81.84 - 82.13) ms-0.5%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.12 ± (16.10 - 16.15) MB16.20 ± (16.18 - 16.23) MB+0.5%✅⬆️
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (20 - 21)-0.2%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms397.99 ± (395.31 - 400.68) ms403.42 ± (400.82 - 406.02) ms+1.4%✅⬆️
process.time_to_main_ms474.81 ± (474.20 - 475.43) ms474.07 ± (473.44 - 474.70) ms-0.2%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed58.80 ± (58.68 - 58.93) MB58.93 ± (58.83 - 59.03) MB+0.2%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 30)29 ± (29 - 29)-0.1%✅
.NET 6 - Baseline
process.internal_duration_ms192.89 ± (192.56 - 193.23) ms192.29 ± (191.89 - 192.70) ms-0.3%✅
process.time_to_main_ms70.28 ± (70.13 - 70.43) ms70.12 ± (69.93 - 70.31) ms-0.2%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.19 ± (16.07 - 16.30) MB16.05 ± (15.89 - 16.21) MB-0.8%✅
runtime.dotnet.threads.count18 ± (18 - 19)18 ± (18 - 18)-1.9%✅
.NET 6 - Bailout
process.internal_duration_ms191.95 ± (191.66 - 192.24) ms191.00 ± (190.75 - 191.25) ms-0.5%✅
process.time_to_main_ms71.10 ± (71.01 - 71.19) ms70.78 ± (70.71 - 70.85) ms-0.4%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.22 ± (16.09 - 16.35) MB16.00 ± (15.84 - 16.16) MB-1.4%✅
runtime.dotnet.threads.count20 ± (20 - 20)19 ± (19 - 19)-3.2%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms410.45 ± (408.25 - 412.66) ms405.76 ± (404.24 - 407.27) ms-1.1%✅
process.time_to_main_ms443.18 ± (442.56 - 443.80) ms441.98 ± (441.32 - 442.64) ms-0.3%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed59.06 ± (58.94 - 59.19) MB58.92 ± (58.76 - 59.08) MB-0.2%✅
runtime.dotnet.threads.count30 ± (29 - 30)30 ± (29 - 30)-0.0%✅
.NET 8 - Baseline
process.internal_duration_ms191.29 ± (190.92 - 191.66) ms190.32 ± (189.99 - 190.66) ms-0.5%✅
process.time_to_main_ms69.74 ± (69.57 - 69.92) ms69.45 ± (69.30 - 69.60) ms-0.4%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.77 ± (11.75 - 11.80) MB11.73 ± (11.71 - 11.76) MB-0.3%✅
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)-0.7%✅
.NET 8 - Bailout
process.internal_duration_ms190.44 ± (190.15 - 190.74) ms189.35 ± (189.13 - 189.56) ms-0.6%✅
process.time_to_main_ms70.59 ± (70.47 - 70.71) ms70.36 ± (70.24 - 70.48) ms-0.3%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.82 ± (11.79 - 11.85) MB11.82 ± (11.78 - 11.85) MB-0.1%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.1%✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms367.76 ± (366.61 - 368.90) ms364.75 ± (363.35 - 366.14) ms-0.8%✅
process.time_to_main_ms430.31 ± (429.76 - 430.86) ms430.67 ± (430.08 - 431.25) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed47.94 ± (47.91 - 47.96) MB47.94 ± (47.92 - 47.97) MB+0.0%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+0.0%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7910) - mean (75ms)  : 70, 81
    master - mean (75ms)  : 70, 80

    section Bailout
    This PR (7910) - mean (80ms)  : 75, 85
    master - mean (81ms)  : 75, 86

    section CallTarget+Inlining+NGEN
    This PR (7910) - mean (1,071ms)  : 987, 1154
    master - mean (1,067ms)  : 1015, 1120
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7910) - mean (118ms)  : 110, 125
    master - mean (117ms)  : 110, 125

    section Bailout
    This PR (7910) - mean (122ms)  : 114, 129
    master - mean (120ms)  : 114, 127

    section CallTarget+Inlining+NGEN
    This PR (7910) - mean (764ms)  : 735, 793
    master - mean (758ms)  : 721, 795
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7910) - mean (108ms)  : 101, 114
    master - mean (105ms)  : 98, 112

    section Bailout
    This PR (7910) - mean (107ms)  : 99, 116
    master - mean (106ms)  : 101, 111

    section CallTarget+Inlining+NGEN
    This PR (7910) - mean (708ms)  : 678, 739
    master - mean (705ms)  : 681, 730
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7910) - mean (105ms)  : 99, 111
    master - mean (105ms)  : 98, 113

    section Bailout
    This PR (7910) - mean (105ms)  : 98, 112
    master - mean (105ms)  : 100, 110

    section CallTarget+Inlining+NGEN
    This PR (7910) - mean (687ms)  : 651, 724
    master - mean (684ms)  : 648, 720
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7910) - mean (193ms)  : 189, 196
    master - mean (193ms)  : 188, 198

    section Bailout
    This PR (7910) - mean (197ms)  : 194, 200
    master - mean (197ms)  : 193, 201

    section CallTarget+Inlining+NGEN
    This PR (7910) - mean (1,121ms)  : 1053, 1188
    master - mean (1,117ms)  : 1056, 1179
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7910) - mean (278ms)  : 272, 284
    master - mean (277ms)  : 273, 282

    section Bailout
    This PR (7910) - mean (278ms)  : 273, 283
    master - mean (279ms)  : 274, 283

    section CallTarget+Inlining+NGEN
    This PR (7910) - mean (911ms)  : 864, 958
    master - mean (914ms)  : 867, 961
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7910) - mean (271ms)  : 265, 276
    master - mean (272ms)  : 267, 277

    section Bailout
    This PR (7910) - mean (270ms)  : 267, 273
    master - mean (271ms)  : 267, 275

    section CallTarget+Inlining+NGEN
    This PR (7910) - mean (879ms)  : 850, 908
    master - mean (889ms)  : 845, 932
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7910) - mean (270ms)  : 264, 276
    master - mean (270ms)  : 265, 276

    section Bailout
    This PR (7910) - mean (269ms)  : 267, 271
    master - mean (271ms)  : 266, 275

    section CallTarget+Inlining+NGEN
    This PR (7910) - mean (827ms)  : 802, 851
    master - mean (828ms)  : 803, 853
Loading

@andrewlock andrewlock enabled auto-merge (squash) December 5, 2025 11:09
@pr-commenter
Copy link

pr-commenter bot commented Dec 5, 2025

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7910 compared to master:

  • All benchmarks have the same speed
  • 2 benchmarks have fewer allocations
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 11.1μs 60.3ns 336ns 0 0 0 5.5 KB
master StartStopWithChild netcoreapp3.1 13.5μs 70.9ns 361ns 0 0 0 5.71 KB
master StartStopWithChild net472 22.1μs 83.8ns 324ns 1.01 0.336 0.112 5.94 KB
#7910 StartStopWithChild net6.0 11.3μs 62.5ns 380ns 0 0 0 5.5 KB
#7910 StartStopWithChild netcoreapp3.1 14.1μs 72.7ns 341ns 0 0 0 5.7 KB
#7910 StartStopWithChild net472 22.5μs 123ns 671ns 0.871 0.218 0 5.91 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 1.27ms 176ns 683ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.39ms 69.4ns 240ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.75ms 1.67μs 6.46μs 0 0 0 3.26 KB
#7910 WriteAndFlushEnrichedTraces net6.0 1.26ms 86.5ns 335ns 0 0 0 2.7 KB
#7910 WriteAndFlushEnrichedTraces netcoreapp3.1 1.37ms 99.5ns 386ns 0 0 0 2.7 KB
#7910 WriteAndFlushEnrichedTraces net472 1.71ms 2.36μs 9.14μs 0 0 0 3.26 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 1.08μs 4.95ns 19.2ns 0 0 0 1.22 KB
master AllCycleSimpleBody netcoreapp3.1 1.42μs 7.39ns 38.4ns 0 0 0 1.2 KB
master AllCycleSimpleBody net472 1.03μs 0.369ns 1.43ns 0.19 0 0 1.23 KB
master AllCycleMoreComplexBody net6.0 7.34μs 35.4ns 137ns 0 0 0 4.72 KB
master AllCycleMoreComplexBody netcoreapp3.1 9.07μs 43.7ns 185ns 0 0 0 4.62 KB
master AllCycleMoreComplexBody net472 7.61μs 4.07ns 15.8ns 0.724 0 0 4.74 KB
master ObjectExtractorSimpleBody net6.0 328ns 1.79ns 10.4ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 402ns 2.14ns 10.5ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 296ns 0.0491ns 0.19ns 0.0432 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.33μs 33.6ns 175ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.81μs 40.9ns 192ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.71μs 2.46ns 9.51ns 0.572 0 0 3.8 KB
#7910 AllCycleSimpleBody net6.0 1.08μs 6.21ns 48.9ns 0 0 0 1.22 KB
#7910 AllCycleSimpleBody netcoreapp3.1 1.39μs 7.61ns 45ns 0 0 0 1.2 KB
#7910 AllCycleSimpleBody net472 1.02μs 0.327ns 1.27ns 0.193 0 0 1.23 KB
#7910 AllCycleMoreComplexBody net6.0 7.28μs 36.9ns 138ns 0 0 0 4.72 KB
#7910 AllCycleMoreComplexBody netcoreapp3.1 9.01μs 46.6ns 218ns 0 0 0 4.62 KB
#7910 AllCycleMoreComplexBody net472 7.66μs 4.58ns 17.7ns 0.73 0 0 4.74 KB
#7910 ObjectExtractorSimpleBody net6.0 316ns 1.77ns 10.6ns 0 0 0 280 B
#7910 ObjectExtractorSimpleBody netcoreapp3.1 407ns 0.123ns 0.474ns 0 0 0 272 B
#7910 ObjectExtractorSimpleBody net472 302ns 0.0322ns 0.121ns 0.0441 0 0 281 B
#7910 ObjectExtractorMoreComplexBody net6.0 6.25μs 31.1ns 139ns 0 0 0 3.78 KB
#7910 ObjectExtractorMoreComplexBody netcoreapp3.1 7.7μs 38.3ns 176ns 0 0 0 3.69 KB
#7910 ObjectExtractorMoreComplexBody net472 6.77μs 2.69ns 10.4ns 0.577 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 77.1μs 41.5ns 155ns 0 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 98.1μs 363ns 1.41μs 0 0 0 32.4 KB
master EncodeArgs net472 109μs 29.9ns 116ns 4.9 0 0 32.5 KB
master EncodeLegacyArgs net6.0 143μs 44ns 171ns 0 0 0 2.14 KB
master EncodeLegacyArgs netcoreapp3.1 197μs 26ns 93.6ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 261μs 18.9ns 73.3ns 0 0 0 2.14 KB
#7910 EncodeArgs net6.0 75.8μs 166ns 642ns 0 0 0 32.4 KB
#7910 EncodeArgs netcoreapp3.1 98μs 268ns 1.04μs 0 0 0 32.4 KB
#7910 EncodeArgs net472 109μs 22.6ns 87.5ns 4.91 0 0 32.5 KB
#7910 EncodeLegacyArgs net6.0 144μs 35.6ns 133ns 0 0 0 2.14 KB
#7910 EncodeLegacyArgs netcoreapp3.1 199μs 214ns 829ns 0 0 0 2.14 KB
#7910 EncodeLegacyArgs net472 264μs 33.8ns 131ns 0 0 0 2.14 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 430μs 1.21μs 4.36μs 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 446μs 1.62μs 6.07μs 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 502μs 453ns 1.63μs 0 0 0 0 b
master RunWafRealisticBenchmarkWithAttack net6.0 320μs 1.08μs 3.9μs 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 350μs 3.6μs 34.4μs 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 378μs 668ns 2.59μs 0 0 0 0 b
#7910 RunWafRealisticBenchmark net6.0 457μs 1.3μs 4.52μs 0 0 0 4.55 KB
#7910 RunWafRealisticBenchmark netcoreapp3.1 457μs 2.48μs 20.6μs 0 0 0 4.48 KB
#7910 RunWafRealisticBenchmark net472 524μs 544ns 1.96μs 0 0 0 0 b
#7910 RunWafRealisticBenchmarkWithAttack net6.0 333μs 862ns 3.11μs 0 0 0 2.24 KB
#7910 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 324μs 1.13μs 4.08μs 0 0 0 2.22 KB
#7910 RunWafRealisticBenchmarkWithAttack net472 393μs 638ns 2.3μs 0 0 0 0 b
Benchmarks.Trace.AspNetCoreBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 84.7μs 221ns 856ns 0 0 0 19.05 KB
master SendRequest netcoreapp3.1 96.7μs 248ns 1.51μs 0 0 0 21.18 KB
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
#7910 SendRequest net6.0 85.2μs 328ns 1.64μs 0 0 0 18.97 KB
#7910 SendRequest netcoreapp3.1 97.2μs 292ns 1.27μs 0 0 0 21.18 KB
#7910 SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master OriginalCharSlice net6.0 1.97ms 1.51μs 5.86μs 0 0 0 640 KB
master OriginalCharSlice netcoreapp3.1 3.95ms 710ns 2.75μs 0 0 0 640.05 KB
master OriginalCharSlice net472 2.64ms 559ns 2.09μs 0 0 0 638.98 KB
master OptimizedCharSlice net6.0 1.44ms 954ns 3.57μs 0 0 0 0 b
master OptimizedCharSlice netcoreapp3.1 2.73ms 914ns 3.42μs 0 0 0 0 b
master OptimizedCharSlice net472 1.96ms 920ns 3.56μs 0 0 0 0 b
master OptimizedCharSliceWithPool net6.0 1.01ms 761ns 2.85μs 0 0 0 0 b
master OptimizedCharSliceWithPool netcoreapp3.1 1.86ms 1.28μs 4.97μs 0 0 0 0 b
master OptimizedCharSliceWithPool net472 1.17ms 576ns 2.23μs 0 0 0 0 b
#7910 OriginalCharSlice net6.0 2.15ms 571ns 2.06μs 0 0 0 640 KB
#7910 OriginalCharSlice netcoreapp3.1 3.98ms 721ns 2.7μs 0 0 0 640.05 KB
#7910 OriginalCharSlice net472 2.61ms 756ns 2.83μs 0 0 0 638.98 KB
#7910 OptimizedCharSlice net6.0 1.51ms 958ns 3.71μs 0 0 0 0 b
#7910 OptimizedCharSlice netcoreapp3.1 2.8ms 756ns 2.83μs 0 0 0 0 b
#7910 OptimizedCharSlice net472 1.95ms 1.02μs 3.96μs 0 0 0 0 b
#7910 OptimizedCharSliceWithPool net6.0 1.07ms 363ns 1.31μs 0 0 0 0 b
#7910 OptimizedCharSliceWithPool netcoreapp3.1 1.85ms 1.41μs 5.07μs 0 0 0 0 b
#7910 OptimizedCharSliceWithPool net472 1.15ms 592ns 2.29μs 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7910

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 42.27 KB 41.86 KB -419 B -0.99%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 709μs 3.12μs 11.2μs 0 0 0 41.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 665μs 3.56μs 18.5μs 0 0 0 42.27 KB
master WriteAndFlushEnrichedTraces net472 963μs 4.58μs 17.7μs 4.46 0 0 55.87 KB
#7910 WriteAndFlushEnrichedTraces net6.0 788μs 2.11μs 8.18μs 0 0 0 41.55 KB
#7910 WriteAndFlushEnrichedTraces netcoreapp3.1 694μs 1.67μs 6.26μs 0 0 0 41.86 KB
#7910 WriteAndFlushEnrichedTraces net472 869μs 2.8μs 10.5μs 8.33 4.17 0 56.08 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.91μs 1.99ns 7.69ns 0 0 0 968 B
master ExecuteNonQuery netcoreapp3.1 2.62μs 8.36ns 32.4ns 0 0 0 960 B
master ExecuteNonQuery net472 2.79μs 4.28ns 16.6ns 0.138 0 0 931 B
#7910 ExecuteNonQuery net6.0 1.86μs 7.74ns 30ns 0 0 0 968 B
#7910 ExecuteNonQuery netcoreapp3.1 2.59μs 7.12ns 27.6ns 0 0 0 960 B
#7910 ExecuteNonQuery net472 2.78μs 4.09ns 15.3ns 0.137 0 0 931 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.67μs 2.1ns 7.85ns 0 0 0 952 B
master CallElasticsearch netcoreapp3.1 2.25μs 6.14ns 23ns 0 0 0 968 B
master CallElasticsearch net472 3.26μs 4ns 15.5ns 0.146 0 0 955 B
master CallElasticsearchAsync net6.0 1.84μs 8.76ns 33.9ns 0 0 0 928 B
master CallElasticsearchAsync netcoreapp3.1 2.46μs 3.28ns 12.7ns 0 0 0 1.02 KB
master CallElasticsearchAsync net472 3.44μs 1.65ns 6.39ns 0.155 0 0 1.01 KB
#7910 CallElasticsearch net6.0 1.76μs 5.89ns 22.8ns 0 0 0 952 B
#7910 CallElasticsearch netcoreapp3.1 2.22μs 10.5ns 41.8ns 0 0 0 968 B
#7910 CallElasticsearch net472 3.24μs 2.88ns 11.2ns 0.146 0 0 955 B
#7910 CallElasticsearchAsync net6.0 1.79μs 2.08ns 8.07ns 0 0 0 928 B
#7910 CallElasticsearchAsync netcoreapp3.1 2.42μs 9.4ns 36.4ns 0 0 0 1.02 KB
#7910 CallElasticsearchAsync net472 3.51μs 3.48ns 13.5ns 0.157 0 0 1.01 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.92μs 0.392ns 1.52ns 0 0 0 896 B
master ExecuteAsync netcoreapp3.1 2.43μs 2.31ns 8.34ns 0 0 0 896 B
master ExecuteAsync net472 2.66μs 2.86ns 11.1ns 0.134 0 0 858 B
#7910 ExecuteAsync net6.0 1.84μs 0.719ns 2.69ns 0 0 0 896 B
#7910 ExecuteAsync netcoreapp3.1 2.41μs 7.24ns 28ns 0 0 0 896 B
#7910 ExecuteAsync net472 2.55μs 2.74ns 10.3ns 0.128 0 0 858 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.91μs 17ns 65.9ns 0 0 0 2.29 KB
master SendAsync netcoreapp3.1 8.45μs 24.5ns 94.9ns 0 0 0 2.83 KB
master SendAsync net472 12.1μs 8.58ns 33.2ns 0.481 0 0 3.08 KB
#7910 SendAsync net6.0 7.24μs 13.3ns 51.7ns 0 0 0 2.29 KB
#7910 SendAsync netcoreapp3.1 8.6μs 15ns 58.1ns 0 0 0 2.83 KB
#7910 SendAsync net472 12μs 3.88ns 15ns 0.477 0 0 3.08 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7910

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 274.06 KB 276.6 KB 2.54 KB 0.93%

Fewer allocations 🎉 in #7910

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 273.49 KB 258.63 KB -14.86 KB -5.43%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 44.5μs 245ns 1.76μs 0 0 0 42.51 KB
master StringConcatBenchmark netcoreapp3.1 48.9μs 258ns 1.26μs 0 0 0 42.54 KB
master StringConcatBenchmark net472 57μs 259ns 1.03μs 0 0 0 49.15 KB
master StringConcatAspectBenchmark net6.0 488μs 2.5μs 11.4μs 0 0 0 274.06 KB
master StringConcatAspectBenchmark netcoreapp3.1 513μs 1.79μs 8.76μs 0 0 0 273.49 KB
master StringConcatAspectBenchmark net472 410μs 2.13μs 12.1μs 0 0 0 270.34 KB
#7910 StringConcatBenchmark net6.0 44.8μs 240ns 1.4μs 0 0 0 42.51 KB
#7910 StringConcatBenchmark netcoreapp3.1 49.5μs 227ns 908ns 0 0 0 42.54 KB
#7910 StringConcatBenchmark net472 57.5μs 214ns 771ns 0 0 0 49.15 KB
#7910 StringConcatAspectBenchmark net6.0 494μs 2.39μs 9.86μs 0 0 0 276.6 KB
#7910 StringConcatAspectBenchmark netcoreapp3.1 459μs 6.34μs 62.8μs 0 0 0 258.63 KB
#7910 StringConcatAspectBenchmark net472 406μs 2.12μs 10.6μs 0 0 0 270.34 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.77μs 14.4ns 52ns 0 0 0 1.69 KB
master EnrichedLog netcoreapp3.1 3.55μs 12.5ns 48.5ns 0 0 0 1.7 KB
master EnrichedLog net472 3.84μs 4.36ns 16.9ns 0.25 0 0 1.6 KB
#7910 EnrichedLog net6.0 2.78μs 1.7ns 6.58ns 0 0 0 1.69 KB
#7910 EnrichedLog netcoreapp3.1 3.5μs 16.8ns 65.2ns 0 0 0 1.7 KB
#7910 EnrichedLog net472 3.84μs 2.43ns 9.4ns 0.25 0 0 1.6 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 124μs 105ns 393ns 0 0 0 4.31 KB
master EnrichedLog netcoreapp3.1 128μs 68.2ns 255ns 0 0 0 4.31 KB
master EnrichedLog net472 169μs 145ns 562ns 0 0 0 4.51 KB
#7910 EnrichedLog net6.0 123μs 67.6ns 234ns 0 0 0 4.31 KB
#7910 EnrichedLog netcoreapp3.1 128μs 221ns 854ns 0 0 0 4.31 KB
#7910 EnrichedLog net472 168μs 156ns 584ns 0 0 0 4.51 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 5.11μs 24.6ns 95.4ns 0 0 0 2.24 KB
master EnrichedLog netcoreapp3.1 6.87μs 24.7ns 95.8ns 0 0 0 2.26 KB
master EnrichedLog net472 7.7μs 6.88ns 26.6ns 0.307 0 0 2.05 KB
#7910 EnrichedLog net6.0 5.18μs 18.8ns 72.8ns 0 0 0 2.24 KB
#7910 EnrichedLog netcoreapp3.1 6.75μs 13.1ns 50.8ns 0 0 0 2.26 KB
#7910 EnrichedLog net472 7.62μs 4.42ns 17.1ns 0.305 0 0 2.05 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.89μs 1.9ns 7.35ns 0 0 0 1.12 KB
master SendReceive netcoreapp3.1 2.43μs 12.8ns 61.3ns 0 0 0 1.14 KB
master SendReceive net472 2.88μs 1.12ns 4.34ns 0.175 0 0 1.12 KB
#7910 SendReceive net6.0 1.92μs 2.26ns 8.46ns 0 0 0 1.12 KB
#7910 SendReceive netcoreapp3.1 2.52μs 10.4ns 40.3ns 0 0 0 1.14 KB
#7910 SendReceive net472 2.94μs 1.22ns 4.73ns 0.174 0 0 1.12 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.39μs 12.2ns 45.7ns 0 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 5.92μs 6.95ns 26.9ns 0 0 0 1.63 KB
master EnrichedLog net472 6.58μs 12.5ns 48.3ns 0.295 0 0 2.03 KB
#7910 EnrichedLog net6.0 4.29μs 1.59ns 5.74ns 0 0 0 1.58 KB
#7910 EnrichedLog netcoreapp3.1 5.77μs 20ns 77.3ns 0 0 0 1.63 KB
#7910 EnrichedLog net472 6.62μs 5.02ns 19.4ns 0.297 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 763ns 1.4ns 5.04ns 0 0 0 520 B
master StartFinishSpan netcoreapp3.1 973ns 4.7ns 19.9ns 0 0 0 520 B
master StartFinishSpan net472 895ns 0.173ns 0.649ns 0.0807 0 0 522 B
master StartFinishScope net6.0 883ns 5ns 33.2ns 0 0 0 640 B
master StartFinishScope netcoreapp3.1 1.14μs 5.44ns 21.7ns 0 0 0 640 B
master StartFinishScope net472 1.14μs 0.341ns 1.27ns 0.0915 0 0 602 B
master StartFinishTwoScopes net6.0 1.86μs 9.03ns 37.2ns 0 0 0 1.19 KB
master StartFinishTwoScopes netcoreapp3.1 2.22μs 11.2ns 47.5ns 0 0 0 1.19 KB
master StartFinishTwoScopes net472 2.29μs 0.469ns 1.82ns 0.16 0 0 1.08 KB
#7910 StartFinishSpan net6.0 804ns 0.316ns 1.18ns 0 0 0 520 B
#7910 StartFinishSpan netcoreapp3.1 979ns 5.21ns 25.5ns 0 0 0 520 B
#7910 StartFinishSpan net472 887ns 0.0388ns 0.14ns 0.0801 0 0 522 B
#7910 StartFinishScope net6.0 920ns 4.33ns 17.3ns 0 0 0 640 B
#7910 StartFinishScope netcoreapp3.1 1.16μs 4.85ns 18.8ns 0 0 0 640 B
#7910 StartFinishScope net472 1.1μs 1.11ns 4.29ns 0.0935 0 0 602 B
#7910 StartFinishTwoScopes net6.0 1.8μs 9.08ns 39.6ns 0 0 0 1.19 KB
#7910 StartFinishTwoScopes netcoreapp3.1 2.31μs 11.7ns 56ns 0 0 0 1.19 KB
#7910 StartFinishTwoScopes net472 2.11μs 0.372ns 1.39ns 0.169 0 0 1.08 KB
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.07μs 5.56ns 24.3ns 0 0 0 640 B
master RunOnMethodBegin netcoreapp3.1 1.4μs 6.44ns 24.1ns 0 0 0 640 B
master RunOnMethodBegin net472 1.42μs 0.403ns 1.51ns 0.0924 0 0 602 B
#7910 RunOnMethodBegin net6.0 1.06μs 5.08ns 19.7ns 0 0 0 640 B
#7910 RunOnMethodBegin netcoreapp3.1 1.39μs 7.17ns 35.8ns 0 0 0 640 B
#7910 RunOnMethodBegin net472 1.44μs 0.184ns 0.711ns 0.094 0 0 602 B

@andrewlock andrewlock merged commit 33eeaad into master Dec 5, 2025
150 checks passed
@andrewlock andrewlock deleted the andrew/fix-pipeline branch December 5, 2025 11:35
@github-actions github-actions bot added this to the vNext-v3 milestone Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonyredondo tonyredondo tonyredondo approved these changes

Assignees

No one assigned

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Milestone

3.33.0

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewlock @tonyredondo