Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (7944) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7944) - mean (76ms) : 69, 82
master - mean (77ms) : 70, 85
section Bailout
This PR (7944) - mean (82ms) : 76, 88
master - mean (80ms) : 72, 87
section CallTarget+Inlining+NGEN
This PR (7944) - mean (1,088ms) : 1021, 1155
master - mean (1,098ms) : 1006, 1189
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7944) - mean (118ms) : 110, 126
master - mean (118ms) : 109, 128
section Bailout
This PR (7944) - mean (121ms) : 112, 129
master - mean (118ms) : 109, 127
section CallTarget+Inlining+NGEN
This PR (7944) - mean (788ms) : 734, 843
master - mean (777ms) : 729, 824
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7944) - mean (106ms) : 99, 114
master - mean (105ms) : 97, 113
section Bailout
This PR (7944) - mean (106ms) : 99, 113
master - mean (106ms) : 100, 113
section CallTarget+Inlining+NGEN
This PR (7944) - mean (722ms) : 687, 758
master - mean (719ms) : 669, 770
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7944) - mean (104ms) : 95, 113
master - mean (105ms) : 97, 112
section Bailout
This PR (7944) - mean (106ms) : 99, 113
master - mean (105ms) : 96, 115
section CallTarget+Inlining+NGEN
This PR (7944) - mean (697ms) : 662, 733
master - mean (684ms) : 642, 726
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7944) - mean (197ms) : 191, 203
master - mean (197ms) : 190, 203
section Bailout
This PR (7944) - mean (200ms) : 196, 205
master - mean (199ms) : 195, 203
section CallTarget+Inlining+NGEN
This PR (7944) - mean (1,129ms) : 1070, 1188
master - mean (1,140ms) : 1067, 1213
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7944) - mean (279ms) : 272, 287
master - mean (284ms) : 275, 293
section Bailout
This PR (7944) - mean (280ms) : 275, 285
master - mean (285ms) : 276, 294
section CallTarget+Inlining+NGEN
This PR (7944) - mean (914ms) : 866, 961
master - mean (922ms) : 868, 977
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7944) - mean (273ms) : 266, 280
master - mean (277ms) : 268, 285
section Bailout
This PR (7944) - mean (273ms) : 266, 281
master - mean (276ms) : 271, 282
section CallTarget+Inlining+NGEN
This PR (7944) - mean (903ms) : 865, 942
master - mean (894ms) : 862, 926
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7944) - mean (273ms) : 266, 279
master - mean (273ms) : 264, 282
section Bailout
This PR (7944) - mean (272ms) : 266, 278
master - mean (272ms) : 266, 278
section CallTarget+Inlining+NGEN
This PR (7944) - mean (836ms) : 811, 861
master - mean (835ms) : 806, 865
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
andrewlock
approved these changes
Dec 10, 2025
Member
andrewlock
left a comment
andrewlock
left a comment
There was a problem hiding this comment.
Nice! Did you try with the 10.0 GA version of system.text.json btw?
Contributor
Author
yes I tried with 10+ versions and it started working only from under 9... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Due to this Rider issue , the IDE doesn't index source generated files using the last version of the package properly which considerably degrades the dev experience. And following the merge of this PR, we now have the issue:
It still builds but Rider doesn't see the generated sources and generates errors and doesn't autocompletes or index anything.
Reason for change
Downgrade the package version to fix the dev experience.
Implementation details
Test coverage
Other details