Fix sealed analyzer, and fix regressions#7973
Merged
andrewlock merged 2 commits intomasterfrom Dec 18, 2025
Merged
Conversation
andrewlock
added
the
area:builds
bouwkast
approved these changes
Dec 18, 2025
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (7973) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7973) - mean (68ms) : 67, 70
master - mean (74ms) : 71, 76
section Bailout
This PR (7973) - mean (72ms) : 71, 73
master - mean (77ms) : 76, 79
section CallTarget+Inlining+NGEN
This PR (7973) - mean (1,010ms) : 962, 1058
master - mean (1,057ms) : 976, 1138
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7973) - mean (106ms) : 103, 108
master - mean (113ms) : 110, 116
section Bailout
This PR (7973) - mean (106ms) : 105, 108
master - mean (115ms) : 112, 118
section CallTarget+Inlining+NGEN
This PR (7973) - mean (710ms) : 683, 737
master - mean (745ms) : 710, 780
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7973) - mean (93ms) : 91, 95
master - mean (101ms) : 98, 104
section Bailout
This PR (7973) - mean (94ms) : 93, 95
master - mean (102ms) : 100, 104
section CallTarget+Inlining+NGEN
This PR (7973) - mean (670ms) : 651, 688
master - mean (691ms) : 667, 715
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7973) - mean (92ms) : 90, 94
master - mean (100ms) : 97, 103
section Bailout
This PR (7973) - mean (93ms) : 92, 94
master - mean (101ms) : 99, 103
section CallTarget+Inlining+NGEN
This PR (7973) - mean (630ms) : 615, 646
master - mean (660ms) : 636, 683
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7973) - mean (194ms) : 191, 198
master - mean (193ms) : 190, 197
section Bailout
This PR (7973) - mean (198ms) : 195, 202
master - mean (198ms) : 195, 200
section CallTarget+Inlining+NGEN
This PR (7973) - mean (1,145ms) : 1027, 1264
master - mean (1,116ms) : 1058, 1174
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7973) - mean (279ms) : 272, 285
master - mean (277ms) : 272, 281
section Bailout
This PR (7973) - mean (281ms) : 273, 288
master - mean (277ms) : 273, 282
section CallTarget+Inlining+NGEN
This PR (7973) - mean (917ms) : 866, 967
master - mean (905ms) : 866, 945
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7973) - mean (271ms) : 265, 278
master - mean (271ms) : 265, 276
section Bailout
This PR (7973) - mean (271ms) : 266, 275
master - mean (270ms) : 265, 275
section CallTarget+Inlining+NGEN
This PR (7973) - mean (894ms) : 839, 948
master - mean (888ms) : 847, 928
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7973) - mean (270ms) : 264, 276
master - mean (270ms) : 260, 280
section Bailout
This PR (7973) - mean (270ms) : 266, 274
master - mean (268ms) : 264, 272
section CallTarget+Inlining+NGEN
This PR (7973) - mean (828ms) : 806, 849
master - mean (819ms) : 797, 842
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fix the sealed analyzer so that it applies correctly, and fix regressions
Reason for change
We added a sealed analyzer, and tried to enable it by default for all types, but made a typo.
Implementation details
Test coverage
If it builds, we're ok
Other details
Removed an unused log object while I was at it