Skip to content

Bump memory limit slightly#7977

Merged
andrewlock merged 1 commit intomasterfrom
andrew/raise-memory-limits
Dec 19, 2025
Merged

Bump memory limit slightly#7977
andrewlock merged 1 commit intomasterfrom
andrew/raise-memory-limits

Conversation

@andrewlock
Copy link
Member

Summary of changes

Bumps the memory limit to 10GB instead of 8GB

Reason for change

We were getting OOM

Implementation details

Bump the number

Test coverage

This is the test

@andrewlock andrewlock requested a review from a team as a code owner December 19, 2025 09:58
@andrewlock andrewlock added area:builds project files, build scripts, pipelines, versioning, releases, packages type:flake-fix labels Dec 19, 2025
@andrewlock andrewlock enabled auto-merge (squash) December 19, 2025 09:59
@pr-commenter
Copy link

pr-commenter bot commented Dec 19, 2025

Benchmarks

Benchmark execution time: 2025-12-19 10:54:18

Comparing candidate commit c6cad40 in PR branch andrew/raise-memory-limits with baseline commit f699e67 in branch master.

Found 8 performance improvements and 3 performance regressions! Performance is the same for 161 metrics, 14 unstable metrics.

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • 🟩 execution_time [-117.756ms; -113.828ms] or [-56.757%; -54.864%]
  • 🟩 throughput [+4499.445op/s; +6285.922op/s] or [+6.728%; +9.399%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟩 execution_time [-18.634ms; -12.763ms] or [-8.719%; -5.972%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • 🟥 execution_time [+16.015ms; +21.529ms] or [+8.193%; +11.013%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟥 execution_time [+22.634ms; +27.034ms] or [+11.658%; +13.925%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • 🟩 execution_time [-101.982ms; -100.185ms] or [-51.162%; -50.261%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0

  • 🟩 execution_time [-88.383µs; -82.884µs] or [-7.915%; -7.423%]
  • 🟩 throughput [+72.052op/s; +76.698op/s] or [+8.046%; +8.564%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • 🟩 throughput [+24300.713op/s; +33685.356op/s] or [+5.846%; +8.104%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟩 execution_time [-37.658ms; -36.184ms] or [-18.681%; -17.950%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • 🟥 execution_time [+17.574ms; +23.052ms] or [+8.908%; +11.685%]

@dd-trace-dotnet-ci-bot
Copy link

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (7977) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration68.17 ± (68.15 - 68.35) ms68.22 ± (68.25 - 68.48) ms+0.1%✅⬆️
.NET Framework 4.8 - Bailout
duration72.02 ± (71.97 - 72.22) ms72.24 ± (72.14 - 72.38) ms+0.3%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1001.86 ± (1006.66 - 1014.55) ms1001.96 ± (1002.65 - 1007.84) ms+0.0%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms22.00 ± (21.98 - 22.03) ms21.93 ± (21.91 - 21.96) ms-0.3%
process.time_to_main_ms78.62 ± (78.47 - 78.77) ms78.93 ± (78.79 - 79.08) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.89 ± (10.89 - 10.90) MB10.92 ± (10.92 - 10.93) MB+0.3%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%
.NET Core 3.1 - Bailout
process.internal_duration_ms21.96 ± (21.93 - 21.98) ms21.90 ± (21.87 - 21.92) ms-0.3%
process.time_to_main_ms79.73 ± (79.61 - 79.85) ms79.77 ± (79.69 - 79.86) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.93 ± (10.93 - 10.94) MB10.96 ± (10.96 - 10.97) MB+0.3%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms210.04 ± (208.77 - 211.30) ms211.43 ± (210.22 - 212.63) ms+0.7%✅⬆️
process.time_to_main_ms471.68 ± (471.18 - 472.18) ms472.56 ± (471.96 - 473.15) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed48.04 ± (48.02 - 48.06) MB48.20 ± (48.18 - 48.22) MB+0.3%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%
.NET 6 - Baseline
process.internal_duration_ms20.59 ± (20.57 - 20.62) ms20.69 ± (20.66 - 20.71) ms+0.4%✅⬆️
process.time_to_main_ms67.81 ± (67.70 - 67.93) ms68.07 ± (67.98 - 68.17) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.60 ± (10.60 - 10.61) MB10.64 ± (10.64 - 10.64) MB+0.3%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%
.NET 6 - Bailout
process.internal_duration_ms20.48 ± (20.45 - 20.50) ms20.67 ± (20.65 - 20.70) ms+1.0%✅⬆️
process.time_to_main_ms68.65 ± (68.59 - 68.70) ms69.13 ± (69.06 - 69.20) ms+0.7%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.66 ± (10.66 - 10.66) MB10.68 ± (10.68 - 10.69) MB+0.2%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms198.60 ± (197.44 - 199.76) ms199.33 ± (198.29 - 200.36) ms+0.4%✅⬆️
process.time_to_main_ms437.36 ± (436.86 - 437.87) ms438.58 ± (438.05 - 439.11) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed48.08 ± (48.01 - 48.16) MB48.33 ± (48.26 - 48.39) MB+0.5%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.1%
.NET 8 - Baseline
process.internal_duration_ms18.77 ± (18.74 - 18.79) ms18.89 ± (18.86 - 18.91) ms+0.6%✅⬆️
process.time_to_main_ms66.90 ± (66.81 - 66.99) ms67.23 ± (67.13 - 67.34) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed7.67 ± (7.67 - 7.68) MB7.70 ± (7.69 - 7.71) MB+0.3%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%
.NET 8 - Bailout
process.internal_duration_ms18.88 ± (18.86 - 18.90) ms18.77 ± (18.74 - 18.79) ms-0.6%
process.time_to_main_ms68.09 ± (68.03 - 68.15) ms68.08 ± (68.01 - 68.14) ms-0.0%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed7.71 ± (7.71 - 7.72) MB7.76 ± (7.74 - 7.77) MB+0.6%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms178.82 ± (177.87 - 179.78) ms179.88 ± (178.88 - 180.87) ms+0.6%✅⬆️
process.time_to_main_ms422.74 ± (422.27 - 423.22) ms424.11 ± (423.51 - 424.71) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed36.26 ± (36.23 - 36.29) MB36.32 ± (36.29 - 36.36) MB+0.2%✅⬆️
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)-0.0%

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration192.36 ± (192.34 - 193.29) ms193.32 ± (193.15 - 193.91) ms+0.5%✅⬆️
.NET Framework 4.8 - Bailout
duration196.81 ± (196.46 - 197.05) ms196.87 ± (196.55 - 197.11) ms+0.0%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1103.41 ± (1104.69 - 1111.55) ms1111.87 ± (1112.93 - 1121.17) ms+0.8%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms187.98 ± (187.60 - 188.35) ms188.54 ± (188.11 - 188.98) ms+0.3%✅⬆️
process.time_to_main_ms80.31 ± (80.14 - 80.49) ms81.19 ± (80.96 - 81.41) ms+1.1%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed16.06 ± (16.04 - 16.09) MB16.17 ± (16.14 - 16.20) MB+0.7%✅⬆️
runtime.dotnet.threads.count20 ± (19 - 20)20 ± (20 - 20)+0.6%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms187.24 ± (186.86 - 187.62) ms187.14 ± (186.77 - 187.51) ms-0.1%
process.time_to_main_ms81.87 ± (81.71 - 82.03) ms81.91 ± (81.79 - 82.04) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed16.13 ± (16.09 - 16.16) MB16.13 ± (16.10 - 16.16) MB-0.0%
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (21 - 21)-0.1%
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms397.20 ± (394.79 - 399.61) ms394.53 ± (392.02 - 397.03) ms-0.7%
process.time_to_main_ms473.69 ± (472.99 - 474.38) ms474.08 ± (473.48 - 474.67) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed58.56 ± (58.42 - 58.71) MB58.23 ± (58.08 - 58.39) MB-0.6%
runtime.dotnet.threads.count29 ± (29 - 30)29 ± (29 - 29)-0.0%
.NET 6 - Baseline
process.internal_duration_ms191.89 ± (191.53 - 192.25) ms193.23 ± (192.78 - 193.69) ms+0.7%✅⬆️
process.time_to_main_ms69.70 ± (69.53 - 69.87) ms70.14 ± (69.95 - 70.33) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed16.19 ± (16.07 - 16.31) MB16.12 ± (16.01 - 16.23) MB-0.4%
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)-0.3%
.NET 6 - Bailout
process.internal_duration_ms191.32 ± (191.02 - 191.62) ms190.93 ± (190.63 - 191.22) ms-0.2%
process.time_to_main_ms70.63 ± (70.53 - 70.74) ms70.73 ± (70.64 - 70.81) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed16.19 ± (16.06 - 16.33) MB16.24 ± (16.11 - 16.38) MB+0.3%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 20)20 ± (19 - 20)+1.6%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms411.16 ± (408.65 - 413.67) ms408.39 ± (406.04 - 410.73) ms-0.7%
process.time_to_main_ms443.94 ± (443.38 - 444.49) ms444.63 ± (444.06 - 445.20) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed58.95 ± (58.80 - 59.09) MB58.93 ± (58.78 - 59.07) MB-0.0%
runtime.dotnet.threads.count30 ± (29 - 30)30 ± (30 - 30)+0.2%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms189.81 ± (189.52 - 190.09) ms190.02 ± (189.74 - 190.30) ms+0.1%✅⬆️
process.time_to_main_ms69.13 ± (68.98 - 69.29) ms69.71 ± (69.53 - 69.88) ms+0.8%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed11.85 ± (11.81 - 11.89) MB11.75 ± (11.72 - 11.77) MB-0.9%
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)-0.2%
.NET 8 - Bailout
process.internal_duration_ms189.19 ± (188.95 - 189.42) ms189.22 ± (188.96 - 189.48) ms+0.0%✅⬆️
process.time_to_main_ms70.28 ± (70.19 - 70.37) ms70.43 ± (70.32 - 70.54) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed11.70 ± (11.61 - 11.79) MB11.83 ± (11.80 - 11.86) MB+1.1%✅⬆️
runtime.dotnet.threads.count19 ± (18 - 19)19 ± (19 - 19)+2.8%✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms365.07 ± (363.33 - 366.80) ms364.83 ± (362.94 - 366.71) ms-0.1%
process.time_to_main_ms428.81 ± (428.16 - 429.46) ms427.84 ± (427.20 - 428.47) ms-0.2%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed47.93 ± (47.91 - 47.96) MB47.97 ± (47.93 - 48.00) MB+0.1%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.2%
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8)
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7977) - mean (68ms)  : 67, 70
    master - mean (68ms)  : 67, 70

    section Bailout
    This PR (7977) - mean (72ms)  : 71, 73
    master - mean (72ms)  : 71, 73

    section CallTarget+Inlining+NGEN
    This PR (7977) - mean (1,005ms)  : 968, 1042
    master - mean (1,011ms)  : 953, 1069

Loading
FakeDbCommand (.NET Core 3.1)
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7977) - mean (106ms)  : 104, 108
    master - mean (106ms)  : 103, 109

    section Bailout
    This PR (7977) - mean (107ms)  : 105, 108
    master - mean (107ms)  : 105, 108

    section CallTarget+Inlining+NGEN
    This PR (7977) - mean (710ms)  : 687, 733
    master - mean (708ms)  : 685, 732

Loading
FakeDbCommand (.NET 6)
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7977) - mean (94ms)  : 92, 95
    master - mean (93ms)  : 91, 95

    section Bailout
    This PR (7977) - mean (95ms)  : 93, 96
    master - mean (94ms)  : 93, 95

    section CallTarget+Inlining+NGEN
    This PR (7977) - mean (666ms)  : 645, 687
    master - mean (662ms)  : 639, 685

Loading
FakeDbCommand (.NET 8)
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7977) - mean (92ms)  : 90, 94
    master - mean (92ms)  : 89, 94

    section Bailout
    This PR (7977) - mean (93ms)  : 92, 94
    master - mean (93ms)  : 92, 94

    section CallTarget+Inlining+NGEN
    This PR (7977) - mean (631ms)  : 617, 645
    master - mean (628ms)  : 614, 643

Loading
HttpMessageHandler (.NET Framework 4.8)
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7977) - mean (194ms)  : 190, 197
    master - mean (193ms)  : 188, 198

    section Bailout
    This PR (7977) - mean (197ms)  : 194, 199
    master - mean (197ms)  : 194, 200

    section CallTarget+Inlining+NGEN
    This PR (7977) - mean (1,117ms)  : 1056, 1178
    master - mean (1,108ms)  : 1059, 1157

Loading
HttpMessageHandler (.NET Core 3.1)
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7977) - mean (278ms)  : 271, 285
    master - mean (277ms)  : 272, 283

    section Bailout
    This PR (7977) - mean (277ms)  : 273, 281
    master - mean (277ms)  : 273, 281

    section CallTarget+Inlining+NGEN
    This PR (7977) - mean (905ms)  : 858, 951
    master - mean (901ms)  : 862, 940

Loading
HttpMessageHandler (.NET 6)
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7977) - mean (271ms)  : 264, 278
    master - mean (270ms)  : 266, 274

    section Bailout
    This PR (7977) - mean (270ms)  : 266, 274
    master - mean (270ms)  : 266, 274

    section CallTarget+Inlining+NGEN
    This PR (7977) - mean (888ms)  : 847, 928
    master - mean (886ms)  : 847, 925

Loading
HttpMessageHandler (.NET 8)
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7977) - mean (269ms)  : 265, 274
    master - mean (269ms)  : 265, 273

    section Bailout
    This PR (7977) - mean (269ms)  : 266, 272
    master - mean (269ms)  : 266, 272

    section CallTarget+Inlining+NGEN
    This PR (7977) - mean (825ms)  : 805, 845
    master - mean (824ms)  : 804, 844

Loading

@andrewlock andrewlock merged commit 6ca218c into master Dec 19, 2025
151 of 152 checks passed
@andrewlock andrewlock deleted the andrew/raise-memory-limits branch December 19, 2025 12:08
@github-actions github-actions bot added this to the vNext-v3 milestone Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages type:flake-fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants