Conversation
andrewlock
added
area:builds
This comment has been minimized.
This comment has been minimized.
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8056) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8056) - mean (68ms) : 67, 70
master - mean (68ms) : 67, 70
section Bailout
This PR (8056) - mean (72ms) : 71, 73
master - mean (72ms) : 71, 73
section CallTarget+Inlining+NGEN
This PR (8056) - mean (1,013ms) : 944, 1082
master - mean (1,010ms) : 934, 1086
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8056) - mean (106ms) : 104, 108
master - mean (105ms) : 103, 108
section Bailout
This PR (8056) - mean (107ms) : 106, 108
master - mean (106ms) : 105, 107
section CallTarget+Inlining+NGEN
This PR (8056) - mean (737ms) : 681, 794
master - mean (743ms) : 693, 794
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8056) - mean (94ms) : 91, 96
master - mean (94ms) : 91, 96
section Bailout
This PR (8056) - mean (94ms) : 93, 95
master - mean (94ms) : 93, 95
section CallTarget+Inlining+NGEN
This PR (8056) - mean (716ms) : 686, 745
master - mean (721ms) : 701, 741
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8056) - mean (92ms) : 90, 94
master - mean (92ms) : 89, 94
section Bailout
This PR (8056) - mean (93ms) : 92, 95
master - mean (93ms) : 91, 94
section CallTarget+Inlining+NGEN
This PR (8056) - mean (635ms) : 622, 649
master - mean (633ms) : 615, 651
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8056) - mean (193ms) : 188, 197
master - mean (194ms) : 190, 197
section Bailout
This PR (8056) - mean (196ms) : 192, 201
master - mean (197ms) : 194, 200
section CallTarget+Inlining+NGEN
This PR (8056) - mean (1,136ms) : 1060, 1212
master - mean (1,126ms) : 1061, 1190
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8056) - mean (277ms) : 272, 283
master - mean (277ms) : 272, 281
section Bailout
This PR (8056) - mean (278ms) : 272, 283
master - mean (277ms) : 272, 283
section CallTarget+Inlining+NGEN
This PR (8056) - mean (935ms) : 890, 981
master - mean (927ms) : 873, 981
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8056) - mean (271ms) : 266, 276
master - mean (270ms) : 265, 275
section Bailout
This PR (8056) - mean (272ms) : 266, 277
master - mean (270ms) : 266, 274
section CallTarget+Inlining+NGEN
This PR (8056) - mean (919ms) : 861, 977
master - mean (914ms) : 852, 976
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8056) - mean (269ms) : 264, 274
master - mean (268ms) : 263, 273
section Bailout
This PR (8056) - mean (269ms) : 263, 275
master - mean (268ms) : 265, 272
section CallTarget+Inlining+NGEN
This PR (8056) - mean (833ms) : 805, 861
master - mean (827ms) : 805, 848
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-01-14 10:09:21 Comparing candidate commit 5a01ef3 in PR branch Some scenarios are present only in baseline or only in candidate runs. If you didn't create or remove some scenarios in your branch, this maybe a sign of crashed benchmarks 💥💥💥 Scenarios present only in candidate:
Found 7 performance improvements and 1 performance regressions! Performance is the same for 53 metrics, 3 unstable metrics. scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0
scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0
scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0
scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes the broken build in the benchmarks
Reason for change
#7965 broke the benchmark build for some TFMs. I think the race condition between creating a PR and running the benchmarks meant we didn't notice the failure, especially because the run still took 30+ mins because it worked in some TFMs
Implementation details
Test coverage
This is the test, I'll carefully check the run this time