[FFE] Cache the condition regexes#8087
Merged
daniel-romano-DD merged 1 commit intomasterfrom Jan 22, 2026
Merged
Conversation
github-actions
bot
added
the
area:tracer
BenchmarksBenchmark execution time: 2026-01-22 09:15:04 Comparing candidate commit 0cc488d in PR branch Found 4 performance improvements and 14 performance regressions! Performance is the same for 158 metrics, 16 unstable metrics. scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync net472
scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0
scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8087) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8087) - mean (68ms) : 67, 70
master - mean (69ms) : 67, 71
section Bailout
This PR (8087) - mean (72ms) : 71, 73
master - mean (72ms) : 71, 74
section CallTarget+Inlining+NGEN
This PR (8087) - mean (1,024ms) : 935, 1113
master - mean (1,017ms) : 936, 1098
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8087) - mean (106ms) : 104, 109
master - mean (106ms) : 104, 109
section Bailout
This PR (8087) - mean (107ms) : 106, 108
master - mean (107ms) : 105, 109
section CallTarget+Inlining+NGEN
This PR (8087) - mean (740ms) : 684, 796
master - mean (736ms) : 683, 788
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8087) - mean (94ms) : 91, 96
master - mean (94ms) : 92, 96
section Bailout
This PR (8087) - mean (95ms) : 94, 96
master - mean (94ms) : 94, 95
section CallTarget+Inlining+NGEN
This PR (8087) - mean (719ms) : 692, 747
master - mean (717ms) : 681, 754
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8087) - mean (92ms) : 91, 94
master - mean (92ms) : 90, 95
section Bailout
This PR (8087) - mean (93ms) : 92, 95
master - mean (93ms) : 92, 94
section CallTarget+Inlining+NGEN
This PR (8087) - mean (636ms) : 622, 651
master - mean (635ms) : 621, 650
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8087) - mean (197ms) : 191, 203
master - mean (205ms) : 178, 232
section Bailout
This PR (8087) - mean (198ms) : 194, 201
master - mean (198ms) : 196, 201
section CallTarget+Inlining+NGEN
This PR (8087) - mean (1,132ms) : 1077, 1187
master - mean (1,136ms) : 1064, 1209
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8087) - mean (277ms) : 271, 284
master - mean (277ms) : 271, 284
section Bailout
This PR (8087) - mean (278ms) : 275, 281
master - mean (278ms) : 272, 284
section CallTarget+Inlining+NGEN
This PR (8087) - mean (939ms) : 898, 979
master - mean (937ms) : 899, 974
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8087) - mean (272ms) : 267, 276
master - mean (272ms) : 263, 280
section Bailout
This PR (8087) - mean (271ms) : 266, 275
master - mean (271ms) : 267, 275
section CallTarget+Inlining+NGEN
This PR (8087) - mean (924ms) : 869, 978
master - mean (929ms) : 883, 975
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8087) - mean (270ms) : 264, 275
master - mean (270ms) : 265, 274
section Bailout
This PR (8087) - mean (271ms) : 266, 275
master - mean (271ms) : 265, 276
section CallTarget+Inlining+NGEN
This PR (8087) - mean (836ms) : 814, 859
master - mean (831ms) : 810, 852
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d0411179b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
tracer/src/Datadog.Trace/FeatureFlags/Rcm/Model/ConditionConfiguration.cs
Show resolved
Hide resolved
daniel-romano-DD
force-pushed
the
dani/ffe/cache_regexes
branch
from
5d04111 to
0cc488d
Compare
e-n-0
approved these changes
Jan 22, 2026
lucaspimentel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Cache condition regexes so they can be reused
Reason for change
Implementation details
Test coverage
Other details