Proposal for checking instrumentation/framework versions#19
Merged
Conversation
Add thread name and id to each span as additional tags.
Contributor
Author
|
@tylerbenson It's working :) but could you give me your feedback. I'm not very confident using static methods |
tylerbenson
reviewed
Jun 26, 2017
Contributor
tylerbenson
left a comment
tylerbenson
left a comment
There was a problem hiding this comment.
I think this PR would have been nicer if the version checking was separated from the JMS support.
tylerbenson
reviewed
Jun 26, 2017
| # Instrument Elasticsearch Transport Client | ||
| # ========================================== | ||
| RULE elasticsearch | ||
| RULE opentracing-elasticsearch-client |
Contributor
There was a problem hiding this comment.
Since these names are used in the config to allow customers to disable instrumentation, I think it would be good to document the list of names, or update the documentation to explain how to find the name needed.
tylerbenson
approved these changes
Jun 26, 2017
Contributor
tylerbenson
left a comment
tylerbenson
left a comment
There was a problem hiding this comment.
Looks like this diff is mostly confusing because of the differences with the branch it was based on. It might be cleaned up with rebasing, but no big deal.
This was referenced Jan 23, 2025
This was referenced Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.