Add deeper tests for DDApi using ratpack as a mock http server.#31
Add deeper tests for DDApi using ratpack as a mock http server.#31tylerbenson merged 1 commit intomasterfrom
Conversation
See https://danhyun.github.io/2016-gr8confus-testing-ratpack-apps/ for more examples with this style of testing.
gpolaert
left a comment
There was a problem hiding this comment.
Tests are fine.
Just question about groovy tests, Should we use groovy?
My concerns are about mixing syntaxes, learning curve and maintenance in the long term.
I think we have to be sure using groove is a huge plus for the project. Otherwise, I think we should have keep only one syntax.
It's just my opinion. Tyler, you will(are ;) ) the lead, so it's your call.
| import com.datadoghq.trace.DDSpan | ||
| import com.datadoghq.trace.DDSpanContext | ||
|
|
||
| class SpanFactory { |
There was a problem hiding this comment.
Definitively a great idea :)
|
I totally understand where you're coming from because a year ago I expressed similar opinions to a coworker who was trying to introduce Spock on a project. Eventually I tried it on a project and became a big convert. I find Spock tests to be much more readable and concise. It is also nice using Groovy as it removes a lot of the verbosity usually required by Java. Normally I wouldn't try and push something like this mid way through a project, but we can migrate slowly and the project is still very young. |
See https://danhyun.github.io/2016-gr8confus-testing-ratpack-apps/ for more examples with this style of testing.
For more details about spock, see here: http://spockframework.org/spock/docs/1.0/spock_primer.html