Don't redact env tokens from debugger probe snapshots#8211

watson · 2025-01-15T14:49:46Z

What Does This Do

Remove env from list of tokens to redact from Dynamic Instrumentation probe snapshots.

Depends on: DataDog/system-tests#3827

Motivation

Feature parity

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

github-actions · 2025-01-15T14:50:01Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Remove the tag from the pull request title

If you need help, please check our contributing guidelines.

pr-commenter · 2025-01-15T15:09:48Z

Debugger benchmarks

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
ci_job_date	1736972575	1736972945
end_time	2025-01-15T20:24:12	2025-01-15T20:30:22
git_branch	master	watson/env-redaction
git_commit_sha	`0b1e6ff`	`787e049`
start_time	2025-01-15T20:22:56	2025-01-15T20:29:06

See matching parameters

	Baseline	Candidate
ci_job_id	768063046	768063046
ci_pipeline_id	53123691	53123691
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date	1736971899	1736971899

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 7 unstable metrics.

See unchanged results

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:noprobe	unstable [-65.227µs; +37.444µs] or [-22.574%; +12.958%]	unstable [-78.613µs; +50.748µs] or [-23.842%; +15.391%]	unstable [-97.684µs; +63.166µs] or [-28.022%; +18.120%]	unstable [-1095.444µs; +405.873µs] or [-117.032%; +43.362%]	same
scenario:basic	same	same	unstable [-17101.022ns; +18150.598ns] or [-5.367%; +5.696%]	unstable [-181.671µs; +98.946µs] or [-31.756%; +17.296%]	unstable [-254.644op/s; +126.438op/s] or [-9.931%; +4.931%]
scenario:loop	unsure [+3.538µs; +38.152µs] or [+0.036%; +0.387%]	same	same	same	same

Request duration reports for reports

gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (329.722 µs) : 252, 407
.   : milestone, 330,
basic (307.259 µs) : 292, 323
.   : milestone, 307,
loop (10.007 ms) : 9967, 10047
.   : milestone, 10007,
section candidate
noprobe (315.789 µs) : 276, 356
.   : milestone, 316,
basic (308.703 µs) : 300, 317
.   : milestone, 309,
loop (10.031 ms) : 9999, 10063
.   : milestone, 10031,

baseline results

Scenario	Request median duration [CI 0.99]
noprobe	329.722 µs [252.231 µs, 407.212 µs]
basic	307.259 µs [291.837 µs, 322.681 µs]
loop	10.007 ms [9.967 ms, 10.047 ms]

candidate results

Scenario	Request median duration [CI 0.99]
noprobe	315.789 µs [275.821 µs, 355.757 µs]
basic	308.703 µs [300.072 µs, 317.334 µs]
loop	10.031 ms [9.999 ms, 10.063 ms]

pr-commenter · 2025-01-15T15:27:28Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	watson/env-redaction
git_commit_date	1736952276	1736971899
git_commit_sha	`0b1e6ff`	`787e049`
release_version	1.46.0-SNAPSHOT~0b1e6ff859	1.46.0-SNAPSHOT~787e049d1a

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1736974322	1736974322
ci_job_id	768063040	768063040
ci_pipeline_id	53123691	53123691
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~787e049d1a, baseline=1.46.0-SNAPSHOT~0b1e6ff859

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062751
Total [baseline] (8.625 s) : 0, 8624627
Agent [candidate] (1.061 s) : 0, 1060714
Total [candidate] (8.603 s) : 0, 8602897
section iast
Agent [baseline] (1.182 s) : 0, 1181558
Total [baseline] (9.159 s) : 0, 9159241
Agent [candidate] (1.189 s) : 0, 1188696
Total [candidate] (9.286 s) : 0, 9286084
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.181 s) : 0, 1181367
Total [baseline] (9.172 s) : 0, 9172081
Agent [candidate] (1.19 s) : 0, 1190469
Total [candidate] (9.23 s) : 0, 9229961
section iast_TELEMETRY_OFF
Agent [baseline] (1.176 s) : 0, 1176209
Total [baseline] (9.186 s) : 0, 9186016
Agent [candidate] (1.177 s) : 0, 1176812
Total [candidate] (9.185 s) : 0, 9185287

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.063 s	-
Agent	iast	1.182 s	118.807 ms (11.2%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.181 s	118.616 ms (11.2%)
Agent	iast_TELEMETRY_OFF	1.176 s	113.458 ms (10.7%)
Total	tracing	8.625 s	-
Total	iast	9.159 s	534.615 ms (6.2%)
Total	iast_HARDCODED_SECRET_DISABLED	9.172 s	547.455 ms (6.3%)
Total	iast_TELEMETRY_OFF	9.186 s	561.389 ms (6.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.061 s	-
Agent	iast	1.189 s	127.981 ms (12.1%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.19 s	129.754 ms (12.2%)
Agent	iast_TELEMETRY_OFF	1.177 s	116.098 ms (10.9%)
Total	tracing	8.603 s	-
Total	iast	9.286 s	683.187 ms (7.9%)
Total	iast_HARDCODED_SECRET_DISABLED	9.23 s	627.064 ms (7.3%)
Total	iast_TELEMETRY_OFF	9.185 s	582.389 ms (6.8%)

gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~787e049d1a, baseline=1.46.0-SNAPSHOT~0b1e6ff859

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.998 ms) : 0, 718998
BytebuddyAgent [candidate] (716.607 ms) : 0, 716607
GlobalTracer [baseline] (257.197 ms) : 0, 257197
GlobalTracer [candidate] (256.302 ms) : 0, 256302
AppSec [baseline] (55.725 ms) : 0, 55725
AppSec [candidate] (56.823 ms) : 0, 56823
Remote Config [baseline] (732.675 µs) : 0, 733
Remote Config [candidate] (726.684 µs) : 0, 727
Telemetry [baseline] (15.032 ms) : 0, 15032
Telemetry [candidate] (15.113 ms) : 0, 15113
section iast
BytebuddyAgent [baseline] (831.373 ms) : 0, 831373
BytebuddyAgent [candidate] (834.334 ms) : 0, 834334
GlobalTracer [baseline] (246.553 ms) : 0, 246553
GlobalTracer [candidate] (249.715 ms) : 0, 249715
AppSec [baseline] (57.666 ms) : 0, 57666
AppSec [candidate] (58.271 ms) : 0, 58271
Remote Config [baseline] (662.874 µs) : 0, 663
Remote Config [candidate] (691.593 µs) : 0, 692
Telemetry [baseline] (8.733 ms) : 0, 8733
Telemetry [candidate] (8.86 ms) : 0, 8860
IAST [baseline] (21.611 ms) : 0, 21611
IAST [candidate] (21.76 ms) : 0, 21760
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (830.865 ms) : 0, 830865
BytebuddyAgent [candidate] (837.402 ms) : 0, 837402
GlobalTracer [baseline] (246.367 ms) : 0, 246367
GlobalTracer [candidate] (248.211 ms) : 0, 248211
AppSec [baseline] (58.176 ms) : 0, 58176
AppSec [candidate] (58.406 ms) : 0, 58406
Remote Config [baseline] (677.8 µs) : 0, 678
Remote Config [candidate] (686.509 µs) : 0, 687
Telemetry [baseline] (8.773 ms) : 0, 8773
Telemetry [candidate] (8.941 ms) : 0, 8941
IAST [baseline] (21.549 ms) : 0, 21549
IAST [candidate] (21.695 ms) : 0, 21695
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (827.489 ms) : 0, 827489
BytebuddyAgent [candidate] (827.579 ms) : 0, 827579
GlobalTracer [baseline] (245.869 ms) : 0, 245869
GlobalTracer [candidate] (246.187 ms) : 0, 246187
AppSec [baseline] (57.689 ms) : 0, 57689
AppSec [candidate] (57.718 ms) : 0, 57718
Remote Config [baseline] (657.919 µs) : 0, 658
Remote Config [candidate] (671.238 µs) : 0, 671
Telemetry [baseline] (8.653 ms) : 0, 8653
Telemetry [candidate] (8.655 ms) : 0, 8655
IAST [baseline] (20.881 ms) : 0, 20881
IAST [candidate] (21.024 ms) : 0, 21024

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~787e049d1a, baseline=1.46.0-SNAPSHOT~0b1e6ff859

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1051631
Total [baseline] (10.574 s) : 0, 10573803
Agent [candidate] (1.068 s) : 0, 1068203
Total [candidate] (10.46 s) : 0, 10460124
section appsec
Agent [baseline] (1.197 s) : 0, 1197218
Total [baseline] (10.696 s) : 0, 10695769
Agent [candidate] (1.196 s) : 0, 1195815
Total [candidate] (10.729 s) : 0, 10729256
section iast
Agent [baseline] (1.181 s) : 0, 1180859
Total [baseline] (10.933 s) : 0, 10933403
Agent [candidate] (1.18 s) : 0, 1180387
Total [candidate] (10.963 s) : 0, 10962837
section profiling
Agent [baseline] (1.256 s) : 0, 1255701
Total [baseline] (10.764 s) : 0, 10763645
Agent [candidate] (1.258 s) : 0, 1257918
Total [candidate] (10.808 s) : 0, 10807988

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.052 s	-
Agent	appsec	1.197 s	145.587 ms (13.8%)
Agent	iast	1.181 s	129.228 ms (12.3%)
Agent	profiling	1.256 s	204.069 ms (19.4%)
Total	tracing	10.574 s	-
Total	appsec	10.696 s	121.966 ms (1.2%)
Total	iast	10.933 s	359.6 ms (3.4%)
Total	profiling	10.764 s	189.842 ms (1.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.068 s	-
Agent	appsec	1.196 s	127.612 ms (11.9%)
Agent	iast	1.18 s	112.184 ms (10.5%)
Agent	profiling	1.258 s	189.716 ms (17.8%)
Total	tracing	10.46 s	-
Total	appsec	10.729 s	269.132 ms (2.6%)
Total	iast	10.963 s	502.713 ms (4.8%)
Total	profiling	10.808 s	347.864 ms (3.3%)

gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~787e049d1a, baseline=1.46.0-SNAPSHOT~0b1e6ff859

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (711.466 ms) : 0, 711466
BytebuddyAgent [candidate] (723.427 ms) : 0, 723427
GlobalTracer [baseline] (254.927 ms) : 0, 254927
GlobalTracer [candidate] (257.28 ms) : 0, 257280
AppSec [baseline] (55.938 ms) : 0, 55938
AppSec [candidate] (57.1 ms) : 0, 57100
Remote Config [baseline] (737.429 µs) : 0, 737
Remote Config [candidate] (735.057 µs) : 0, 735
Telemetry [baseline] (13.634 ms) : 0, 13634
Telemetry [candidate] (14.395 ms) : 0, 14395
section appsec
BytebuddyAgent [baseline] (737.501 ms) : 0, 737501
BytebuddyAgent [candidate] (735.858 ms) : 0, 735858
GlobalTracer [baseline] (254.867 ms) : 0, 254867
GlobalTracer [candidate] (254.58 ms) : 0, 254580
AppSec [baseline] (171.108 ms) : 0, 171108
AppSec [candidate] (171.104 ms) : 0, 171104
Remote Config [baseline] (662.763 µs) : 0, 663
Remote Config [candidate] (667.449 µs) : 0, 667
Telemetry [baseline] (8.219 ms) : 0, 8219
Telemetry [candidate] (8.273 ms) : 0, 8273
IAST [baseline] (19.446 ms) : 0, 19446
IAST [candidate] (20.506 ms) : 0, 20506
section iast
BytebuddyAgent [baseline] (830.886 ms) : 0, 830886
BytebuddyAgent [candidate] (830.573 ms) : 0, 830573
GlobalTracer [baseline] (246.412 ms) : 0, 246412
GlobalTracer [candidate] (246.131 ms) : 0, 246131
AppSec [baseline] (57.855 ms) : 0, 57855
AppSec [candidate] (57.881 ms) : 0, 57881
Remote Config [baseline] (663.698 µs) : 0, 664
Remote Config [candidate] (678.727 µs) : 0, 679
Telemetry [baseline] (8.634 ms) : 0, 8634
Telemetry [candidate] (8.724 ms) : 0, 8724
IAST [baseline] (21.401 ms) : 0, 21401
IAST [candidate] (21.43 ms) : 0, 21430
section profiling
BytebuddyAgent [baseline] (704.048 ms) : 0, 704048
BytebuddyAgent [candidate] (703.505 ms) : 0, 703505
GlobalTracer [baseline] (349.529 ms) : 0, 349529
GlobalTracer [candidate] (351.701 ms) : 0, 351701
AppSec [baseline] (54.819 ms) : 0, 54819
AppSec [candidate] (55.276 ms) : 0, 55276
Remote Config [baseline] (660.398 µs) : 0, 660
Remote Config [candidate] (652.059 µs) : 0, 652
Telemetry [baseline] (8.901 ms) : 0, 8901
Telemetry [candidate] (8.834 ms) : 0, 8834
ProfilingAgent [baseline] (95.783 ms) : 0, 95783
ProfilingAgent [candidate] (96.007 ms) : 0, 96007
Profiling [baseline] (95.808 ms) : 0, 95808
Profiling [candidate] (96.031 ms) : 0, 96031

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-01-15T20:22:03	2025-01-15T20:29:08
git_branch	master	watson/env-redaction
git_commit_date	1736952276	1736971899
git_commit_sha	`0b1e6ff`	`787e049`
release_version	1.46.0-SNAPSHOT~0b1e6ff859	1.46.0-SNAPSHOT~787e049d1a
start_time	2025-01-15T20:21:49	2025-01-15T20:28:54

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1736973305	1736973305
ci_job_id	768063041	768063041
ci_pipeline_id	53123691	53123691
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~787e049d1a, baseline=1.46.0-SNAPSHOT~0b1e6ff859
    dateFormat X
    axisFormat %s
section baseline
no_agent (381.035 µs) : 361, 401
.   : milestone, 381,
iast (502.959 µs) : 481, 525
.   : milestone, 503,
iast_FULL (745.934 µs) : 724, 768
.   : milestone, 746,
iast_GLOBAL (553.899 µs) : 532, 575
.   : milestone, 554,
iast_HARDCODED_SECRET_DISABLED (502.232 µs) : 481, 524
.   : milestone, 502,
iast_INACTIVE (456.988 µs) : 436, 478
.   : milestone, 457,
iast_TELEMETRY_OFF (502.851 µs) : 480, 525
.   : milestone, 503,
tracing (452.113 µs) : 431, 474
.   : milestone, 452,
section candidate
no_agent (375.851 µs) : 356, 395
.   : milestone, 376,
iast (502.185 µs) : 480, 524
.   : milestone, 502,
iast_FULL (739.072 µs) : 717, 761
.   : milestone, 739,
iast_GLOBAL (553.253 µs) : 531, 575
.   : milestone, 553,
iast_HARDCODED_SECRET_DISABLED (507.473 µs) : 486, 529
.   : milestone, 507,
iast_INACTIVE (458.007 µs) : 437, 479
.   : milestone, 458,
iast_TELEMETRY_OFF (498.438 µs) : 476, 521
.   : milestone, 498,
tracing (446.988 µs) : 426, 468
.   : milestone, 447,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	381.035 µs [361.27 µs, 400.801 µs]	-
iast	502.959 µs [481.111 µs, 524.807 µs]	121.924 µs (32.0%)
iast_FULL	745.934 µs [724.188 µs, 767.681 µs]	364.899 µs (95.8%)
iast_GLOBAL	553.899 µs [532.343 µs, 575.456 µs]	172.864 µs (45.4%)
iast_HARDCODED_SECRET_DISABLED	502.232 µs [480.538 µs, 523.926 µs]	121.197 µs (31.8%)
iast_INACTIVE	456.988 µs [435.559 µs, 478.417 µs]	75.953 µs (19.9%)
iast_TELEMETRY_OFF	502.851 µs [480.26 µs, 525.442 µs]	121.815 µs (32.0%)
tracing	452.113 µs [430.526 µs, 473.7 µs]	71.078 µs (18.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	375.851 µs [356.256 µs, 395.445 µs]	-
iast	502.185 µs [480.438 µs, 523.932 µs]	126.335 µs (33.6%)
iast_FULL	739.072 µs [717.241 µs, 760.903 µs]	363.221 µs (96.6%)
iast_GLOBAL	553.253 µs [531.348 µs, 575.157 µs]	177.402 µs (47.2%)
iast_HARDCODED_SECRET_DISABLED	507.473 µs [485.921 µs, 529.025 µs]	131.623 µs (35.0%)
iast_INACTIVE	458.007 µs [436.681 µs, 479.334 µs]	82.157 µs (21.9%)
iast_TELEMETRY_OFF	498.438 µs [476.26 µs, 520.616 µs]	122.588 µs (32.6%)
tracing	446.988 µs [426.11 µs, 467.866 µs]	71.137 µs (18.9%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~787e049d1a, baseline=1.46.0-SNAPSHOT~0b1e6ff859
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.346 ms) : 1326, 1366
.   : milestone, 1346,
appsec (1.768 ms) : 1744, 1792
.   : milestone, 1768,
appsec_no_iast (1.754 ms) : 1730, 1777
.   : milestone, 1754,
iast (1.511 ms) : 1487, 1535
.   : milestone, 1511,
profiling (1.548 ms) : 1523, 1573
.   : milestone, 1548,
tracing (1.508 ms) : 1484, 1533
.   : milestone, 1508,
section candidate
no_agent (1.352 ms) : 1333, 1372
.   : milestone, 1352,
appsec (1.761 ms) : 1738, 1785
.   : milestone, 1761,
appsec_no_iast (1.744 ms) : 1719, 1770
.   : milestone, 1744,
iast (1.512 ms) : 1487, 1537
.   : milestone, 1512,
profiling (1.527 ms) : 1504, 1550
.   : milestone, 1527,
tracing (1.465 ms) : 1440, 1490
.   : milestone, 1465,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.346 ms [1.326 ms, 1.366 ms]	-
appsec	1.768 ms [1.744 ms, 1.792 ms]	421.668 µs (31.3%)
appsec_no_iast	1.754 ms [1.73 ms, 1.777 ms]	407.8 µs (30.3%)
iast	1.511 ms [1.487 ms, 1.535 ms]	165.334 µs (12.3%)
profiling	1.548 ms [1.523 ms, 1.573 ms]	201.752 µs (15.0%)
tracing	1.508 ms [1.484 ms, 1.533 ms]	162.34 µs (12.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.352 ms [1.333 ms, 1.372 ms]	-
appsec	1.761 ms [1.738 ms, 1.785 ms]	409.024 µs (30.2%)
appsec_no_iast	1.744 ms [1.719 ms, 1.77 ms]	392.247 µs (29.0%)
iast	1.512 ms [1.487 ms, 1.537 ms]	159.785 µs (11.8%)
profiling	1.527 ms [1.504 ms, 1.55 ms]	174.355 µs (12.9%)
tracing	1.465 ms [1.44 ms, 1.49 ms]	112.533 µs (8.3%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	watson/env-redaction
git_commit_date	1736952276	1736971899
git_commit_sha	`0b1e6ff`	`787e049`
release_version	1.46.0-SNAPSHOT~0b1e6ff859	1.46.0-SNAPSHOT~787e049d1a

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1736973989	1736973989
ci_job_id	768063042	768063042
ci_pipeline_id	53123691	53123691
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~787e049d1a, baseline=1.46.0-SNAPSHOT~0b1e6ff859
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.879 s) : 14879000, 14879000
.   : milestone, 14879000,
appsec (15.055 s) : 15055000, 15055000
.   : milestone, 15055000,
iast (19.081 s) : 19081000, 19081000
.   : milestone, 19081000,
iast_GLOBAL (17.854 s) : 17854000, 17854000
.   : milestone, 17854000,
profiling (15.026 s) : 15026000, 15026000
.   : milestone, 15026000,
tracing (14.983 s) : 14983000, 14983000
.   : milestone, 14983000,
section candidate
no_agent (14.821 s) : 14821000, 14821000
.   : milestone, 14821000,
appsec (14.837 s) : 14837000, 14837000
.   : milestone, 14837000,
iast (19.122 s) : 19122000, 19122000
.   : milestone, 19122000,
iast_GLOBAL (18.19 s) : 18190000, 18190000
.   : milestone, 18190000,
profiling (14.906 s) : 14906000, 14906000
.   : milestone, 14906000,
tracing (15.1 s) : 15100000, 15100000
.   : milestone, 15100000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.879 s [14.879 s, 14.879 s]	-
appsec	15.055 s [15.055 s, 15.055 s]	176.0 ms (1.2%)
iast	19.081 s [19.081 s, 19.081 s]	4.202 s (28.2%)
iast_GLOBAL	17.854 s [17.854 s, 17.854 s]	2.975 s (20.0%)
profiling	15.026 s [15.026 s, 15.026 s]	147.0 ms (1.0%)
tracing	14.983 s [14.983 s, 14.983 s]	104.0 ms (0.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.821 s [14.821 s, 14.821 s]	-
appsec	14.837 s [14.837 s, 14.837 s]	16.0 ms (0.1%)
iast	19.122 s [19.122 s, 19.122 s]	4.301 s (29.0%)
iast_GLOBAL	18.19 s [18.19 s, 18.19 s]	3.369 s (22.7%)
profiling	14.906 s [14.906 s, 14.906 s]	85.0 ms (0.6%)
tracing	15.1 s [15.1 s, 15.1 s]	279.0 ms (1.9%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~787e049d1a, baseline=1.46.0-SNAPSHOT~0b1e6ff859
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.47 ms) : 1458, 1481
.   : milestone, 1470,
appsec (2.356 ms) : 2313, 2398
.   : milestone, 2356,
iast (2.108 ms) : 2054, 2162
.   : milestone, 2108,
iast_GLOBAL (2.147 ms) : 2092, 2201
.   : milestone, 2147,
profiling (1.962 ms) : 1919, 2005
.   : milestone, 1962,
tracing (1.947 ms) : 1905, 1988
.   : milestone, 1947,
section candidate
no_agent (1.469 ms) : 1457, 1480
.   : milestone, 1469,
appsec (2.371 ms) : 2328, 2414
.   : milestone, 2371,
iast (2.109 ms) : 2055, 2164
.   : milestone, 2109,
iast_GLOBAL (2.154 ms) : 2099, 2208
.   : milestone, 2154,
profiling (1.962 ms) : 1919, 2005
.   : milestone, 1962,
tracing (1.953 ms) : 1911, 1995
.   : milestone, 1953,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.47 ms [1.458 ms, 1.481 ms]	-
appsec	2.356 ms [2.313 ms, 2.398 ms]	886.116 µs (60.3%)
iast	2.108 ms [2.054 ms, 2.162 ms]	638.096 µs (43.4%)
iast_GLOBAL	2.147 ms [2.092 ms, 2.201 ms]	676.988 µs (46.1%)
profiling	1.962 ms [1.919 ms, 2.005 ms]	492.756 µs (33.5%)
tracing	1.947 ms [1.905 ms, 1.988 ms]	477.16 µs (32.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.469 ms [1.457 ms, 1.48 ms]	-
appsec	2.371 ms [2.328 ms, 2.414 ms]	902.113 µs (61.4%)
iast	2.109 ms [2.055 ms, 2.164 ms]	640.489 µs (43.6%)
iast_GLOBAL	2.154 ms [2.099 ms, 2.208 ms]	684.966 µs (46.6%)
profiling	1.962 ms [1.919 ms, 2.005 ms]	493.248 µs (33.6%)
tracing	1.953 ms [1.911 ms, 1.995 ms]	484.201 µs (33.0%)

watson · 2025-01-15T19:08:02Z

I'm not sure about the failing "Check pull request" CI jobs. Is that a blocker for merging or? (I haven't contributed to this repo before, so I'm not sure about the process)

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.25.4` -> `2.26.0` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.45.2` -> `1.46.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.45.2` -> `1.46.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | --- ### Release Notes <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.26.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2260-2025-01-29) ##### Features - Add firestoreInDatastoreMode for datastore emulator ([#1698](googleapis/java-datastore#1698)) ([50f106d](googleapis/java-datastore@50f106d)) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.42.0 ([#1725](googleapis/java-datastore#1725)) ([1cbaf22](googleapis/java-datastore@1cbaf22)) </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.46.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.46.0): 1.46.0 ##### Breaking Changes > \[!WARNING] > jnr-unixsocket is now an external dependency of dd-trace-ot and must be included when deploying dd-trace-ot. > \[!NOTE] > The API `TracerScope.setAsync(boolean)`, used to manually control asynchronous span propagation, does no more apply to the scope instance but to the active span scope. ##### Components ##### Application Security Management (IAST) - 🐛 Fix String.replace instrumentation for IAST ([#8281](DataDog/dd-trace-java#8281) - [@Mariovido](https://github.com/Mariovido)) - ✨ Apply the standard nomenclature to the stacktrace configs ([#8244](DataDog/dd-trace-java#8244) - [@jandro996](https://github.com/jandro996)) - 🐛 Exclude false positive weak randomness ([#8232](DataDog/dd-trace-java#8232) - [@jandro996](https://github.com/jandro996)) - ✨ Propagation of translateEscapes of String class ([#8186](DataDog/dd-trace-java#8186) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Add security control metrics ([#8175](DataDog/dd-trace-java#8175) - [@jandro996](https://github.com/jandro996)) - ✨ Increase IAST propagation to StringBuffer setLength ([#8128](DataDog/dd-trace-java#8128) - [@Mariovido](https://github.com/Mariovido)) - ✨ Add IAST taint tracking for DB values ([#8072](DataDog/dd-trace-java#8072) - [@Mariovido](https://github.com/Mariovido)) ##### Application Security Management (WAF) - 🐛 Prevents a NPE when there is no subscriber for user events ([#8258](DataDog/dd-trace-java#8258) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Apply the standard nomenclature to the stacktrace configs ([#8244](DataDog/dd-trace-java#8244) - [@jandro996](https://github.com/jandro996)) - 🐛 Ensure cached subscriptions are cleared on reconfiguration via RC ([#8229](DataDog/dd-trace-java#8229) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Add support for session tracking in Vertx ([#8167](DataDog/dd-trace-java#8167) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Create span tag: \_dd.appsec.rasp.timeout ([#8269](DataDog/dd-trace-java#8269) - [@Mariovido](https://github.com/Mariovido)) ##### Build & Tooling - 🐛 Ensure shaded helpers have unique names when injected into class-loaders ([#8192](DataDog/dd-trace-java#8192) - [@mcculls](https://github.com/mcculls)) ##### Configuration at Runtime - 🐛 Remove filtering of `DD_SERVICE` and `DD_ENV` from the tracer ([#8176](DataDog/dd-trace-java#8176) - [@mhlidd](https://github.com/mhlidd)) ##### Continuous Integration Visibility - 🧹 Generalize TestRetryPolicy to TestExecutionPolicy ([#8302](DataDog/dd-trace-java#8302) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Parallelize CI Visibility settings requests ([#8299](DataDog/dd-trace-java#8299) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Generalize test retry logic ([#8289](DataDog/dd-trace-java#8289) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Generalize tests skipping logic ([#8288](DataDog/dd-trace-java#8288) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Remove skip and shouldBeSkipped methods from TestEventsHandler in favor of isSkippable ([#8286](DataDog/dd-trace-java#8286) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨⚡ Optimize Git repository information computation ([#8270](DataDog/dd-trace-java#8270) - [@dougqh](https://github.com/dougqh)) - ✨ Always request known tests from the backend ([#8268](DataDog/dd-trace-java#8268) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Fix NPE when trying to get retry analyzer in Test NG ([#8253](DataDog/dd-trace-java#8253) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Set test framework and test framework version tags atomically ([#8252](DataDog/dd-trace-java#8252) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add debug logging to Android Gradle module layout logic ([#8251](DataDog/dd-trace-java#8251) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix source and destination folders computation for Android Gradle projects ([#8190](DataDog/dd-trace-java#8190) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add basic Scala Weaver sbt support ([#8189](DataDog/dd-trace-java#8189) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement impacted tests detection ([#8188](DataDog/dd-trace-java#8188) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ##### Data Streams Monitoring - ✨ Change hash computation for protobuf to better represent impacting changes + save proto number in schema ([#8201](DataDog/dd-trace-java#8201) - [@vandonr](https://github.com/vandonr)) ##### Database Monitoring - Add peer service tag in dbm sql commenter ([#7913](DataDog/dd-trace-java#7913) - [@jordan-wong](https://github.com/jordan-wong)) ##### Dynamic Instrumentation - ✨ Add support for SymDB to scan directories ([#8306](DataDog/dd-trace-java#8306) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add SymDB report for any jar scanning failures ([#8300](DataDog/dd-trace-java#8300) - [@jpbempel](https://github.com/jpbempel)) - ✨ Use two budgets depending on type ([#8283](DataDog/dd-trace-java#8283) - [@evanchooly](https://github.com/evanchooly)) - ✨ Institute a 10 snapshot per probe per trace budget ([#8277](DataDog/dd-trace-java#8277) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Avoid double snapshots for Exception Replay ([#8273](DataDog/dd-trace-java#8273) - [@jpbempel](https://github.com/jpbempel)) - ✨ Simplify code origins. Separate out snapshot generation. ([#8263](DataDog/dd-trace-java#8263) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add Exception probe custom instrumentation ([#8230](DataDog/dd-trace-java#8230) - [@jpbempel](https://github.com/jpbempel)) - ✨ Enhance log probes to honor debug session tags ([#8215](DataDog/dd-trace-java#8215) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Don't redact env tokens from debugger probe snapshots ([#8211](DataDog/dd-trace-java#8211) - [@watson](https://github.com/watson)) - ✨⚡ Move Trace/SpanId capture at commit time ([#8184](DataDog/dd-trace-java#8184) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Capture values at entry for method probe ([#8169](DataDog/dd-trace-java#8169) - [@jpbempel](https://github.com/jpbempel)) ##### JMX fetch - 🐛 Mute JMXFetch Shutdown in progress error ([#8068](DataDog/dd-trace-java#8068) - [@ygree](https://github.com/ygree)) ##### OpenTracing - ⚠️🧹 Make jnr-unixsocket an explicit dependency of dd-trace-ot ([#8307](DataDog/dd-trace-java#8307) - [@mcculls](https://github.com/mcculls)) ##### Profiling - 🐛 Avoid unsupported API call for creating folders on windows ([#8304](DataDog/dd-trace-java#8304) - [@jbachorik](https://github.com/jbachorik)) - ✨ Tag profiles for serverless ([#8279](DataDog/dd-trace-java#8279) - [@jbachorik](https://github.com/jbachorik)) - ✨ add queue type and length to queue events ([#8242](DataDog/dd-trace-java#8242) - [@richardstartin](https://github.com/richardstartin)) - 🐛 TempLocationManager Fixes and Improvements ([#8191](DataDog/dd-trace-java#8191) - [@jbachorik](https://github.com/jbachorik)) - ✨ Bump ddprof to 1.18.0 ([#8173](DataDog/dd-trace-java#8173) - [@jbachorik](https://github.com/jbachorik)) - ✨ Report profiler initialization and configuration errors to telemetry ([#8171](DataDog/dd-trace-java#8171) - [@jbachorik](https://github.com/jbachorik)) ##### Telemetry - ✨ Add pending traces report in tracer flares ([#8053](DataDog/dd-trace-java#8053) - [@mhlidd](https://github.com/mhlidd)) ##### Testing - ✨ Test http server requests in parallel ([#8222](DataDog/dd-trace-java#8222) - [@amarziali](https://github.com/amarziali)) ##### Trace context propagation - ✨ Add non default propagator registration ([#8310](DataDog/dd-trace-java#8310) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - ✨ Probe for existence of IBMSASL or ACCP security providers ([#8276](DataDog/dd-trace-java#8276) - [@mcculls](https://github.com/mcculls)) - ✨⚡ Overhead improvement to agent feedback based sampling ([#8265](DataDog/dd-trace-java#8265) - [@dougqh](https://github.com/dougqh)) - 🧹 Move async propagation API from scope to tracer ([#8231](DataDog/dd-trace-java#8231) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Introduce context propagation API ([#8161](DataDog/dd-trace-java#8161) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨🧪 Use env-entry to add tags per webapp deployment ([#8138](DataDog/dd-trace-java#8138) - [@amarziali](https://github.com/amarziali)) - ✨ Introduce context helpers API ([#8134](DataDog/dd-trace-java#8134) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Support IPv6 values for `DD_AGENT_HOST` and `DD_TRACE_AGENT_URL` ([#7984](DataDog/dd-trace-java#7984) - [@mhlidd](https://github.com/mhlidd)) ##### Instrumentations ##### Apache HttpComponents - 🐛 Properly finish spans and support latest apache httpclient5 ([#8272](DataDog/dd-trace-java#8272) - [@amarziali](https://github.com/amarziali)) ##### AWS Lambda instrumentation - 🐛 Properly capture lambda payloads for all handler types. ([#8264](DataDog/dd-trace-java#8264) - [@purple4reina](https://github.com/purple4reina)) ##### AWS S3 instrumentation - 💡 Create S3 instrumentation + add span pointers ([#8075](DataDog/dd-trace-java#8075) - [@nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - 🐛 Revert "Add avoid double instrumenting lambda non-streaming handlers." ([#8247](DataDog/dd-trace-java#8247) - [@nhulston](https://github.com/nhulston)) ##### Cassandra - ✨ Allow extracting keyspace from statement result ([#8239](DataDog/dd-trace-java#8239) - [@amarziali](https://github.com/amarziali)) ##### Core Java language instrumentation - ✨ Propagation of translateEscapes of String class ([#8186](DataDog/dd-trace-java#8186) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Eclipse Vert.x instrumentation - 🐛 Fix vertx worker propagation and error handling ([#8237](DataDog/dd-trace-java#8237) - [@amarziali](https://github.com/amarziali)) - ✨ Support vertx 5 ([#8220](DataDog/dd-trace-java#8220) - [@amarziali](https://github.com/amarziali)) - ✨ Add support for session tracking in Vertx ([#8167](DataDog/dd-trace-java#8167) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) ##### Kafka instrumentation - 🐛 Prevent possible NPE calculating Kafka record header size ([#8292](DataDog/dd-trace-java#8292) - [@ygree](https://github.com/ygree)) ##### Mule instrumentation - 🐛 Fix crash using Mule with JPMS ([#8187](DataDog/dd-trace-java#8187) - [@amarziali](https://github.com/amarziali)) ##### Protocol Buffer instrumentation - ✨ Change hash computation for protobuf to better represent impacting changes + save proto number in schema ([#8201](DataDog/dd-trace-java#8201) - [@vandonr](https://github.com/vandonr)) ##### Spring instrumentation - 🐛 Preserve getQualifier from spring scheduling runnables ([#8293](DataDog/dd-trace-java#8293) - [@amarziali](https://github.com/amarziali)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: bb09d47e4eed77a003f630273b4d0a84003eb899

[Debugger] Don't redact env tokens from probe snapshots

b202506

watson requested a review from a team as a code owner January 15, 2025 14:49

watson requested review from jpbempel and removed request for a team January 15, 2025 14:49

tylfin approved these changes Jan 15, 2025

View reviewed changes

PerfectSlayer added type: bug Bug report and fix comp: debugger Dynamic Instrumentation labels Jan 15, 2025

PerfectSlayer changed the title ~~[Debugger] Don't redact env tokens from probe snapshots~~ Don't redact env tokens from debugger probe snapshots Jan 15, 2025

jpbempel approved these changes Jan 15, 2025

View reviewed changes

jpbempel added 2 commits January 15, 2025 20:39

Merge branch 'master' into watson/env-redaction

5862974

Update system-tests to 2cb5033072c1813eccdce332153a378607e73d85

787e049

jpbempel requested a review from a team as a code owner January 15, 2025 20:12

jpbempel requested a review from nayeem-kamal January 15, 2025 20:12

jpbempel added comp: debugger Dynamic Instrumentation and removed comp: debugger Dynamic Instrumentation labels Jan 15, 2025

jpbempel merged commit 6ece325 into master Jan 15, 2025
177 of 178 checks passed

jpbempel deleted the watson/env-redaction branch January 15, 2025 21:11

github-actions bot added this to the 1.46.0 milestone Jan 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't redact env tokens from debugger probe snapshots#8211