feat: add multi launch scripts with icons#304
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 150afb0777
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pendingRunRef.current = { | ||
| workspaceId: activeWorkspace.id, | ||
| terminalId, | ||
| script: entry.script, | ||
| entryId: entry.id, |
There was a problem hiding this comment.
When a user clicks two launch script buttons in quick succession, pendingRunRef.current is overwritten before the first terminal becomes ready, so only the last script ever gets written to its session. This is new behavior specific to the multi-script feature (previously there was only one script), and it breaks the expectation that each script runs in its own terminal session. Consider storing pending launches keyed by terminalId (or queueing per entry) so multiple rapid launches can complete independently.
Useful? React with 👍 / 👎.
Dimillian
changed the title
2 participants
Purpose
Enable multiple launch scripts per workspace with per-script icons and terminals, persisted across app restarts.
Changes
Testing
Screenshot
Notes
I have never worked with TypeScript or Tauri, so I am not familiar with how the changes work. I tried to apply the same approach I use in my Xcode projects, so I hope the changes are correct. If not, please let me know what we can improve, and you are free to update improve it as you wish :)