KMS: add factory deployment for AppAuth contracts with single-transaction optimization#182
Merged
Leechael merged 1 commit intofeat/gateway-rpc-domain-and-kms-info-enhancementsfrom May 30, 2025
Conversation
Leechael
force-pushed
the
imp-app-auth-contract
branch
2 times, most recently
from
06d9332 to
fefd1b9
Compare
kvinwang
reviewed
May 26, 2025
h4x3rotab
reviewed
May 26, 2025
| ); | ||
|
|
||
| // Deploy proxy contract | ||
| proxyAddress = address(new ERC1967Proxy(appAuthImplementation, initData)); |
Contributor
There was a problem hiding this comment.
I need to double check if this is the preferred way to deploy a UUPS upgradable contract.
Leechael
force-pushed
the
feat/gateway-rpc-domain-and-kms-info-enhancements
branch
2 times, most recently
from
a6d4fe2 to
fd405e1
Compare
Leechael
force-pushed
the
imp-app-auth-contract
branch
from
552d81e to
b610026
Compare
kvinwang
pushed a commit
that referenced
this pull request
Jan 19, 2026
KMS: add factory deployment for AppAuth contracts with single-transaction optimization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.