feat: improve error message for CloudEvent#310
Merged
coryan merged 1 commit intoGoogleCloudPlatform:mainfrom Aug 12, 2021
coryan:feat-improve-cloud-event-json-parsing-error-message
Merged
feat: improve error message for CloudEvent#310coryan merged 1 commit intoGoogleCloudPlatform:mainfrom coryan:feat-improve-cloud-event-json-parsing-error-message
coryan merged 1 commit intoGoogleCloudPlatform:mainfrom
coryan:feat-improve-cloud-event-json-parsing-error-message
Conversation
When parsing CloudEvents in JSON format the error message was a bit obscure, it indicated that a field was missing, but not which one. This is more readable in the common case.
devjgm
approved these changes
Aug 12, 2021
Codecov Report
@@ Coverage Diff @@
## main #310 +/- ##
===========================================
- Coverage 88.79% 55.47% -33.32%
===========================================
Files 88 562 +474
Lines 2303 15105 +12802
===========================================
+ Hits 2045 8380 +6335
- Misses 258 6725 +6467
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parsing CloudEvents in JSON format the error message was a bit
obscure, it indicated that a field was missing, but not which one. This
is more readable in the common case.