allow a custom css class to be applied on anchorlinks and permalinks#776
Closed
ggueret wants to merge 3 commits intoPython-Markdown:masterfrom
Closed
allow a custom css class to be applied on anchorlinks and permalinks#776ggueret wants to merge 3 commits intoPython-Markdown:masterfrom
ggueret wants to merge 3 commits intoPython-Markdown:masterfrom
Conversation
Closed
waylan
requested changes
Jan 10, 2019
Member
waylan
left a comment
waylan
left a comment
There was a problem hiding this comment.
In addition to the one change requested below, a comment should be added to the release notes. Otherwise this looks good.
waylan
added
feature
waylan
added a commit
to waylan/markdown
that referenced
this pull request
Nov 26, 2019
Member
|
This is being closed on favor of #885, which uses this as a base. |
waylan
added
rejected
waylan
added a commit
that referenced
this pull request
Nov 26, 2019
Two new configuration options have been added to the toc extension: `anchorlink_class` and `permalink_class` which allows class(es) to be assigned to the `anchorlink` and `permalink` HTML respectively. This allows using icon fonts from CSS for the links. Therefore, an empty string passed to `permalink` now generates an empty `permalink`. Previously no `permalink` would have been generated. Based on #776.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request follows on #771 that I closed because it is no longer relevant.
The goal is to allow a custom css class to be applied on permalinks as suggested by @waylan in the original pull request (I unfortunately did not see your answer during my last changes).
It perfectly fulfills my need with font-awesome. Indeed, there is no need for an extra tag and it seems semantically better to apply
fa-classes to a link that has a title attribute.So I added the same keyword logic "_class" for the anchorlinks, for that matter.
I fixed the case that if the permalink is an empty string, it is treated as
Falseand thus disabled. I guess this is the expected behavior when I look at this line, could you confirm ?I hope this pull request can be merged as is, I remain available if changes need to be made.