Switch from unlink to wp_delete_file#163
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #163 +/- ##
==========================================
Coverage 46.89% 46.89%
Complexity 208 208
==========================================
Files 19 19
Lines 1271 1271
==========================================
Hits 596 596
Misses 675 675
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What?
Closes #160
Fixes failing Plugin Check tests
Why?
We recently updated our plugin check tests and we now have a new failure. This PR addresses that
How?
Switch from using
unlinkto usingwp_delete_file(which usesunlinkunder the hood)Testing Instructions
Not really needed but if desired, can follow testing instructions in #134