Delete option when uninstalling the Modern Image Formats plugin#1116
Delete option when uninstalling the Modern Image Formats plugin#1116mukeshpanchal27 merged 4 commits intorelease/3.0.0from
Conversation
Merge `release/3.0.0` additions into `trunk` to unblock
|
For now, I've moved this PR to the |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
felixarntz
left a comment
There was a problem hiding this comment.
@mukeshpanchal27 Great catch!
Note that the WebP Uploads 1.1.0 release will be published next Monday, so let's add it to the corresponding milestone, especially since you also implemented this against the release branch.
felixarntz
left a comment
There was a problem hiding this comment.
@mukeshpanchal27 Can you please also add an entry for this to the WebP Upload's readme.txt? This cycle is the last time that we're adding those manually, afterwards we can rely on the new script to handle it for us.
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Summary
We removed the module infrastructure in #1060 from the Performance Lab plugin. In #345, we introduced an uninstaller routine that removes options when the plugin is uninstalled from the site.
We should move the
uninstall.phpfile to the WebP Uploads folder, as that plugin adds that option.